Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26076

NPE on Manage Jenkins Page related to hudson.plugins.perforce.PerforcePasswordEncryptor

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Ubuntu 12.04, jenkins 1.580.1, perforce-plugin 1.3.31
    • Similar Issues:

      Description

      When I do some configuration and click on manage jenkins page it failes with following NPE.

      hudson.plugins.perforce.PerforcePasswordEncryptor.appearsToBeAnEncryptedPassword(PerforcePasswordEncryptor.java:30)
      	at hudson.plugins.perforce.PerforceSCM$PerforceSCMDescriptor.setDefaultP4Passwd(PerforceSCM.java:1929)
      	at hudson.plugins.perforce.PerforceSCM$PerforceSCMDescriptor.configure(PerforceSCM.java:1961)
      	at jenkins.model.Jenkins.configureDescriptor(Jenkins.java:2898)
      	at jenkins.model.Jenkins.doConfigSubmit(Jenkins.java:2861)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:606)
      	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:298)
      	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:161)
      	at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:96)
      	at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:121)
      	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
      	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:745)
      	... 44 more
      

        Attachments

          Issue Links

            Activity

            Hide
            khakunin manohar joshi added a comment -

            Hello Rob,
            When I dont provide any value for perforce default username and password. This exception is thrown.

            Thanks
            Manohar

            Show
            khakunin manohar joshi added a comment - Hello Rob, When I dont provide any value for perforce default username and password. This exception is thrown. Thanks Manohar
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Confirmed. I have checked value setup flows, but forgot to add proper checks to verify methods

            Show
            oleg_nenashev Oleg Nenashev added a comment - Confirmed. I have checked value setup flows, but forgot to add proper checks to verify methods
            Show
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/perforce-plugin/pull/64
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/plugins/perforce/PerforcePasswordEncryptor.java
            src/main/java/hudson/plugins/perforce/PerforceSCM.java
            src/test/java/hudson/plugins/perforce/PerforcePasswordEncryptorTest.java
            http://jenkins-ci.org/commit/perforce-plugin/7da810be2f48b96833b5b4a80506952ed3e3303a
            Log:
            [FIXED JENKINS-26076] - Add null checks and proper annotations

            Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/perforce/PerforcePasswordEncryptor.java src/main/java/hudson/plugins/perforce/PerforceSCM.java src/test/java/hudson/plugins/perforce/PerforcePasswordEncryptorTest.java http://jenkins-ci.org/commit/perforce-plugin/7da810be2f48b96833b5b4a80506952ed3e3303a Log: [FIXED JENKINS-26076] - Add null checks and proper annotations Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/plugins/perforce/PerforcePasswordEncryptor.java
            src/main/java/hudson/plugins/perforce/PerforceSCM.java
            src/test/java/hudson/plugins/perforce/PerforcePasswordEncryptorTest.java
            http://jenkins-ci.org/commit/perforce-plugin/06a1d0ced6c56e7511c084a7689cca23dc214c59
            Log:
            Merge pull request #64 from synopsys-arc-oss/JENKINS-26076

            [FIXED JENKINS-26076] - Add null checks and proper annotations

            Compare: https://github.com/jenkinsci/perforce-plugin/compare/df83c3fe8a7f...06a1d0ced6c5

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/perforce/PerforcePasswordEncryptor.java src/main/java/hudson/plugins/perforce/PerforceSCM.java src/test/java/hudson/plugins/perforce/PerforcePasswordEncryptorTest.java http://jenkins-ci.org/commit/perforce-plugin/06a1d0ced6c56e7511c084a7689cca23dc214c59 Log: Merge pull request #64 from synopsys-arc-oss/ JENKINS-26076 [FIXED JENKINS-26076] - Add null checks and proper annotations Compare: https://github.com/jenkinsci/perforce-plugin/compare/df83c3fe8a7f...06a1d0ced6c5

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                khakunin manohar joshi
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: