Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26092

executors.jelly interface underspecified

    Details

    • Similar Issues:

      Description

      Calls various unspecified methods on the Queue.Executable. Should be extracted into an interface.

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          See AfterRestartTask/Body/executorCell.jelly for example.

          Show
          jglick Jesse Glick added a comment - See AfterRestartTask/Body/executorCell.jelly for example.
          Hide
          jglick Jesse Glick added a comment -

          Or now just PlaceholderExecutable/executorCell.jelly after https://github.com/jenkinsci/workflow-plugin/pull/96.

          Show
          jglick Jesse Glick added a comment - Or now just PlaceholderExecutable/executorCell.jelly after https://github.com/jenkinsci/workflow-plugin/pull/96 .
          Hide
          jglick Jesse Glick added a comment -

          Javadoc already confirms that the implementation must have an executorCell.jelly, so the fallback body does not matter much. (It is used for AbstractBuild and WorkflowRun, both of which currently meet its requirements.) Too much work to refactor Jelly code with no compile-time safety. Some of the unchecked calls are anyway on Queue.SubTask rather than Queue.Executable.

          Show
          jglick Jesse Glick added a comment - Javadoc already confirms that the implementation must have an executorCell.jelly , so the fallback body does not matter much. (It is used for AbstractBuild and WorkflowRun , both of which currently meet its requirements.) Too much work to refactor Jelly code with no compile-time safety. Some of the unchecked calls are anyway on Queue.SubTask rather than Queue.Executable .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/resources/lib/hudson/buildProgressBar.jelly
          http://jenkins-ci.org/commit/jenkins/09f7a2d3d120d77497da1e566a6719ec6feac7ee
          Log:
          JENKINS-26092 Noting some things that could be improved.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/hudson/buildProgressBar.jelly http://jenkins-ci.org/commit/jenkins/09f7a2d3d120d77497da1e566a6719ec6feac7ee Log: JENKINS-26092 Noting some things that could be improved.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4029
          JENKINS-26092 Noting some things that could be improved. (Revision 09f7a2d3d120d77497da1e566a6719ec6feac7ee)

          Result = SUCCESS
          jesse glick : 09f7a2d3d120d77497da1e566a6719ec6feac7ee
          Files :

          • core/src/main/resources/lib/hudson/buildProgressBar.jelly
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4029 JENKINS-26092 Noting some things that could be improved. (Revision 09f7a2d3d120d77497da1e566a6719ec6feac7ee) Result = SUCCESS jesse glick : 09f7a2d3d120d77497da1e566a6719ec6feac7ee Files : core/src/main/resources/lib/hudson/buildProgressBar.jelly

            People

            • Assignee:
              Unassigned
              Reporter:
              jglick Jesse Glick
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: