Details

    • Similar Issues:

      Description

      A flow which just had

      node('...') {sh 'echo hi'}
      

      waited for a node matching the label. I restarted Jenkins after changing something so that the label would be available. The shell step ran, but then the flow failed with

      ...
      Running: Allocate node : End
      Running: End of Workflow
      java.io.NotSerializableException: org.jenkinsci.plugins.workflow.job.WorkflowJob
      	at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:890)
      	at org.jboss.marshalling.river.RiverMarshaller.doWriteFields(RiverMarshaller.java:1062)
      	at org.jboss.marshalling.river.RiverMarshaller.doWriteSerializableObject(RiverMarshaller.java:10S18)
      	at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:884)
      	at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:584)
      	at org.jboss.marshalling.AbstractObjectOutput.writeObject(AbstractObjectOutput.java:58)
      	at org.jboss.marshalling.AbstractMarshaller.writeObject(AbstractMarshaller.java:111)
      	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.close(RiverWriter.java:145)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:341)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:323)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:297)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:71)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.call(CpsThreadGroup.java:183)
      	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.call(CpsThreadGroup.java:181)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
      	at java.lang.Thread.run(Thread.java:745)
      	at org.jenkinsci.plugins.workflow.cps.CpsVmThread.run(CpsVmThread.java:21)
      Caused by: an exception which occurred:
      	in field task
      	in object java.util.ArrayList@401ac88
      Finished: FAILURE
      

      CpsStepContext.getThread then began complaining that

          no thread 2 among []
      

      as the DurableTaskStep$Execution.run kept on running.

      It is not apparent from this stack trace why something is trying to serialize the job.

      Observed also in PR 21; https://github.com/jenkinsci/workflow-plugin/commit/a594618516a22e9e8bcd016808ca487efee80fff fixed it. Turned out in that case that the culprit was ExecutorPickle. But why could the error message not say that? It only said field task, which was not enough information.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            JENKINS-25925 discusses the case that the script is in error, by storing a nonserializable object. That was not the case here, where there is some sort of bug in Workflow code, so a stack trace is sensible—but ought to include better diagnostics.

            Show
            jglick Jesse Glick added a comment - JENKINS-25925 discusses the case that the script is in error, by storing a nonserializable object. That was not the case here, where there is some sort of bug in Workflow code, so a stack trace is sensible—but ought to include better diagnostics.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/cc76ee2256279676b4858cae95244585feceebaa
            Log:
            Checking sources for other possible restartability bugs as in JENKINS-26149.
            RetryStep looks suspicious but apparently works.
            PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137.

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/87553e9e6e35...cc76ee225627

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java http://jenkins-ci.org/commit/workflow-plugin/cc76ee2256279676b4858cae95244585feceebaa Log: Checking sources for other possible restartability bugs as in JENKINS-26149 . RetryStep looks suspicious but apparently works. PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137 . Compare: https://github.com/jenkinsci/workflow-plugin/compare/87553e9e6e35...cc76ee225627
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java
            http://jenkins-ci.org/commit/credentials-binding-plugin/707c1d82c1efa0c42e8daff6d487196c2c6dacbd
            Log:
            Trying to test JENKINS-26051 across restarts but blocked by JENKINS-26137.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStepTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/707c1d82c1efa0c42e8daff6d487196c2c6dacbd Log: Trying to test JENKINS-26051 across restarts but blocked by JENKINS-26137 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-plugin/3d3fa348ed9c34e4492b2733802bc47416824e30 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ).
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-plugin/9186a512e4ecf901217bc3f4b219810322e84db9
            Log:
            Merge pull request #33 from jenkinsci/JENKINS-26137-no-pickle-factories

            Make a test involving Jenkins restart pass

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/dd5eaf7aa09c...9186a512e4ec

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-plugin/9186a512e4ecf901217bc3f4b219810322e84db9 Log: Merge pull request #33 from jenkinsci/ JENKINS-26137 -no-pickle-factories Make a test involving Jenkins restart pass Compare: https://github.com/jenkinsci/workflow-plugin/compare/dd5eaf7aa09c...9186a512e4ec
            Hide
            jglick Jesse Glick added a comment -

            Observed during a build with safeRestart in 1.8:

            java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down
            	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:93)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:342)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:328)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:303)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:71)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:180)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:178)
            	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
            
            Show
            jglick Jesse Glick added a comment - Observed during a build with safeRestart in 1.8: java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:93) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:342) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:328) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:303) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:71) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:180) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:178) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
            Hide
            jglick Jesse Glick added a comment -

            Specifically demo can fail if you /restart at just the wrong point:

            …
            [longerTests] Running org.jenkinsci.plugins.workflow.demo.AppTest
            [Workflow] } //node
            [Workflow] Allocate node : End
            [Workflow] } //parallel
            [Workflow] } //node
            [Workflow] } //parallel
            [Workflow] End of Workflow
            java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down
            	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:92)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:345)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:331)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:306)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:74)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:183)
            	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:181)
            	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
            	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
            	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
            	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
            	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
            	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
            	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
            	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
            	at java.lang.Thread.run(Thread.java:745)
            Finished: FAILURE
            
            Show
            jglick Jesse Glick added a comment - Specifically demo can fail if you /restart at just the wrong point: … [longerTests] Running org.jenkinsci.plugins.workflow.demo.AppTest [Workflow] } //node [Workflow] Allocate node : End [Workflow] } //parallel [Workflow] } //node [Workflow] } //parallel [Workflow] End of Workflow java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:92) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:345) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:331) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:306) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:74) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:183) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:181) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Finished: FAILURE
            Hide
            as_kumlali Ali Sadik Kumlali added a comment -

            I came across the same error with Jenkins 2 - alpha 3. XmlSlurper().parseText() seems to trigger it:

            New Item -> Pipeline, Pipeline script
            node {
                ...
               def pomXml = readFile('pom.xml')
            
               bat "echo before XmlSlurper().parseText()"
            
               def parsedPomXml = new XmlSlurper().parseText(pomXml)
            
               // Following line fails 
               bat "echo after XmlSlurper().parseText()"
            }
            
            Job's Console Output
            [Pipeline] readFile
            [Pipeline] bat
            [MyPipelineWithPipelineScript] Running batch script
            
            d:\workspace\projects\jenkins2_pipeline\home\workspace\MyPipelineWithPipelineScript>echo before XmlSlurper().parseText() 
            before XmlSlurper().parseText()
            [Pipeline] bat
            [MyPipelineWithPipelineScript] Running batch script
            [Pipeline] } //node
            [Pipeline] Allocate node : End
            [Pipeline] End of Pipeline
            java.io.NotSerializableException: groovy.util.slurpersupport.NodeChild
              at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:860)
              ...
              at org.jboss.marshalling.reflect.SerializableClass.callWriteObject(SerializableClass.java:271)
              at org.jboss.marshalling.river.RiverMarshaller.doWriteSerializableObject(RiverMarshaller.java:976)
              ...
              at org.jboss.marshalling.river.RiverObjectOutputStream.writeObjectOverride(RiverObjectOutputStream.java:179)
              at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:344)
              ...
              at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.writeObject(RiverWriter.java:132)
              at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:371)
              ...
              at java.util.concurrent.FutureTask.run(FutureTask.java:266)
              at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
              ...
              at java.lang.Thread.run(Thread.java:745)
            Caused by: an exception which occurred:
              in field locals
              in field caller
              in field e
              in field program
              in field threads
              in object org.jenkinsci.plugins.workflow.cps.CpsThreadGroup@7138f387
            Finished: FAILURE
            
            Show
            as_kumlali Ali Sadik Kumlali added a comment - I came across the same error with Jenkins 2 - alpha 3. XmlSlurper().parseText() seems to trigger it: New Item -> Pipeline, Pipeline script node { ... def pomXml = readFile( 'pom.xml' ) bat "echo before XmlSlurper().parseText()" def parsedPomXml = new XmlSlurper().parseText(pomXml) // Following line fails bat "echo after XmlSlurper().parseText()" } Job's Console Output [Pipeline] readFile [Pipeline] bat [MyPipelineWithPipelineScript] Running batch script d:\workspace\projects\jenkins2_pipeline\home\workspace\MyPipelineWithPipelineScript>echo before XmlSlurper().parseText() before XmlSlurper().parseText() [Pipeline] bat [MyPipelineWithPipelineScript] Running batch script [Pipeline] } //node [Pipeline] Allocate node : End [Pipeline] End of Pipeline java.io.NotSerializableException: groovy.util.slurpersupport.NodeChild at org.jboss.marshalling.river.RiverMarshaller.doWriteObject(RiverMarshaller.java:860) ... at org.jboss.marshalling.reflect.SerializableClass.callWriteObject(SerializableClass.java:271) at org.jboss.marshalling.river.RiverMarshaller.doWriteSerializableObject(RiverMarshaller.java:976) ... at org.jboss.marshalling.river.RiverObjectOutputStream.writeObjectOverride(RiverObjectOutputStream.java:179) at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:344) ... at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.writeObject(RiverWriter.java:132) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:371) ... at java.util.concurrent.FutureTask.run(FutureTask.java:266) at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112) ... at java.lang. Thread .run( Thread .java:745) Caused by: an exception which occurred: in field locals in field caller in field e in field program in field threads in object org.jenkinsci.plugins.workflow.cps.CpsThreadGroup@7138f387 Finished: FAILURE
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: support/src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/18ad074331b663f565633bf4fa8523ac68dc1a69 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/5a9db4b7a32a7985d4b63a5dad2170d3cc8fc0e6
            Log:
            Checking sources for other possible restartability bugs as in JENKINS-26149.
            RetryStep looks suspicious but apparently works.
            PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137.
            Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/RetryStepExecution.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/5a9db4b7a32a7985d4b63a5dad2170d3cc8fc0e6 Log: Checking sources for other possible restartability bugs as in JENKINS-26149 . RetryStep looks suspicious but apparently works. PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137 . Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/85812e78a3ab6c837b59002082e30bdc16294688 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/8f03c17d07933c822b2f5a9caa3d25fc059e972c
            Log:
            Merge pull request #33 from jenkinsci/JENKINS-26137-no-pickle-factories

            Make a test involving Jenkins restart pass
            Originally-Committed-As: 9186a512e4ecf901217bc3f4b219810322e84db9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java basic-steps/src/main/java/org/jenkinsci/plugins/workflow/steps/PushdStep.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/8f03c17d07933c822b2f5a9caa3d25fc059e972c Log: Merge pull request #33 from jenkinsci/ JENKINS-26137 -no-pickle-factories Make a test involving Jenkins restart pass Originally-Committed-As: 9186a512e4ecf901217bc3f4b219810322e84db9
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-scm-step-plugin/0aec9ed07c5fe959d08b5355c9353108143f1d58
            Log:
            Checking sources for other possible restartability bugs as in JENKINS-26149.
            RetryStep looks suspicious but apparently works.
            PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137.
            Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/0aec9ed07c5fe959d08b5355c9353108143f1d58 Log: Checking sources for other possible restartability bugs as in JENKINS-26149 . RetryStep looks suspicious but apparently works. PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137 . Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-scm-step-plugin/7583bf18eda2968bebc10024b52aee00a3614149 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/f383df6b4df20d790df09123489c63f55d048896
            Log:
            Checking sources for other possible restartability bugs as in JENKINS-26149.
            RetryStep looks suspicious but apparently works.
            PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137.
            Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java http://jenkins-ci.org/commit/workflow-cps-plugin/f383df6b4df20d790df09123489c63f55d048896 Log: Checking sources for other possible restartability bugs as in JENKINS-26149 . RetryStep looks suspicious but apparently works. PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137 . Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/89c28b4fca0eb81cf369ff699f7a4d801fc83e83 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/963cfbe1131efe28165d45b6da566b0271c684a2
            Log:
            Merge pull request #33 from jenkinsci/JENKINS-26137-no-pickle-factories

            Make a test involving Jenkins restart pass
            Originally-Committed-As: 9186a512e4ecf901217bc3f4b219810322e84db9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/963cfbe1131efe28165d45b6da566b0271c684a2 Log: Merge pull request #33 from jenkinsci/ JENKINS-26137 -no-pickle-factories Make a test involving Jenkins restart pass Originally-Committed-As: 9186a512e4ecf901217bc3f4b219810322e84db9
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/e2f865e9f5ad0ade62076df4ca51da245183cfc5
            Log:
            Checking sources for other possible restartability bugs as in JENKINS-26149.
            RetryStep looks suspicious but apparently works.
            PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137.
            Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/e2f865e9f5ad0ade62076df4ca51da245183cfc5 Log: Checking sources for other possible restartability bugs as in JENKINS-26149 . RetryStep looks suspicious but apparently works. PushdStep cannot be tested due to a mysterious error noted in JENKINS-26137 . Originally-Committed-As: cc76ee2256279676b4858cae95244585feceebaa
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641
            Log:
            JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed.
            Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass (JENKINS-26051).
            Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not.
            Also need to wait for the build to finish (JENKINS-26399).
            Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/PushdStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/fe863c4a5ba855d65cd68588a71e5293f0bdf641 Log: JENKINS-26137 At least during restarting tests, serialization errors seem to be due to there being no PickleFactory’s installed. Merely calling PickleFactory.all() from the RiverWriter constructor, rather than later, seems to let PushdStepTest.restarting pass ( JENKINS-26051 ). Additionally asserting that there are in fact some factories loaded, since there is sure to be trouble if there are not. Also need to wait for the build to finish ( JENKINS-26399 ). Originally-Committed-As: 3d3fa348ed9c34e4492b2733802bc47416824e30
            Hide
            jglick Jesse Glick added a comment -

            Can still observe some random test failures such as

                restartDuringDelay(org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest)  Time elapsed: 6.845 sec  <<< FAILURE!
                java.lang.AssertionError: 
                Started
                [Pipeline] waitUntil
                [Pipeline] {
                [Pipeline] semaphore
                [Pipeline] }
                Will try again after 0.25 sec
                [Pipeline] {
                [Pipeline] semaphore
                [Pipeline] }
                Will try again after 29,247,120 yr
                Resuming build
                [Pipeline] {
                [Pipeline] }
                [Pipeline] // waitUntil
                [Pipeline] End of Pipeline
                java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down
                	at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:92)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:431)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:412)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:357)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$100(CpsThreadGroup.java:78)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:236)
                	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:224)
                	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:63)
                	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
                	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
                	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
                	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
                	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
                	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
                	at java.lang.Thread.run(Thread.java:745)
                Finished: FAILURE
                
                	at org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep.waitForStart(SemaphoreStep.java:144)
                	at org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest$7.evaluate(WaitForConditionStepTest.java:169)
            

            despite running with this precheck from JENKINS-32015, suggesting that some Jenkins.instance is set yet extensions are not loaded.

            If this happens during shutdown, then keeping a WeakHashMap<FlowExecutionOwner,List<PickleFactory>> cache would suffice as a workaround. If during startup, then it would not; that would suggest that flow resumption is happening too early. Hard to tell which, since the failure is not reproducible.

            At least the precheck should be modified to directly check PickleFactory.all().isEmpty().

            Show
            jglick Jesse Glick added a comment - Can still observe some random test failures such as restartDuringDelay(org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest) Time elapsed: 6.845 sec <<< FAILURE! java.lang.AssertionError: Started [Pipeline] waitUntil [Pipeline] { [Pipeline] semaphore [Pipeline] } Will try again after 0.25 sec [Pipeline] { [Pipeline] semaphore [Pipeline] } Will try again after 29,247,120 yr Resuming build [Pipeline] { [Pipeline] } [Pipeline] // waitUntil [Pipeline] End of Pipeline java.lang.IllegalStateException: JENKINS-26137: Jenkins is shutting down at org.jenkinsci.plugins.workflow.support.pickles.serialization.RiverWriter.<init>(RiverWriter.java:92) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:431) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.saveProgram(CpsThreadGroup.java:412) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:357) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$100(CpsThreadGroup.java:78) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:236) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:224) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:63) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Finished: FAILURE at org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep.waitForStart(SemaphoreStep.java:144) at org.jenkinsci.plugins.workflow.steps.WaitForConditionStepTest$7.evaluate(WaitForConditionStepTest.java:169) despite running with this precheck from JENKINS-32015 , suggesting that some Jenkins.instance is set yet extensions are not loaded. If this happens during shutdown, then keeping a WeakHashMap<FlowExecutionOwner,List<PickleFactory>> cache would suffice as a workaround. If during startup, then it would not; that would suggest that flow resumption is happening too early. Hard to tell which, since the failure is not reproducible. At least the precheck should be modified to directly check PickleFactory.all().isEmpty() .
            Hide
            pyrocks Mor L added a comment - - edited

            Hi,

            I'm facing the same issue as this comment https://issues.jenkins-ci.org/browse/JENKINS-26137?focusedCommentId=251415&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-251415

            Is there a workaround?

            Update: Found a workaround.
            You need to take whatever you need from the xml and store in strings/lists etc. and before doing anything else set the variable used to parse the xml to null

            node {
                ...
               def pomXml = readFile('pom.xml')
            
               bat "echo before XmlSlurper().parseText()"
            
               def parsedPomXml = new XmlSlurper().parseText(pomXml)
               
               //do whatever you need with parsedPomXml
            
               //when done - set it to null
               parsedPomXml = null
               
               //now this should work (the same goes for calling emailext which is where I faced the issue)
               bat "echo after XmlSlurper().parseText()"
            }
            

            Thanks,
            Mor

            Show
            pyrocks Mor L added a comment - - edited Hi, I'm facing the same issue as this comment https://issues.jenkins-ci.org/browse/JENKINS-26137?focusedCommentId=251415&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-251415 Is there a workaround? Update : Found a workaround. You need to take whatever you need from the xml and store in strings/lists etc. and before doing anything else set the variable used to parse the xml to null node { ... def pomXml = readFile( 'pom.xml' ) bat "echo before XmlSlurper().parseText()" def parsedPomXml = new XmlSlurper().parseText(pomXml) // do whatever you need with parsedPomXml //when done - set it to null parsedPomXml = null //now this should work (the same goes for calling emailext which is where I faced the issue) bat "echo after XmlSlurper().parseText()" } Thanks, Mor
            Hide
            jglick Jesse Glick added a comment -

            As noted here any usage of non-Serializable values must be encapsulated in a @NonCPS method.

            Show
            jglick Jesse Glick added a comment - As noted here any usage of non- Serializable values must be encapsulated in a @NonCPS method.
            Hide
            pyrocks Mor L added a comment -

            I know about that, I actually only parse the xml on the main method to avoid having to do that multiple times and do all the access in a @NonCPS method, I guess that's not enough?
            How would you suggest to use xmlSlurper given I need to parse it once but access it many times and not hit the non serialializable error?

            Show
            pyrocks Mor L added a comment - I know about that, I actually only parse the xml on the main method to avoid having to do that multiple times and do all the access in a @NonCPS method, I guess that's not enough? How would you suggest to use xmlSlurper given I need to parse it once but access it many times and not hit the non serialializable error?
            Hide
            jglick Jesse Glick added a comment -

            You would need to use some other data structure.

            Show
            jglick Jesse Glick added a comment - You would need to use some other data structure.
            Hide
            jglick Jesse Glick added a comment -

            I think the main issue here could be resolved if the field lines in the stack trace specified the class name too.

            There is also an issue that RiverWriter can apparently be missing the list of pickles under some conditions TBD, which is something I can take care of.

            Show
            jglick Jesse Glick added a comment - I think the main issue here could be resolved if the field lines in the stack trace specified the class name too. There is also an issue that RiverWriter can apparently be missing the list of pickles under some conditions TBD, which is something I can take care of.
            Hide
            jglick Jesse Glick added a comment -

            Filed workflow-basic-steps PR 39 (and its upstream PRs) attempting to troubleshoot the recurrent exception from RiverWriter.

            Show
            jglick Jesse Glick added a comment - Filed workflow-basic-steps PR 39 (and its upstream PRs) attempting to troubleshoot the recurrent exception from RiverWriter .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-support-plugin/b4c0da271dbff56b46eb0603bbcf4be174db25f4
            Log:
            JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/b4c0da271dbff56b46eb0603bbcf4be174db25f4 Log: JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java
            http://jenkins-ci.org/commit/workflow-support-plugin/a3389777f39dcbae5c7758980f1c6a0d02b65c62
            Log:
            Merge pull request #35 from jglick/no-PickleFactory-JENKINS-26137

            JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor

            Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/467dd0dca178...a3389777f39d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriter.java http://jenkins-ci.org/commit/workflow-support-plugin/a3389777f39dcbae5c7758980f1c6a0d02b65c62 Log: Merge pull request #35 from jglick/no-PickleFactory- JENKINS-26137 JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor Compare: https://github.com/jenkinsci/workflow-support-plugin/compare/467dd0dca178...a3389777f39d
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/6012a8232a2214bc7f42be528461154d82bac486
            Log:
            JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java http://jenkins-ci.org/commit/workflow-cps-plugin/6012a8232a2214bc7f42be528461154d82bac486 Log: JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/92019ea288775c5d2e357f701472b52e40a7cc99
            Log:
            Merge pull request #117 from jglick/no-PickleFactory-JENKINS-26137

            JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/c2de116720e0...92019ea28877

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java http://jenkins-ci.org/commit/workflow-cps-plugin/92019ea288775c5d2e357f701472b52e40a7cc99 Log: Merge pull request #117 from jglick/no-PickleFactory- JENKINS-26137 JENKINS-26137 Pass pickleFactories directly into the RiverWriter constructor Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/c2de116720e0...92019ea28877
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/0bc7e9e9aee673c441a701c01a4ddc3cc95c4451
            Log:
            JENKINS-26137 Picking up possible fix for integration testing.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml http://jenkins-ci.org/commit/workflow-basic-steps-plugin/0bc7e9e9aee673c441a701c01a4ddc3cc95c4451 Log: JENKINS-26137 Picking up possible fix for integration testing.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/b3c2bbb807e0a2ad32560a7f6a1d49c7f3ccd59c
            Log:
            Merge pull request #39 from jglick/no-PickleFactory-JENKINS-26137

            JENKINS-26137 Picking up possible fix for integration testing

            Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/a3978f99059a...b3c2bbb807e0

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml http://jenkins-ci.org/commit/workflow-basic-steps-plugin/b3c2bbb807e0a2ad32560a7f6a1d49c7f3ccd59c Log: Merge pull request #39 from jglick/no-PickleFactory- JENKINS-26137 JENKINS-26137 Picking up possible fix for integration testing Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/a3978f99059a...b3c2bbb807e0
            Hide
            jglick Jesse Glick added a comment -

            Seems like jboss-marshalling PR 37 is intended to address this.

            Show
            jglick Jesse Glick added a comment - Seems like jboss-marshalling PR 37 is intended to address this.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/test/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriterTest.java
            http://jenkins-ci.org/commit/workflow-support-plugin/71c8e118dba6361659ddfed0c0caf2274d8bc927
            Log:
            [FIXED JENKINS-26137] Integrate a patched version of JBoss Marshalling with better diagnostics.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/support/pickles/serialization/RiverWriterTest.java http://jenkins-ci.org/commit/workflow-support-plugin/71c8e118dba6361659ddfed0c0caf2274d8bc927 Log: [FIXED JENKINS-26137] Integrate a patched version of JBoss Marshalling with better diagnostics.
            Hide
            svanoort Sam Van Oort added a comment -

            Released with v2.15

            Show
            svanoort Sam Van Oort added a comment - Released with v2.15

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: