Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26148

Incorrect implementation of RetryStepExecution.stop

    Details

    • Similar Issues:

      Description

      https://github.com/jenkinsci/workflow-plugin/commit/6be3d810597079905b6d19911bd40139ee4ec0eb purported to let stop kill its body. Yet this implementation can only work for the first round. For the second and subsequent rounds, the BodyExecution created by Callback.onFailure is thrown away, and body will still be the first one, which will presumably cause CpsBodyExecution.cancel to be a no-op since isDone().

      So somehow the Callback needs to get a handle back to its RetryStepExecution. But how? You could use StepExecution.applyAll to find all the candidates, but how would you select the right one if there are several? ExecutorStepExecution.Callback overloads cookie for this purpose, but that is used also for ProcessKiller; it seems like a hack here. ParallelStep uses ResultHandler, apparently assuming that identical objects are linked in the reference graph during serialization.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-25570 [ JENKINS-25570 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-26131 [ JENKINS-26131 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-26163 [ JENKINS-26163 ]
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-25550 [ JENKINS-25550 ]
            jglick Jesse Glick made changes -
            Assignee Kohsuke Kawaguchi [ kohsuke ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160138 ] JNJira + In-Review [ 180269 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Component/s workflow-basic-steps-plugin [ 21712 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-34637 [ JENKINS-34637 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-step-api PR 30 (Web Link)" [ 17620 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-support PR 44 (Web Link)" [ 17621 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-basic-steps PR 50 (Web Link)" [ 17622 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-durable-task-step PR 49 (Web Link)" [ 17623 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-cps PR 171 (Web Link)" [ 17624 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "pipeline-build-step PR 15 (Web Link)" [ 17625 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "pipeline-stage-step PR 12 (Web Link)" [ 17626 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "pipeline-model-definition PR 191 (Web Link)" [ 17627 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-step-api PR 37 (Web Link)" [ 20782 ]
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-50597 [ JENKINS-50597 ]
            svanoort Sam Van Oort made changes -
            Status In Review [ 10005 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: