Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26264

NPE from SubversionSCM.checkout

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Reported in JENKINS-26157 but this is a bug in the Subversion plugin. After a SVNCancelException (failure to check out) from UpdateUpdater$TaskImpl.perform, null is returned, in violation of the documented contract of UpdateTask.perform. Eventually this gets passed up to checkout, which tries to add that to externals and fails.

      perform should either return an empty list, or more likely just throw something appropriate such as AbortException. Was broken a couple years ago: https://github.com/jenkinsci/subversion-plugin/commit/7155ad9

        Attachments

          Issue Links

            Activity

            Hide
            flippy Repkov Denis added a comment -

            Pull request created, issue should be corrected now.

            Show
            flippy Repkov Denis added a comment - Pull request created, issue should be corrected now.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tastatur
            Path:
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/e5ef8931a8fd435ca09370f6c01155f2b630cb16
            Log:
            [FIXED JENKINS-26264] UpdateUpdater perform will throw an AbortException instead of returning null

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tastatur Path: src/main/java/hudson/scm/subversion/UpdateUpdater.java http://jenkins-ci.org/commit/subversion-plugin/e5ef8931a8fd435ca09370f6c01155f2b630cb16 Log: [FIXED JENKINS-26264] UpdateUpdater perform will throw an AbortException instead of returning null
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Steven Christou
            Path:
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/205ef51753008e84c96f32e36005b1c79c5f3c8f
            Log:
            Merge pull request #106 from tastatur/master

            [FIXED JENKINS-26264] UpdateUpdater perform will throw an AbortException

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/a20e0479e2bd...205ef5175300

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Christou Path: src/main/java/hudson/scm/subversion/UpdateUpdater.java http://jenkins-ci.org/commit/subversion-plugin/205ef51753008e84c96f32e36005b1c79c5f3c8f Log: Merge pull request #106 from tastatur/master [FIXED JENKINS-26264] UpdateUpdater perform will throw an AbortException Compare: https://github.com/jenkinsci/subversion-plugin/compare/a20e0479e2bd...205ef5175300
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: christ66
            Path:
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/8accb79bb3935fc2aa5b19c8d1383f58915c4122
            Log:
            JENKINS-26264 Cleanup AbortException call.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: christ66 Path: src/main/java/hudson/scm/subversion/UpdateUpdater.java http://jenkins-ci.org/commit/subversion-plugin/8accb79bb3935fc2aa5b19c8d1383f58915c4122 Log: JENKINS-26264 Cleanup AbortException call.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Manuel Recena
            Path:
            src/main/java/hudson/scm/subversion/UpdateUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/0b4aee608a84bf924f6fbb9cf5bf1d29e918347e
            Log:
            Merge pull request #107 from christ66/JENKINS-26264

            JENKINS-26264 Cleanup AbortException call.

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/606d95849828...0b4aee608a84

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/scm/subversion/UpdateUpdater.java http://jenkins-ci.org/commit/subversion-plugin/0b4aee608a84bf924f6fbb9cf5bf1d29e918347e Log: Merge pull request #107 from christ66/ JENKINS-26264 JENKINS-26264 Cleanup AbortException call. Compare: https://github.com/jenkinsci/subversion-plugin/compare/606d95849828...0b4aee608a84

              People

              • Assignee:
                flippy Repkov Denis
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: