Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26293

email-ext-plugin FILE token macro apostrophe escaping

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: email-ext-plugin
    • Labels:
    • Environment:
      Email Extension Plugin 2.39, Token Macro 1.10, Jenkins 1.580.2. Windows Server 2012
    • Similar Issues:

      Description

      I have a job that sends an HTML e-mail with the email-ext-plugin.

      The content is configured as such :
      ${FILE, path="MyFile.html"}

      Where MyFile.html is generated from a Python script.

      There is an apostrophe in the content of the file. Before the latest update to email-ext-plugin it was displayed "'". Now it is displayed "'" in the email client (tested on OWA and Outlook).

      The change seems to be related to this line : https://github.com/jenkinsci/email-ext-plugin/blob/master/src/main/java/hudson/plugins/emailext/plugins/CssInliner.java#L78
      The added .escapeMode(Entities.EscapeMode.xhtml)) changes the apostrophe to it's ampersand escaped version.

      There is probably a good reason why this line was modified in the first place, but I wonder if there would be a way to make it work on my end. Maybe make the escaping mode configurable?

      Thank you

        Attachments

          Issue Links

            Activity

            dblanchette Denis Blanchette created issue -
            slide_o_mix Alex Earl made changes -
            Field Original Value New Value
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            slide_o_mix Alex Earl made changes -
            Link This issue is duplicated by JENKINS-27004 [ JENKINS-27004 ]
            slide_o_mix Alex Earl made changes -
            Link This issue is duplicated by JENKINS-27147 [ JENKINS-27147 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 160354 ] JNJira + In-Review [ 196396 ]

              People

              • Assignee:
                slide_o_mix Alex Earl
                Reporter:
                dblanchette Denis Blanchette
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: