Details

    • Similar Issues:

      Description

      The line numbers plugin doesn't seem to work at all, at least in my setting:

      • the line number that is shown is always "1"
      • in some cases, it shows several "1"s
      • when clicking the label "builstep.1", something seems to be collapsed. However, it is completely unclear what is collapsed.

      As of yet, the plugin seems to be completely unusable. Attached, find a screenshot of the problem.

        Attachments

          Activity

          Hide
          vlatombe Vincent Latombe added a comment - - edited

          What browser do you use? The numbering relies on css features that may not be implemented the same way in all browsers... Another possibility is that some recent change in the core changed the generated markup, breaking the plugin altogether.

          Show
          vlatombe Vincent Latombe added a comment - - edited What browser do you use? The numbering relies on css features that may not be implemented the same way in all browsers... Another possibility is that some recent change in the core changed the generated markup, breaking the plugin altogether.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vincent LATOMBE
          Path:
          src/main/resources/org/jenkinsci/plugins/linenumbers/LineNumbersAnnotatorFactory/style.css
          http://jenkins-ci.org/commit/linenumbers-plugin/a0aa00e3cd91cb35a3c9379e05f6d468e18eefa2
          Log:
          [FIXED JENKINS-26322] Widen css selector for compatibility with new layout

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent LATOMBE Path: src/main/resources/org/jenkinsci/plugins/linenumbers/LineNumbersAnnotatorFactory/style.css http://jenkins-ci.org/commit/linenumbers-plugin/a0aa00e3cd91cb35a3c9379e05f6d468e18eefa2 Log: [FIXED JENKINS-26322] Widen css selector for compatibility with new layout
          Hide
          vlatombe Vincent Latombe added a comment -

          Indeed, the recent layout changed broke the css, I pushed a fix and released 1.1.

          Show
          vlatombe Vincent Latombe added a comment - Indeed, the recent layout changed broke the css, I pushed a fix and released 1.1.
          Hide
          olenz Olaf Lenz added a comment -

          Cool! I will test it now.

          Show
          olenz Olaf Lenz added a comment - Cool! I will test it now.
          Hide
          olenz Olaf Lenz added a comment - - edited

          The problem seems to be pretty complex.

          With your fix, I have seen it work in some circumstances.

          • First of all, I'm using Google chrome. With that it now seems to work partly. With IE, that I used for test purposes, it doesn't show any line numbers, only the labels.
          • When a log contains empty lines, the line numbers are shown on a single line.
          • When the console log is long, a number of problems occurs:
            • Computing the line numbers takes very long (and sometimes it even seems to kill the browser).
            • When only a part of the log is shown (because it is too long to be displayed at once), no line numbers are shown at all.
          Show
          olenz Olaf Lenz added a comment - - edited The problem seems to be pretty complex. With your fix, I have seen it work in some circumstances. First of all, I'm using Google chrome. With that it now seems to work partly. With IE, that I used for test purposes, it doesn't show any line numbers, only the labels. When a log contains empty lines, the line numbers are shown on a single line. When the console log is long, a number of problems occurs: Computing the line numbers takes very long (and sometimes it even seems to kill the browser). When only a part of the log is shown (because it is too long to be displayed at once), no line numbers are shown at all.

            People

            • Assignee:
              vlatombe Vincent Latombe
              Reporter:
              olenz Olaf Lenz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: