Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26363

Input step should permit cancellation from anyone with build abort permission

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Given I am Jenkins administrator when I create a job like the following:

      node {
        echo "test"
        input id: 'Edebd25a79a1ac52da788eba9a7fcc3a', message: 'hey!', ok: 'yo', submitter: 'foobar' parameters: []
      }
      

      ... I'm not able to answer the question it asks as I get an error saying "You need to be foobar to submit this" and I'm unable to stop/kill the job (it just doesn't work).

      Probably there should be special permission for admins to stop such jobs and/or the plugin should check if the submitter is a real person when saving/running the job.

      I'm using Jenkins ver. 1.596 and workflow plugin v1.1

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            I also noticed that while you get a proper error message from /job/…/…/input/ (You need to be … to submit this), from /job/…/…/console clicking Abort does nothing. It should print the error to the build log.

            Show
            jglick Jesse Glick added a comment - I also noticed that while you get a proper error message from /job/…/…/input/ ( You need to be … to submit this ), from /job/…/…/console clicking Abort does nothing. It should print the error to the build log.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/85c610870b3611c81c20d46de73670f0ab39a7be
            Log:
            [FIXED JENKINS-26363 Input step should permit cancellation from anyone with Job.CANCEL permission]

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/85c610870b3611c81c20d46de73670f0ab39a7be Log: [FIXED JENKINS-26363 Input step should permit cancellation from anyone with Job.CANCEL permission]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/eaa8f80a6398c76d6f62cfe43699322abd51961c
            Log:
            Merge pull request #70 from tfennelly/JENKINS-26363

            [FIXED JENKINS-26363] Input step should permit cancellation from anyone with Job.CANCEL permission

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/729984d402eb...eaa8f80a6398

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStep.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/eaa8f80a6398c76d6f62cfe43699322abd51961c Log: Merge pull request #70 from tfennelly/ JENKINS-26363 [FIXED JENKINS-26363] Input step should permit cancellation from anyone with Job.CANCEL permission Compare: https://github.com/jenkinsci/workflow-plugin/compare/729984d402eb...eaa8f80a6398
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            CHANGES.md
            http://jenkins-ci.org/commit/workflow-plugin/4a85acdaa89ad41f1e6f04984cc5481b959ef7f9
            Log:
            JENKINS-26363 Noting that #70 was merged.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md http://jenkins-ci.org/commit/workflow-plugin/4a85acdaa89ad41f1e6f04984cc5481b959ef7f9 Log: JENKINS-26363 Noting that #70 was merged.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java
            http://jenkins-ci.org/commit/pipeline-input-step-plugin/107feb436891a06c2c738171963b98fea3647883
            Log:
            [FIXED JENKINS-26363 Input step should permit cancellation from anyone with Job.CANCEL permission]

            Originally-Committed-As: 85c610870b3611c81c20d46de73670f0ab39a7be

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: aggregator/src/test/java/org/jenkinsci/plugins/workflow/steps/input/InputStepTest.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputStepExecution.java http://jenkins-ci.org/commit/pipeline-input-step-plugin/107feb436891a06c2c738171963b98fea3647883 Log: [FIXED JENKINS-26363 Input step should permit cancellation from anyone with Job.CANCEL permission] Originally-Committed-As: 85c610870b3611c81c20d46de73670f0ab39a7be

              People

              • Assignee:
                tfennelly Tom FENNELLY
                Reporter:
                erthad Timur Batyrshin
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: