Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26531

Slave does not start if the temp dir is not set to anything after upgrade to 1.25

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      After updating the plugin I can no longer provision EC2 machines.
      It connects with success but it fails with
      "Could not find /init.sh"
      I've fixed by reverting to previous version.

        Attachments

          Issue Links

            Activity

            Hide
            fonsecas72 hugo fonseca added a comment -

            Thank you @Francis and sorry the delay. Great job BTW.

            Show
            fonsecas72 hugo fonseca added a comment - Thank you @Francis and sorry the delay. Great job BTW.
            Hide
            pfalcon Paul Sokolovsky added a comment -

            > yes, it should probably handle the empty temp dir better

            +1 on that hunch.

            So, https://github.com/francisu/ec2-plugin/commit/716497f3df642a3e0df097ce05364213179bbb88 is a commit which introduce breakage. Specific line with the issue appers to be: https://github.com/francisu/ec2-plugin/commit/716497f3df642a3e0df097ce05364213179bbb88#diff-634d86776ce3255b6bbd6d5eacf0680aR105 , and the issue is that ".tmpDir != null" construct should be "fixEmpty(....tmpDir) != null" (possibly, fixEmptyAndTrim()).

            @Francis Upton : Please let everyone know if you're working on fixing this critical issue and on driving 1.26 release with the fix ASAP, or if you expect someone else to do that (or something else). Thanks.

            Show
            pfalcon Paul Sokolovsky added a comment - > yes, it should probably handle the empty temp dir better +1 on that hunch. So, https://github.com/francisu/ec2-plugin/commit/716497f3df642a3e0df097ce05364213179bbb88 is a commit which introduce breakage. Specific line with the issue appers to be: https://github.com/francisu/ec2-plugin/commit/716497f3df642a3e0df097ce05364213179bbb88#diff-634d86776ce3255b6bbd6d5eacf0680aR105 , and the issue is that ".tmpDir != null" construct should be "fixEmpty(....tmpDir) != null" (possibly, fixEmptyAndTrim()). @Francis Upton : Please let everyone know if you're working on fixing this critical issue and on driving 1.26 release with the fix ASAP, or if you expect someone else to do that (or something else). Thanks.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Francis Upton IV
            Path:
            src/main/java/hudson/plugins/ec2/ssh/EC2UnixLauncher.java
            http://jenkins-ci.org/commit/ec2-plugin/535704775e2505f29a98596884ce4b8ae7c8ee75
            Log:
            JENKINS-26531 Slave does not start if the temp dir is not set to
            anything after upgrade to 1.25

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/ssh/EC2UnixLauncher.java http://jenkins-ci.org/commit/ec2-plugin/535704775e2505f29a98596884ce4b8ae7c8ee75 Log: JENKINS-26531 Slave does not start if the temp dir is not set to anything after upgrade to 1.25
            Hide
            francisu Francis Upton added a comment -

            All done, version 1.26 released. Sorry for the trouble.

            Show
            francisu Francis Upton added a comment - All done, version 1.26 released. Sorry for the trouble.
            Hide
            pfalcon Paul Sokolovsky added a comment -

            Thumbs up, thanks for quick turnaround. Confirming that upgrading from 1.24 directly to 1.26 works as expected, without any additional actions.

            Show
            pfalcon Paul Sokolovsky added a comment - Thumbs up, thanks for quick turnaround. Confirming that upgrading from 1.24 directly to 1.26 works as expected, without any additional actions.

              People

              • Assignee:
                francisu Francis Upton
                Reporter:
                fonsecas72 hugo fonseca
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: