Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26558

createSlave Node name collision avoidance creates dead nodes

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: swarm-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.590 on Linux with Swarm Plugin 1.21
    • Similar Issues:

      Description

      In the swarm server-side slave creation logic, when a node of the provided name already exists, '-$IP' is appended to the end in an effort to end with a unique name (see https://github.com/jenkinsci/swarm-plugin/blob/master/plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java#L59)
      However, as far as I can tell, that new name is never provided to the slave, so it doesn't seem like it'd be possible for the slave to connect with that name, and in my experience I've seen hundreds of collision-avoidance nodes in this setup, and have never once seen one online or connected in any way.

      These dead "hyphen nodes" don't hurt running builds, but they are visual noise and false positives in our offline slave metrics, so it'd be nice if they could be avoided.

        Attachments

          Activity

          kylec Kyle C created issue -
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          mindjiver Peter J├Ânsson made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 160630 ] JNJira + In-Review [ 208365 ]
          oleg_nenashev Oleg Nenashev made changes -
          Assignee Kohsuke Kawaguchi [ kohsuke ]

            People

            • Assignee:
              Unassigned
              Reporter:
              kylec Kyle C
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: