Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26619

DescribableHelper does not handle GitSCMExtension

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: pipeline
    • Labels:
      None
    • Similar Issues:

      Description

      When these are configured in Snippet Generator, they are not properly rendered. Presumably this is because although the constructor parameter is typed simply as List<GitSCMExtension>, the getter (like the field) is declared with a somewhat exotic type: DescribableList<GitSCMExtension,GitSCMExtensionDescriptor>.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java
            http://jenkins-ci.org/commit/workflow-plugin/d438925a84bf0a16c50635a703526ddf26d6efd5
            Log:
            [FIXED JENKINS-26619] java.lang.Class#isAssignableFrom need to apply on expected type
            I always have to read javadoc twice to remember how to use it.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java http://jenkins-ci.org/commit/workflow-plugin/d438925a84bf0a16c50635a703526ddf26d6efd5 Log: [FIXED JENKINS-26619] java.lang.Class#isAssignableFrom need to apply on expected type I always have to read javadoc twice to remember how to use it.
            Hide
            jglick Jesse Glick added a comment -

            The fix for this problem includes logging that shows JENKINS-26143 more clearly. In that case this fix causes a call uncoerce(List<String>, String), which is actually correct; no such uncoercion is possible, so the method falls back to returning the list raw.

            Show
            jglick Jesse Glick added a comment - The fix for this problem includes logging that shows JENKINS-26143 more clearly. In that case this fix causes a call uncoerce(List<String>, String) , which is actually correct; no such uncoercion is possible, so the method falls back to returning the list raw.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            CHANGES.md
            step-api/pom.xml
            step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java
            step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java
            http://jenkins-ci.org/commit/workflow-plugin/70b91be52a1e4fddec00f7cf9a24dfc5e14ba58c
            Log:
            [FIXED JENKINS-26619] Prefer to consider the declared type of a @DataBoundConstructor parameter than its (non-)matching getter.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md step-api/pom.xml step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java http://jenkins-ci.org/commit/workflow-plugin/70b91be52a1e4fddec00f7cf9a24dfc5e14ba58c Log: [FIXED JENKINS-26619] Prefer to consider the declared type of a @DataBoundConstructor parameter than its (non-)matching getter.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            CHANGES.md
            step-api/pom.xml
            step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java
            step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java
            http://jenkins-ci.org/commit/workflow-plugin/0e956a5e3ae63054e9ede399dcc2a50b0ecec117
            Log:
            Merge pull request #74 from jglick/GitSCM.extensions-JENKINS-26619

            JENKINS-26619 GitSCM.extensions reflection fix

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/13f7b070e93d...0e956a5e3ae6

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: CHANGES.md step-api/pom.xml step-api/src/main/java/org/jenkinsci/plugins/workflow/structs/DescribableHelper.java step-api/src/test/java/org/jenkinsci/plugins/workflow/structs/DescribableHelperTest.java http://jenkins-ci.org/commit/workflow-plugin/0e956a5e3ae63054e9ede399dcc2a50b0ecec117 Log: Merge pull request #74 from jglick/GitSCM.extensions- JENKINS-26619 JENKINS-26619 GitSCM.extensions reflection fix Compare: https://github.com/jenkinsci/workflow-plugin/compare/13f7b070e93d...0e956a5e3ae6

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: