Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26828

Add support for installing the NodeJS windows msi

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: nodejs-plugin
    • Labels:
      None
    • Environment:
      Windows
    • Similar Issues:

      Description

      Currently the code has the following

      // At the moment, windows MSI installer are not handled !
      //} else if (platform == NodeJSInstaller.Platform.WINDOWS){

      A possible solution to automate installation is to use msiexec with following options:

      msiexec TARGETDIR=<install location> /a node-<version>-x86.msi /qn /l* log.txt

      this removes any UAC issues and just unpacks the files to TARGETDIR. also adds logging out to log.txt

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/jenkins/plugins/nodejs/tools/CPU.java
            src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
            src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
            src/main/java/jenkins/plugins/nodejs/tools/Platform.java
            src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
            src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
            src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
            http://jenkins-ci.org/commit/nodejs-plugin/d733226d24001498193064b0f009795092753aa4
            Log:
            JENKINS-26828 Add support for installing the NodeJS windows msi

            Remove unused old method.
            Update some old duplicate code from jenkins core code.
            Extend version with range capabilities to check which version has only an msi installer.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/d733226d24001498193064b0f009795092753aa4 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/jenkins/plugins/nodejs/tools/CPU.java
            src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
            src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
            src/main/java/jenkins/plugins/nodejs/tools/Platform.java
            src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
            src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
            src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
            http://jenkins-ci.org/commit/nodejs-plugin/95b8e220d2078e6e6ac2bcbd086d52d68f4539c9
            Log:
            JENKINS-26828 Add support for installing the NodeJS windows msi

            Remove unused old method.
            Update some old duplicate code from jenkins core code.
            Extend version with range capabilities to check which version has only an msi installer.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/95b8e220d2078e6e6ac2bcbd086d52d68f4539c9 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/jenkins/plugins/nodejs/tools/CPU.java
            src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
            src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
            src/main/java/jenkins/plugins/nodejs/tools/Platform.java
            src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
            src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
            src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
            http://jenkins-ci.org/commit/nodejs-plugin/9038814957cff39ee5c66c4c170e18a6baa16be0
            Log:
            JENKINS-26828 Add support for installing the NodeJS windows msi

            Remove unused old method.
            Update some old duplicate code from jenkins core code.
            Extend version with range capabilities to check which version has only an msi installer.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/9038814957cff39ee5c66c4c170e18a6baa16be0 Log: JENKINS-26828 Add support for installing the NodeJS windows msi Remove unused old method. Update some old duplicate code from jenkins core code. Extend version with range capabilities to check which version has only an msi installer.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nikolas Falco
            Path:
            src/main/java/jenkins/plugins/nodejs/tools/CPU.java
            src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java
            src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java
            src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java
            src/main/java/jenkins/plugins/nodejs/tools/Platform.java
            src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java
            src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java
            src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json
            http://jenkins-ci.org/commit/nodejs-plugin/1db81e46778aa2e3e97bdbe2133603b4b338a977
            Log:
            [FIX JENKINS-26828]

            Compare: https://github.com/jenkinsci/nodejs-plugin/compare/d6772edc891b...1db81e46778a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/java/jenkins/plugins/nodejs/tools/CPU.java src/main/java/jenkins/plugins/nodejs/tools/DetectionFailedException.java src/main/java/jenkins/plugins/nodejs/tools/InstallerPathResolver.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersion.java src/main/java/jenkins/plugins/nodejs/tools/NodeJSVersionRange.java src/main/java/jenkins/plugins/nodejs/tools/Platform.java src/main/java/jenkins/plugins/nodejs/tools/pathresolvers/LatestInstallerPathResolver.java src/test/java/jenkins/plugins/nodejs/tools/InstallerPathResolversTest.java src/test/resources/updates/jenkins.plugins.nodejs.tools.NodeJSInstaller.json http://jenkins-ci.org/commit/nodejs-plugin/1db81e46778aa2e3e97bdbe2133603b4b338a977 Log: [FIX JENKINS-26828] Compare: https://github.com/jenkinsci/nodejs-plugin/compare/d6772edc891b...1db81e46778a
            Hide
            nfalco Nikolas Falco added a comment -

            Release 1.0 with windows support

            Show
            nfalco Nikolas Falco added a comment - Release 1.0 with windows support

              People

              • Assignee:
                nfalco Nikolas Falco
                Reporter:
                icoulter Iain Coulter
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: