Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26900

Hide flyweight master executor when ≥1 heavyweight executors running as subtasks

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: pipeline
    • Labels:
    • Similar Issues:

      Description

      If you have

      node {
        sh 'sleep 60'
      }
      

      it would be nice if the flyweight executor were hidden from the executor widget.

        Attachments

          Issue Links

            Activity

            Hide
            ykryshchuk Yuriy Kryshchuk added a comment -

            From the other side, if we have the flow idle on user input we still need to see that.

            Show
            ykryshchuk Yuriy Kryshchuk added a comment - From the other side, if we have the flow idle on user input we still need to see that.
            Hide
            jglick Jesse Glick added a comment -

            if we have the flow idle on user input we still need to see that

            Well you would always see at least one task for a running build in the executor widget, from which you can access the input page. (The build history widget shown on the flow’s index page is not affected either.) This is just intended to make simple one-slave flows show only one entry.

            Show
            jglick Jesse Glick added a comment - if we have the flow idle on user input we still need to see that Well you would always see at least one task for a running build in the executor widget, from which you can access the input page. (The build history widget shown on the flow’s index page is not affected either.) This is just intended to make simple one-slave flows show only one entry.
            Hide
            jglick Jesse Glick added a comment -

            Unfortunately it seems this needs a core API extension, since lib/hudson/executors.jelly does not offer a Queue.Executable a choice of whether it should display a table row, so it does not suffice for WorkflowRun/executorCell.jelly to be an empty <td/>.

            Show
            jglick Jesse Glick added a comment - Unfortunately it seems this needs a core API extension, since lib/hudson/executors.jelly does not offer a Queue.Executable a choice of whether it should display a table row, so it does not suffice for WorkflowRun/executorCell.jelly to be an empty <td/> .
            Hide
            jglick Jesse Glick added a comment -

            JENKINS-25938 also requires an extension to the Executable API.

            Show
            jglick Jesse Glick added a comment - JENKINS-25938 also requires an extension to the Executable API.
            Hide
            danielbeck Daniel Beck added a comment -

            Is it possible for the flyweight executor of Workflows to be on a non-master slave node different from whatever happens inside the workflow? If so, what happens when you take that node offline?

            Show
            danielbeck Daniel Beck added a comment - Is it possible for the flyweight executor of Workflows to be on a non-master slave node different from whatever happens inside the workflow? If so, what happens when you take that node offline?
            Hide
            jglick Jesse Glick added a comment -

            No, the flyweight executor is always on master.

            Really what I want is for this executor to appear iff the CPS VM thread is currently busy, which is closely related to JENKINS-22941.

            Show
            jglick Jesse Glick added a comment - No, the flyweight executor is always on master. Really what I want is for this executor to appear iff the CPS VM thread is currently busy, which is closely related to JENKINS-22941 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/jenkins/model/queue/AsynchronousExecution.java
            core/src/main/resources/lib/hudson/executors.jelly
            http://jenkins-ci.org/commit/jenkins/bb80340a92538cdc783a55a28d42bcacd46673f4
            Log:
            [FIXED JENKINS-26900] AsynchronousExecution.displayCell

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/model/queue/AsynchronousExecution.java core/src/main/resources/lib/hudson/executors.jelly http://jenkins-ci.org/commit/jenkins/bb80340a92538cdc783a55a28d42bcacd46673f4 Log: [FIXED JENKINS-26900] AsynchronousExecution.displayCell
            Hide
            jglick Jesse Glick added a comment -

            Got closed accidentally due to Kohsuke Kawaguchi doing a second-level PR from @jenkinsci, which confuses the JIRA link daemon.

            Show
            jglick Jesse Glick added a comment - Got closed accidentally due to Kohsuke Kawaguchi doing a second-level PR from @jenkinsci, which confuses the JIRA link daemon.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4029
            [FIXED JENKINS-26900] AsynchronousExecution.displayCell (Revision bb80340a92538cdc783a55a28d42bcacd46673f4)

            Result = SUCCESS
            jesse glick : bb80340a92538cdc783a55a28d42bcacd46673f4
            Files :

            • core/src/main/resources/lib/hudson/executors.jelly
            • core/src/main/java/jenkins/model/queue/AsynchronousExecution.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4029 [FIXED JENKINS-26900] AsynchronousExecution.displayCell (Revision bb80340a92538cdc783a55a28d42bcacd46673f4) Result = SUCCESS jesse glick : bb80340a92538cdc783a55a28d42bcacd46673f4 Files : core/src/main/resources/lib/hudson/executors.jelly core/src/main/java/jenkins/model/queue/AsynchronousExecution.java
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/46dc6850edb1d7ef52592794b15e69db7dfbed1a Log: Noting merges JENKINS-15355 JENKINS-21618 JENKINS-22941 JENKINS-25938 JENKINS-26391 JENKINS-26900 JENKINS-27476 JENKINS-27563 JENKINS-27564 JENKINS-27565 JENKINS-27566 Fixing link text for JENKINS-6167
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
            http://jenkins-ci.org/commit/workflow-plugin/2a1899d571c953a87b5b8ced945ef676f9728d69
            Log:
            JENKINS-26900 AsynchronousExecution.displayCell

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java support/src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java http://jenkins-ci.org/commit/workflow-plugin/2a1899d571c953a87b5b8ced945ef676f9728d69 Log: JENKINS-26900 AsynchronousExecution.displayCell
            Hide
            jglick Jesse Glick added a comment -

            Fixed in 1.8.

            Show
            jglick Jesse Glick added a comment - Fixed in 1.8.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/dc155c4c8c0bf3fcf2eb9d94b82a7cf4aefdd1d4
            Log:
            JENKINS-26900 AsynchronousExecution.displayCell
            Originally-Committed-As: 2a1899d571c953a87b5b8ced945ef676f9728d69

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: job/src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/dc155c4c8c0bf3fcf2eb9d94b82a7cf4aefdd1d4 Log: JENKINS-26900 AsynchronousExecution.displayCell Originally-Committed-As: 2a1899d571c953a87b5b8ced945ef676f9728d69

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: