Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27054

Radio buttons would be easier to click if associated text was part of a <label>

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: timestamper-plugin
    • Labels:
    • Environment:
      Jenkins installed from Fedora 21 package.
      Jenkins version: 1.590
      Timestamper plugin: 1.5.15
    • Similar Issues:

      Description

      When viewing console log of a job, the timestamper plugin adds three timestamp options:

      • System clock time
      • Elapsed time
      • None

      The text is not clickable, only the radio buttons can be used to make a choice.

      It would be nice if the text was associated with the radio button.

      The HTML comes from timestamper-plugin/src/main/resources/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory/usersettings.jelly

      <form>
      <input type="radio" name="timestamps" id="timestamper-systemTime">$

      {%System clock time}</input>
      <br/>
      <input type="radio" name="timestamps" id="timestamper-elapsedTime">${%Elapsed time}</input>
      <br/>
      <input type="radio" name="timestamps" id="timestamper-none">${%None}</input>
      </form>

      The <input> tag does not need a </input> tag. Embedding the <input> within a <label> will allow the text be associated with the radio button.

      Suggested code:

      <form>
      <label><input type="radio" name="timestamps" id="timestamper-systemTime">${%System clock time}

      </label>
      <br/>
      <label><input type="radio" name="timestamps" id="timestamper-elapsedTime">$

      {%Elapsed time}

      </label>
      <br/>
      <label><input type="radio" name="timestamps" id="timestamper-none">$

      {%None}

      </label>
      </form>

        Attachments

          Activity

            People

            • Assignee:
              stevengbrown Steven G Brown
              Reporter:
              pfee Paul Fee
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: