Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27094

WriteFileStep ignores encoding

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It defines an encoding property but fails to use it. Silly me.

        Attachments

          Issue Links

            Activity

            Hide
            pisu Grzegorz Pisarek added a comment -

            If would be nice if this was already implemented, as lack of encoding makes writing binary files a hassle.

            Show
            pisu Grzegorz Pisarek added a comment - If would be nice if this was already implemented, as lack of encoding makes writing binary files a hassle.
            Hide
            b2yq Pawel Mucha added a comment -

            I would like to vote for that fix, because I am using "writeFile" method to overwrite AssemblyInfo.cs on windows, to change version number of application on every build, and right now writeFile is putting into a file '?' sign into first line, and my project is failing during compilation

            Show
            b2yq Pawel Mucha added a comment - I would like to vote for that fix, because I am using "writeFile" method to overwrite AssemblyInfo.cs on windows, to change version number of application on every build, and right now writeFile is putting into a file '?' sign into first line, and my project is failing during compilation
            Hide
            jglick Jesse Glick added a comment -

            Rather than adding comments to the effect of “please implement this”, click on the Vote button (and/or offer a tested PR).

            Show
            jglick Jesse Glick added a comment - Rather than adding comments to the effect of “please implement this”, click on the Vote button (and/or offer a tested PR).
            Show
            danielbutler Daniel Butler added a comment - PR: https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/38
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/steps/WriteFileStep.java
            src/test/java/org/jenkinsci/plugins/workflow/steps/ReadWriteFileStepTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/37d4589bc6bbc4cabfc227ebcc8d383470a06942
            Log:
            Merge pull request #38 from dbut023/jenkins-27094-writefile-encoding

            JENKINS-27094 writeFile encoding parameter

            Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/b1b29f6d43dd...37d4589bc6bb

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/steps/WriteFileStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ReadWriteFileStepTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/37d4589bc6bbc4cabfc227ebcc8d383470a06942 Log: Merge pull request #38 from dbut023/jenkins-27094-writefile-encoding JENKINS-27094 writeFile encoding parameter Compare: https://github.com/jenkinsci/workflow-basic-steps-plugin/compare/b1b29f6d43dd...37d4589bc6bb
            Hide
            muf Michal Fuchs added a comment -

            It looks that in the implementation is missing exception for Base64 encoding. By the documentation such text should be decoded first and saved as binary.

            It would be fine to fix it. Thanks!

            Show
            muf Michal Fuchs added a comment - It looks that in the implementation is missing exception for Base64 encoding. By the documentation such text should be decoded first and saved as binary. It would be fine to fix it. Thanks!
            Hide
            jglick Jesse Glick added a comment -

            Michal Fuchs support for Base64-encoding would be a separate feature, not covered by this issue.

            Show
            jglick Jesse Glick added a comment - Michal Fuchs support for Base64-encoding would be a separate feature, not covered by this issue.

              People

              • Assignee:
                danielbutler Daniel Butler
                Reporter:
                jglick Jesse Glick
              • Votes:
                8 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: