Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27208

Make Log Parser Plugin compatible with Workflow

    Details

    • Similar Issues:

      Description

      • Highlighting lines of interest in workflow logs (errors, warnings, information)
      • Dividing the log into sections based on stages and parallel executions
      • Displaying a summary of number of errors , warnings and information lines within the workflow log and its sections.
      • Linking the summary of errors and warnings into the context of the full workflow log, making it easy to find a line of interest in the log
      • Showing a summary of errors and warnings on the build page

        Attachments

          Activity

          nharniman Nigel Harniman created issue -
          Hide
          jglick Jesse Glick added a comment -

          Basically making LogParserPublisher implement SimpleBuildStep.

          Show
          jglick Jesse Glick added a comment - Basically making LogParserPublisher implement SimpleBuildStep .
          recena Manuel Recena Soto made changes -
          Field Original Value New Value
          Assignee rgoren [ rgoren ] Manuel Jesús Recena Soto [ recena ]
          recena Manuel Recena Soto made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          recena Manuel Recena Soto made changes -
          Description highlighting lines of interest in workflow logs (errors, warnings, information)
          dividing the log into sections based on stages and parallel executions
          displaying a summary of number of errors , warnings and information lines within the workflow log and its sections.
          linking the summary of errors and warnings into the context of the full workflow log, making it easy to find a line of interest in the log
          showing a summary of errors and warnings on the build page
          * Highlighting lines of interest in workflow logs (errors, warnings, information)
          * Dividing the log into sections based on stages and parallel executions
          * Displaying a summary of number of errors , warnings and information lines within the workflow log and its sections.
          * Linking the summary of errors and warnings into the context of the full workflow log, making it easy to find a line of interest in the log
          * Showing a summary of errors and warnings on the build page
          recena Manuel Recena Soto made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          recena Manuel Recena Soto made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          recena Manuel Recena Soto added a comment - - edited

          A PR has been sent.

          Show
          recena Manuel Recena Soto added a comment - - edited A PR has been sent.
          recena Manuel Recena Soto made changes -
          Summary Add workflow compatibility to log-parser Make Log Parser Plugin compatible with Workflow
          Hide
          nharniman Nigel Harniman added a comment -

          Manuel Recena Soto What's the status of the PR?

          Show
          nharniman Nigel Harniman added a comment - Manuel Recena Soto What's the status of the PR?
          Hide
          recena Manuel Recena Soto added a comment -

          Nigel Harniman, I'm working on it in my limited spare time.

          Show
          recena Manuel Recena Soto added a comment - Nigel Harniman , I'm working on it in my limited spare time.
          Hide
          recena Manuel Recena Soto added a comment -

          Nigel Harniman The main source code modifications were done. I'm waiting the maintainer so that this PR can be merged.

          Show
          recena Manuel Recena Soto added a comment - Nigel Harniman The main source code modifications were done. I'm waiting the maintainer so that this PR can be merged.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          pom.xml
          src/main/java/hudson/plugins/logparser/LogParserAction.java
          src/main/java/hudson/plugins/logparser/LogParserParser.java
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          src/main/java/hudson/plugins/logparser/LogParserStatusComputer.java
          src/main/java/hudson/plugins/logparser/LogParserUtils.java
          http://jenkins-ci.org/commit/log-parser-plugin/7847264fcf1605a4f1405ec8f7d53969d9430772
          Log:
          JENKINS-27208 Initial source code modifications

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: pom.xml src/main/java/hudson/plugins/logparser/LogParserAction.java src/main/java/hudson/plugins/logparser/LogParserParser.java src/main/java/hudson/plugins/logparser/LogParserPublisher.java src/main/java/hudson/plugins/logparser/LogParserStatusComputer.java src/main/java/hudson/plugins/logparser/LogParserUtils.java http://jenkins-ci.org/commit/log-parser-plugin/7847264fcf1605a4f1405ec8f7d53969d9430772 Log: JENKINS-27208 Initial source code modifications
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          http://jenkins-ci.org/commit/log-parser-plugin/21247507ca6ddb85516272087d293cc6b7e7faf8
          Log:
          JENKINS-27208 DataBoundConstructor, DataBoundSetter

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/hudson/plugins/logparser/LogParserPublisher.java http://jenkins-ci.org/commit/log-parser-plugin/21247507ca6ddb85516272087d293cc6b7e7faf8 Log: JENKINS-27208 DataBoundConstructor, DataBoundSetter
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          src/main/resources/hudson/plugins/logparser/LogParserPublisher/config.jelly
          http://jenkins-ci.org/commit/log-parser-plugin/e59455cd109db00d8a6b4b3174b2ec3a77e86b9f
          Log:
          JENKINS-27208 Removed obsolete way to work

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/hudson/plugins/logparser/LogParserPublisher.java src/main/resources/hudson/plugins/logparser/LogParserPublisher/config.jelly http://jenkins-ci.org/commit/log-parser-plugin/e59455cd109db00d8a6b4b3174b2ec3a77e86b9f Log: JENKINS-27208 Removed obsolete way to work
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserParser.java
          src/main/java/hudson/plugins/logparser/LogParserUtils.java
          http://jenkins-ci.org/commit/log-parser-plugin/cc2c42ebcfa4b2bc9f5280b63a723803aec8b7dc
          Log:
          JENKINS-27208 InterruptedException is catched and relaunched as IOException

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/hudson/plugins/logparser/LogParserParser.java src/main/java/hudson/plugins/logparser/LogParserUtils.java http://jenkins-ci.org/commit/log-parser-plugin/cc2c42ebcfa4b2bc9f5280b63a723803aec8b7dc Log: JENKINS-27208 InterruptedException is catched and relaunched as IOException
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          pom.xml
          http://jenkins-ci.org/commit/log-parser-plugin/9f8e6b8c7cd494e0646455427fc9bbb6849e825e
          Log:
          JENKINS-27208 Updated Workflow dependency

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: pom.xml http://jenkins-ci.org/commit/log-parser-plugin/9f8e6b8c7cd494e0646455427fc9bbb6849e825e Log: JENKINS-27208 Updated Workflow dependency
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java
          src/test/resources/org/jenkinsci/plugins/logparser/maven-project1.zip
          http://jenkins-ci.org/commit/log-parser-plugin/95a68a050a5a3f7df392c0c98eea3edbe854c316
          Log:
          JENKINS-27208 Added a test specific for workflow compatibility

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/plugins/logparser/LogParserPublisher.java src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java src/test/resources/org/jenkinsci/plugins/logparser/maven-project1.zip http://jenkins-ci.org/commit/log-parser-plugin/95a68a050a5a3f7df392c0c98eea3edbe854c316 Log: JENKINS-27208 Added a test specific for workflow compatibility
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java
          http://jenkins-ci.org/commit/log-parser-plugin/87922996bfb1d7474bb4c1c5ac6e93ef46399855
          Log:
          JENKINS-27208 @amuniz's comments were addressed

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java http://jenkins-ci.org/commit/log-parser-plugin/87922996bfb1d7474bb4c1c5ac6e93ef46399855 Log: JENKINS-27208 @amuniz's comments were addressed
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          http://jenkins-ci.org/commit/log-parser-plugin/ebeb53e35ccf882d0761198992b24443c0bb0753
          Log:
          JENKINS-27208 Wrong indent

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml http://jenkins-ci.org/commit/log-parser-plugin/ebeb53e35ccf882d0761198992b24443c0bb0753 Log: JENKINS-27208 Wrong indent
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserParser.java
          http://jenkins-ci.org/commit/log-parser-plugin/b1a2956236c38edc5e4b4ec8c02dddaad2f0d35e
          Log:
          JENKINS-27208 Removed an unnecessary method

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/plugins/logparser/LogParserParser.java http://jenkins-ci.org/commit/log-parser-plugin/b1a2956236c38edc5e4b4ec8c02dddaad2f0d35e Log: JENKINS-27208 Removed an unnecessary method
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          http://jenkins-ci.org/commit/log-parser-plugin/4fcb6fb40efcb7694d4b4944b1941005cb863611
          Log:
          JENKINS-27208 A variable has been renamed to reduce the changes (diff)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: src/main/java/hudson/plugins/logparser/LogParserPublisher.java http://jenkins-ci.org/commit/log-parser-plugin/4fcb6fb40efcb7694d4b4944b1941005cb863611 Log: JENKINS-27208 A variable has been renamed to reduce the changes (diff)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Manuel Recena
          Path:
          pom.xml
          src/main/java/hudson/plugins/logparser/LogParserAction.java
          src/main/java/hudson/plugins/logparser/LogParserParser.java
          src/main/java/hudson/plugins/logparser/LogParserPublisher.java
          src/main/java/hudson/plugins/logparser/LogParserStatusComputer.java
          src/main/java/hudson/plugins/logparser/LogParserUtils.java
          src/main/resources/hudson/plugins/logparser/LogParserPublisher/config.jelly
          src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java
          src/test/resources/org/jenkinsci/plugins/logparser/maven-project1.zip
          http://jenkins-ci.org/commit/log-parser-plugin/7cce02101fab53f4ba7ce25c03c4a170f475e8ee
          Log:
          Merge pull request #10 from recena/JENKINS-27208

          JENKINS-27208 Compatible with Workflow

          Compare: https://github.com/jenkinsci/log-parser-plugin/compare/398c0efd775d...7cce02101fab

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: pom.xml src/main/java/hudson/plugins/logparser/LogParserAction.java src/main/java/hudson/plugins/logparser/LogParserParser.java src/main/java/hudson/plugins/logparser/LogParserPublisher.java src/main/java/hudson/plugins/logparser/LogParserStatusComputer.java src/main/java/hudson/plugins/logparser/LogParserUtils.java src/main/resources/hudson/plugins/logparser/LogParserPublisher/config.jelly src/test/java/org/jenkinsci/plugins/logparser/LogParserWorkflowTest.java src/test/resources/org/jenkinsci/plugins/logparser/maven-project1.zip http://jenkins-ci.org/commit/log-parser-plugin/7cce02101fab53f4ba7ce25c03c4a170f475e8ee Log: Merge pull request #10 from recena/ JENKINS-27208 JENKINS-27208 Compatible with Workflow Compare: https://github.com/jenkinsci/log-parser-plugin/compare/398c0efd775d...7cce02101fab
          recena Manuel Recena Soto made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Done [ 10000 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          COMPATIBILITY.md
          http://jenkins-ci.org/commit/workflow-plugin/750a2bddca1cf7814a8bbf1e773a4ade4b9b7db9
          Log:
          Merge pull request #224 from recena/master

          JENKINS-27208 Compatibility listing updated

          Compare: https://github.com/jenkinsci/workflow-plugin/compare/55e78e84aad5...750a2bddca1c

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/750a2bddca1cf7814a8bbf1e773a4ade4b9b7db9 Log: Merge pull request #224 from recena/master JENKINS-27208 Compatibility listing updated Compare: https://github.com/jenkinsci/workflow-plugin/compare/55e78e84aad5...750a2bddca1c
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 161408 ] JNJira + In-Review [ 196750 ]
          Hide
          ssbarnea Sorin Sbarnea added a comment -

          Sorry for re-opening this bug but adding support for the Workflow without documenting it on the plugin homepage seems like a good reasons to consider this feature not fully implemented.

          I would not mind editing the the https://wiki.jenkins-ci.org/display/JENKINS/Log+Parser+Plugin page and adding the information related to Workflow usage but I don't know yet which is this information.

          Once I have a simple pipeline code example I would add it to the wiki.

          Show
          ssbarnea Sorin Sbarnea added a comment - Sorry for re-opening this bug but adding support for the Workflow without documenting it on the plugin homepage seems like a good reasons to consider this feature not fully implemented. I would not mind editing the the https://wiki.jenkins-ci.org/display/JENKINS/Log+Parser+Plugin page and adding the information related to Workflow usage but I don't know yet which is this information. Once I have a simple pipeline code example I would add it to the wiki.
          ssbarnea Sorin Sbarnea made changes -
          Resolution Done [ 10000 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          manish_king Manish Patel added a comment -

          I agree with Sorin Sbarnea above.
          An example would help a great deal for beginners.

          Thanks in advance.

          Show
          manish_king Manish Patel added a comment - I agree with Sorin Sbarnea above. An example would help a great deal for beginners. Thanks in advance.
          abayer Andrew Bayer made changes -
          Labels workflow pipeline workflow
          abayer Andrew Bayer made changes -
          Labels pipeline workflow pipeline
          Hide
          xavier X O added a comment -

          Please, be nice and document how to use it with pipeline on the page of the plug-in.

          Thanks a lot.

          Show
          xavier X O added a comment - Please, be nice and document how to use it with pipeline on the page of the plug-in. Thanks a lot.
          Hide
          jglick Jesse Glick added a comment -

          Well LogParserPublisher was made into a SimpleBuildStep. Thus it should automatically appear as an option under step in your Pipeline Syntax page. No further documentation should be needed I suppose.

          Show
          jglick Jesse Glick added a comment - Well LogParserPublisher was made into a SimpleBuildStep . Thus it should automatically appear as an option under step in your Pipeline Syntax page. No further documentation should be needed I suppose.
          Hide
          smuller Stefan Müller added a comment - - edited

          There seems to be an error in the snippet generated for logParser in the Pipeline Syntax page. I generated the snippet

          logParser parsingRulesPath: 'D:\\Jenkins_Log_Parser_Files\\my_global_parse_rule', useProjectRule: false

          which gives me the error

          WorkflowScript: 73: Missing required parameter: "projectRulePath" @ line 73, column 13.
                         logParser parsingRulesPath: 'D:\\Jenkins_Log_Parser_Files\\my_global_parse_rule', useProjectRule: false
                         ^

          Adding

          , projectRulePath: ''

          to the end of the snippet fixes this error.

          In addition, why is the path in the logParser call instead of the name of the rule, as specified in a none-pipeline job or in the snippet generator itself? This will be hell for me if the drive location of the global log parser rule ever changes...

          Thanks.

          PS: I know it's a lot of work to keep this stuff up-to-date, but IMHO, further documentation is needed (not just for this plugin). E.g. there is an option showGraphs (https://jenkins.io/doc/pipeline/steps/log-parser/) with no explanation. I tried it, hoping it might give me maybe parsing on step level, and found no effect.

          Show
          smuller Stefan Müller added a comment - - edited There seems to be an error in the snippet generated for logParser in the Pipeline Syntax page. I generated the snippet logParser parsingRulesPath: 'D:\\Jenkins_Log_Parser_Files\\my_global_parse_rule' , useProjectRule: false which gives me the error WorkflowScript: 73: Missing required parameter: "projectRulePath" @ line 73, column 13. logParser parsingRulesPath: 'D:\\Jenkins_Log_Parser_Files\\my_global_parse_rule', useProjectRule: false ^ Adding , projectRulePath: '' to the end of the snippet fixes this error. In addition, why is the path in the logParser call instead of the name of the rule, as specified in a none-pipeline job or in the snippet generator itself? This will be hell for me if the drive location of the global log parser rule ever changes... Thanks. PS: I know it's a lot of work to keep this stuff up-to-date, but IMHO, further documentation is needed (not just for this plugin). E.g. there is an option showGraphs ( https://jenkins.io/doc/pipeline/steps/log-parser/ ) with no explanation. I tried it, hoping it might give me maybe parsing on step level, and found no effect.

            People

            • Assignee:
              recena Manuel Recena Soto
              Reporter:
              nharniman Nigel Harniman
            • Votes:
              5 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated: