[JENKINS-27375] Add options to enable / disable choice providers - Jenkins JIRA

Details

Type: New Feature
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: extensible-choice-parameter-plugin
Labels:
None
Environment:
extensible-choice-parameter-1.2.2

Similar Issues:

Show

Description

There're cases some choice providers security problems: ~~JENKINS-26721~~, ~~JENKINS-27374~~
Though those problems should be fixed in wach choice providers, it can be complicated and take much time to make a new release.

Providing system global options to enable / disable choice providers allow administrators workarounds to avoid those problems.

Attachments

Issue Links

is related to

JENKINS-26721 FilenameChoiceListProvider cause security problems

Closed

links to

PR-12

Activity

Ascending order - Click to sort in descending order

5 older comments

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-05-15 22:14

Code changed in jenkins
User: ikedam
Path:
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly
http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/f7e23a37c9b6c79731d34ebc27cbe45d47fc5b23
Log:
[FIXED JENKINS-27375] Enables to disable specific choice list providers in system configuration page.

Show

SCM/JIRA link daemon added a comment - 2015-05-15 22:14 Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/f7e23a37c9b6c79731d34ebc27cbe45d47fc5b23 Log: [FIXED JENKINS-27375] Enables to disable specific choice list providers in system configuration page.

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-05-15 22:15

Code changed in jenkins
User: ikedam
Path:
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/5b1ff211792f32fb59c21b58c3d3b00a09e13c52
Log:
~~JENKINS-27375~~ the nested configuration in enabled / disabled section is enabled only when inheriting ChoiceListProviderDescriptor.

Show

SCM/JIRA link daemon added a comment - 2015-05-15 22:15 Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/5b1ff211792f32fb59c21b58c3d3b00a09e13c52 Log: JENKINS-27375 the nested configuration in enabled / disabled section is enabled only when inheriting ChoiceListProviderDescriptor.

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-05-15 22:15

Code changed in jenkins
User: ikedam
Path:
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java
src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly
src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly
http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/74176e38f536a58ce32d03552885ccb7e434d43c
Log:
Merge pull request #12 from ikedam/feature/~~JENKINS-27375~~_DisableProviders

~~JENKINS-27375~~ Add options to enable / disable choice providers

Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/8c3df4246c76...74176e38f536

Show

SCM/JIRA link daemon added a comment - 2015-05-15 22:15 Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/74176e38f536a58ce32d03552885ccb7e434d43c Log: Merge pull request #12 from ikedam/feature/ JENKINS-27375 _DisableProviders JENKINS-27375 Add options to enable / disable choice providers Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/8c3df4246c76...74176e38f536

Hide

Permalink

SCM/JIRA link daemon added a comment - 2015-05-16 06:19

Code changed in jenkins
User: ikedam
Path:
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global_ja.properties
http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c6c822e1a715a57a911129702d8994913d2d0822
Log:
~~JENKINS-27375~~ More descriptions for the system configuration page.

Show

SCM/JIRA link daemon added a comment - 2015-05-16 06:19 Code changed in jenkins User: ikedam Path: src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global_ja.properties http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c6c822e1a715a57a911129702d8994913d2d0822 Log: JENKINS-27375 More descriptions for the system configuration page.

Hide

Permalink

ikedam added a comment - 2015-05-16 06:47

Fixed in 1.3.0.
It will be available in a day.

Show

ikedam added a comment - 2015-05-16 06:47 Fixed in 1.3.0. It will be available in a day.

Jenkins

Add options to enable / disable choice providers

Details

Description

Attachments

Issue Links

Activity

People

Dates