Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27529

Refactor ec2-plugin's Spot instance support to use spotinstancerequest polling

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: ec2-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      Due to a variety of problems with the current implementation i started to refactor the spot functionality to poll the spot instance request for the instanceid until its known.

      From that point on the Spot instance can be treated as a regular OnDemand instance.

      I am currently testing the functionality on our system but will create a pull request once its working for a while. (Please have a look at https://github.com/nexus49/ec2-plugin) in case you want to provide feedback.

      With this functionality it is not necessary to do any modification on the used ami specifically for spot support.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michael Barrientos
          Path:
          src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java
          src/main/java/hudson/plugins/ec2/EC2ComputerLauncher.java
          src/main/java/hudson/plugins/ec2/EC2SpotComputerLauncher.java
          src/main/java/hudson/plugins/ec2/EC2SpotRetentionStrategy.java
          src/main/java/hudson/plugins/ec2/EC2SpotSlave.java
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
          http://jenkins-ci.org/commit/ec2-plugin/ae7e53ab99028fd8ede1a3e41907812c2edb0eec
          Log:
          Poll for spot instances instead of JNLP launcher JENKINS-27529 JENKINS-19059

          • No more need for special spot startup script.
          • Changes spot slave name to use spot request ID (partially fixes JENKINS-32399)
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Barrientos Path: src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java src/main/java/hudson/plugins/ec2/EC2ComputerLauncher.java src/main/java/hudson/plugins/ec2/EC2SpotComputerLauncher.java src/main/java/hudson/plugins/ec2/EC2SpotRetentionStrategy.java src/main/java/hudson/plugins/ec2/EC2SpotSlave.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly http://jenkins-ci.org/commit/ec2-plugin/ae7e53ab99028fd8ede1a3e41907812c2edb0eec Log: Poll for spot instances instead of JNLP launcher JENKINS-27529 JENKINS-19059 No more need for special spot startup script. Changes spot slave name to use spot request ID (partially fixes JENKINS-32399 )
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Francis Upton IV
          Path:
          src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java
          src/main/java/hudson/plugins/ec2/EC2Cloud.java
          src/main/java/hudson/plugins/ec2/EC2ComputerLauncher.java
          src/main/java/hudson/plugins/ec2/EC2SpotComputerLauncher.java
          src/main/java/hudson/plugins/ec2/EC2SpotRetentionStrategy.java
          src/main/java/hudson/plugins/ec2/EC2SpotSlave.java
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
          http://jenkins-ci.org/commit/ec2-plugin/e3bfb31528faba3dd23bef940d1a4a8fa2a227c3
          Log:
          Merge pull request #179 from syapse/spot-ssh-rebase

          Poll for spot instances instead of JNLP launcher JENKINS-27529 JENKINS-19059

          Compare: https://github.com/jenkinsci/ec2-plugin/compare/cc23601d9702...e3bfb31528fa

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/EC2AbstractSlave.java src/main/java/hudson/plugins/ec2/EC2Cloud.java src/main/java/hudson/plugins/ec2/EC2ComputerLauncher.java src/main/java/hudson/plugins/ec2/EC2SpotComputerLauncher.java src/main/java/hudson/plugins/ec2/EC2SpotRetentionStrategy.java src/main/java/hudson/plugins/ec2/EC2SpotSlave.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly http://jenkins-ci.org/commit/ec2-plugin/e3bfb31528faba3dd23bef940d1a4a8fa2a227c3 Log: Merge pull request #179 from syapse/spot-ssh-rebase Poll for spot instances instead of JNLP launcher JENKINS-27529 JENKINS-19059 Compare: https://github.com/jenkinsci/ec2-plugin/compare/cc23601d9702...e3bfb31528fa

            People

            • Assignee:
              francisu Francis Upton
              Reporter:
              nexus49 Bastian Echterhoelter
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: