Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27939

DefaultJnlpSlaveReceiver should return true when rejecting a takeover.

    Details

    • Similar Issues:

      Description

      See https://github.com/jenkinsci/jenkins/pull/1649

      In summary: JnlpAgentReceiver is documented as returning true after calling handshake.error() in case of failure to indicate that the receiver DID claim this node but had issues, but DefaultJnlpSlaveReceiver returns false.

      https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java#L56-61 loops over all receivers until one claims it, so this is giving other receivers a chance at a node they shouldn't grab since the receiver wanted it but couldn't grab it.

      Assuming no others do, it also then continues on and gives the erroneous log message about not recognizing the node's name.

        Attachments

          Issue Links

            Activity

            deadmoose David Hoover created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Remote Link This issue links to "Jenkins PR#1649 (Web Link)" [ 12703 ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Status In Progress [ 3 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate 1.609.2-fixed
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 162537 ] JNJira + In-Review [ 196975 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                deadmoose David Hoover
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: