Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28062

Channel listener onClose propagated exceptions

    Details

    • Similar Issues:

      Description

      Channel listeners onClose method would propagate exceptions causing extra noise when failing to close the channel.

        Attachments

          Activity

          schristou Steven Christou created issue -
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/remoting/Channel.java
          http://jenkins-ci.org/commit/remoting/b60df6b39caa403f29845b86338579d1cf76b819
          Log:
          [FIXED JENKINS-28062] A Channel.Listener's onClose method that propagates an exception is a sign of a bad listener not a problem closing the channel.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/remoting/Channel.java http://jenkins-ci.org/commit/remoting/b60df6b39caa403f29845b86338579d1cf76b819 Log: [FIXED JENKINS-28062] A Channel.Listener's onClose method that propagates an exception is a sign of a bad listener not a problem closing the channel.
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          schristou Steven Christou made changes -
          Summary Channel listener onClose propogated exceptions Channel listener onClose propagated exceptions
          Description Channel.onClose Channel listeners onClose method would propagate exceptions causing extra noise when failing to close the channel.
          jglick Jesse Glick made changes -
          Labels diagnostics
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/remoting/Channel.java
          http://jenkins-ci.org/commit/remoting/846b3e0527aa1dc5629a2a7e870f4b7efb653cfb
          Log:
          Merge pull request #42 from jenkinsci/safe-listener-fire

          [FIXED JENKINS-28062] A Channel.Listener's onClose method that propagate...

          Compare: https://github.com/jenkinsci/remoting/compare/2b6a02192ca4...846b3e0527aa

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/remoting/Channel.java http://jenkins-ci.org/commit/remoting/846b3e0527aa1dc5629a2a7e870f4b7efb653cfb Log: Merge pull request #42 from jenkinsci/safe-listener-fire [FIXED JENKINS-28062] A Channel.Listener's onClose method that propagate... Compare: https://github.com/jenkinsci/remoting/compare/2b6a02192ca4...846b3e0527aa
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/d760216d1e3a927b971edf27c7af317a5de71e20
          Log:
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/d760216d1e3a927b971edf27c7af317a5de71e20 Log: [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/5e311a3dca6c725ab794dc35504bf0484a56be8f
          Log:
          Merge pull request #1669 from stephenc/jenkins-28062

          JENKINS-28062 Channel listener onClose propagated exceptions

          Compare: https://github.com/jenkinsci/jenkins/compare/3bf606178640...5e311a3dca6c

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/5e311a3dca6c725ab794dc35504bf0484a56be8f Log: Merge pull request #1669 from stephenc/jenkins-28062 JENKINS-28062 Channel listener onClose propagated exceptions Compare: https://github.com/jenkinsci/jenkins/compare/3bf606178640...5e311a3dca6c
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/6a138b59b4eee42f65d620730802d3a97a0f6c4a
          Log:
          Noting JENKINS-28062

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html http://jenkins-ci.org/commit/jenkins/6a138b59b4eee42f65d620730802d3a97a0f6c4a Log: Noting JENKINS-28062
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4106
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d760216d1e3a927b971edf27c7af317a5de71e20)
          Noting JENKINS-28062 (Revision 6a138b59b4eee42f65d620730802d3a97a0f6c4a)

          Result = SUCCESS
          stephen connolly : d760216d1e3a927b971edf27c7af317a5de71e20
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java

          stephen connolly : 6a138b59b4eee42f65d620730802d3a97a0f6c4a
          Files :

          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4106 [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d760216d1e3a927b971edf27c7af317a5de71e20) Noting JENKINS-28062 (Revision 6a138b59b4eee42f65d620730802d3a97a0f6c4a) Result = SUCCESS stephen connolly : d760216d1e3a927b971edf27c7af317a5de71e20 Files : core/src/main/java/hudson/slaves/SlaveComputer.java stephen connolly : 6a138b59b4eee42f65d620730802d3a97a0f6c4a Files : changelog.html
          stephenconnolly Stephen Connolly made changes -
          Labels diagnostics diagnostics lts-candidate
          olivergondza Oliver Gond┼ża made changes -
          Labels diagnostics lts-candidate 1.609.1-fixed diagnostics
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/slaves/SlaveComputer.java
          http://jenkins-ci.org/commit/jenkins/d42e8465fc2829bc7a926fe8d52d3bdfaabd857e
          Log:
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel.

          (cherry picked from commit d760216d1e3a927b971edf27c7af317a5de71e20)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/slaves/SlaveComputer.java http://jenkins-ci.org/commit/jenkins/d42e8465fc2829bc7a926fe8d52d3bdfaabd857e Log: [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (cherry picked from commit d760216d1e3a927b971edf27c7af317a5de71e20)
          Hide
          schristou Steven Christou added a comment -

          I do not think this can be 1.609.1-fixed, as it also requires remoting pull request 42 which hasn't been released yet.

          Show
          schristou Steven Christou added a comment - I do not think this can be 1.609.1-fixed, as it also requires remoting pull request 42 which hasn't been released yet.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d42e8465fc2829bc7a926fe8d52d3bdfaabd857e)

          Result = UNSTABLE
          ogondza : d42e8465fc2829bc7a926fe8d52d3bdfaabd857e
          Files :

          • core/src/main/java/hudson/slaves/SlaveComputer.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-28062] A Launcher.afterDisconnect() method that propagates an exception is a sign of a bad Launcher not a problem closing the channel. (Revision d42e8465fc2829bc7a926fe8d52d3bdfaabd857e) Result = UNSTABLE ogondza : d42e8465fc2829bc7a926fe8d52d3bdfaabd857e Files : core/src/main/java/hudson/slaves/SlaveComputer.java
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 162665 ] JNJira + In-Review [ 197024 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              schristou Steven Christou
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: