Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28132

Release button disappears after upgrading Release Plugin from 2.4.1 to 2.5.3

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: release-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.609
    • Similar Issues:

      Description

      We've isolated the problem to Release Plugin version. When downgraded to 2.4.1 "Release" button (the one to schedule new release) appears. Upgrading to 2.5.3 button disappears. Other release-related icons are still visible on past builds. Nothing obvious in the logs.

        Attachments

          Issue Links

            Activity

            ppaczyn Piotr Paczyński created issue -
            Hide
            nde Andreas Esterle added a comment -

            Same issue here:
            Jenkins 1.612:
            Upgrading "Release Plugin" from 2.4.1 to 2.5.3 the release buttons of all projekts disappears.
            Downgrading to 2.4.1, the release button appears again.

            Is this an issue related to insufficient permissions? At the release notes there is the entry "Define a new RELEASE permission", but where to grant this permission?

            Show
            nde Andreas Esterle added a comment - Same issue here: Jenkins 1.612: Upgrading "Release Plugin" from 2.4.1 to 2.5.3 the release buttons of all projekts disappears. Downgrading to 2.4.1, the release button appears again. Is this an issue related to insufficient permissions? At the release notes there is the entry "Define a new RELEASE permission", but where to grant this permission?
            Hide
            veresvit Vit Veres added a comment -

            You can set the new permission at the Jenkins -> Configure Global Security.

            Show
            veresvit Vit Veres added a comment - You can set the new permission at the Jenkins -> Configure Global Security.
            Hide
            veresvit Vit Veres added a comment - - edited

            Go to global settings and set the new permissions.
            Details at:
            https://issues.jenkins-ci.org/browse/JENKINS-28132

            Show
            veresvit Vit Veres added a comment - - edited Go to global settings and set the new permissions. Details at: https://issues.jenkins-ci.org/browse/JENKINS-28132
            veresvit Vit Veres made changes -
            Field Original Value New Value
            Status Open [ 1 ] Resolved [ 5 ]
            Assignee Peter Hayes [ petehayes ] Vit Veres [ veresvit ]
            Resolution Not A Defect [ 7 ]
            Hide
            nde Andreas Esterle added a comment -

            Thanks a lot for the fast reply and for a hint to work around the problem (and that's very importent )

            Thats the solution for people who have enabled "Matrix-based security", but for people who are working witch the option "Logged-in users can do anything" the "Release-Button" still disapears" if you are logged-in or not.

            The "work around" for "Anyone can do anything":

            • log-in with an existing user (this is very importend if you are switching from "Anyone can do anything")
            • enable "Matrix-based security"
            • create group "authenticated"
            • grant this group all rights
            • save changes
            Show
            nde Andreas Esterle added a comment - Thanks a lot for the fast reply and for a hint to work around the problem (and that's very importent ) Thats the solution for people who have enabled "Matrix-based security", but for people who are working witch the option "Logged-in users can do anything" the "Release-Button" still disapears" if you are logged-in or not. The "work around" for "Anyone can do anything": log-in with an existing user (this is very importend if you are switching from "Anyone can do anything") enable "Matrix-based security" create group "authenticated" grant this group all rights save changes
            Hide
            nde Andreas Esterle added a comment -

            After thinking about it several hours, I'm convinced that there is still a bug:

            If a jenkins installation use the "Anyone can do anything" or "Logged-in users can do anything" instead of "Matrix-based security" as "Authorization" the "release button" still disappears!

            Therefor I reopened this issue.

            Kind regards,
            Andreas

            Show
            nde Andreas Esterle added a comment - After thinking about it several hours, I'm convinced that there is still a bug: If a jenkins installation use the "Anyone can do anything" or "Logged-in users can do anything" instead of "Matrix-based security" as "Authorization" the "release button" still disappears ! Therefor I reopened this issue. Kind regards, Andreas
            nde Andreas Esterle made changes -
            Resolution Not A Defect [ 7 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            Assignee Vit Veres [ veresvit ]
            Hide
            stegriff Stephen Griffiths added a comment -

            I got stung by this bug today when I enabled Active Directory security, and wrote a blog post with the workaround

            It doesn't make sense that "Logged-in users can do anything" does not include "Release", and you should not have to switch to Matrix security to re-enable release!

            Show
            stegriff Stephen Griffiths added a comment - I got stung by this bug today when I enabled Active Directory security, and wrote a blog post with the workaround It doesn't make sense that "Logged-in users can do anything" does not include "Release", and you should not have to switch to Matrix security to re-enable release!
            Hide
            drrob Rob Platt added a comment - - edited

            In case it is helpful to others, I've confirmed Andreas' workaround for "logged-in users can do anything" via the matrix "authenticated" mechanism, on a system using jenkins builtin user database, on LTS 1.642.1.

            (I wasn't sure whether it was an LDAP group until I researched it – but "authenticated" is built into Jenkins specially)

            If the "authenticated" matrix feature is news to you as much as me, then you may wish to vote on JENKINS-30495

            Show
            drrob Rob Platt added a comment - - edited In case it is helpful to others, I've confirmed Andreas' workaround for "logged-in users can do anything" via the matrix "authenticated" mechanism, on a system using jenkins builtin user database, on LTS 1.642.1. (I wasn't sure whether it was an LDAP group until I researched it – but "authenticated" is built into Jenkins specially) If the "authenticated" matrix feature is news to you as much as me, then you may wish to vote on JENKINS-30495
            Hide
            andreasprueller Andreas Prueller added a comment -

            I just made a pull request fixing this bug. Problem was the introduction of the separate permission for matrix based security which did not take into account that some people do not use matrix based security.

            Show
            andreasprueller Andreas Prueller added a comment - I just made a pull request fixing this bug. Problem was the introduction of the separate permission for matrix based security which did not take into account that some people do not use matrix based security.
            andreasprueller Andreas Prueller made changes -
            Assignee Andreas Prueller [ andreasprueller ]
            Hide
            drb9764 David Barber added a comment -

            Release button is missing for 2.5.4 version as well so we had to downgrade to 2.4.1. We use project-based matrix authorization strategy so Matrix-based security is not an option for us.

            Show
            drb9764 David Barber added a comment - Release button is missing for 2.5.4 version as well so we had to downgrade to 2.4.1. We use project-based matrix authorization strategy so Matrix-based security is not an option for us.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 162846 ] JNJira + In-Review [ 186282 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: aprueller
            Path:
            src/main/java/hudson/plugins/release/ReleaseWrapper.java
            http://jenkins-ci.org/commit/release-plugin/bca86467ada50ed79d019c2ffe37d3749f058d39
            Log:
            [FIXED JENKINS-28132] add an impliedBy definition to release permission so it will be handled properly if no matrix-based security is used

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: aprueller Path: src/main/java/hudson/plugins/release/ReleaseWrapper.java http://jenkins-ci.org/commit/release-plugin/bca86467ada50ed79d019c2ffe37d3749f058d39 Log: [FIXED JENKINS-28132] add an impliedBy definition to release permission so it will be handled properly if no matrix-based security is used
            scm_issue_link SCM/JIRA link daemon made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/plugins/release/ReleaseWrapper.java
            http://jenkins-ci.org/commit/release-plugin/137c807e146c93168096f3f08e936c5d56d64cc3
            Log:
            Merge pull request #16 from aprueller/master

            [FIXED JENKINS-28132] add an impliedBy definition to permission

            Compare: https://github.com/jenkinsci/release-plugin/compare/a7c8573bd5fb...137c807e146c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/release/ReleaseWrapper.java http://jenkins-ci.org/commit/release-plugin/137c807e146c93168096f3f08e936c5d56d64cc3 Log: Merge pull request #16 from aprueller/master [FIXED JENKINS-28132] add an impliedBy definition to permission Compare: https://github.com/jenkinsci/release-plugin/compare/a7c8573bd5fb...137c807e146c
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been release in Release Plugin 2.6

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been release in Release Plugin 2.6
            benapgar Ben Apgar made changes -
            Link This issue relates to JENKINS-30381 [ JENKINS-30381 ]

              People

              • Assignee:
                andreasprueller Andreas Prueller
                Reporter:
                ppaczyn Piotr Paczyński
              • Votes:
                16 Vote for this issue
                Watchers:
                23 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: