Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28216

Obtaining slave log records blocks channel

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When obtaining slave log information in the support bundle it can cause the channel to block. Obtaining should be async callables, a timeout of a few seconds, or cap the size of logs.

        Attachments

          Activity

          Hide
          danielbeck Daniel Beck added a comment - - edited

          These are obtained periodically, not just when explicitly creating a support bundle, right?

          Given that Support Core provides no features to end users, just makes issue investigation easier, I'd consider this critical – Support Core simply must not break installations.

          Show
          danielbeck Daniel Beck added a comment - - edited These are obtained periodically, not just when explicitly creating a support bundle, right? Given that Support Core provides no features to end users, just makes issue investigation easier, I'd consider this critical – Support Core simply must not break installations.
          Hide
          aheritier Arnaud Héritier added a comment -

          agreed Daniel Beck Steven Christou I marked it as blocker. This plugin, more than all others should be safe for users

          Show
          aheritier Arnaud Héritier added a comment - agreed Daniel Beck Steven Christou I marked it as blocker. This plugin, more than all others should be safe for users
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: christ66
          Path:
          src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java
          http://jenkins-ci.org/commit/support-core-plugin/c8be911a314effc12b1067ddb20a4a373d81fa34
          Log:
          JENKINS-28216 Obtain slave logs using async callable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: christ66 Path: src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java http://jenkins-ci.org/commit/support-core-plugin/c8be911a314effc12b1067ddb20a4a373d81fa34 Log: JENKINS-28216 Obtain slave logs using async callable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Steven Christou
          Path:
          src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java
          http://jenkins-ci.org/commit/support-core-plugin/8305e7f850d19c070a8785ebd3a691937ecac8d1
          Log:
          Merge pull request #45 from christ66/JENKINS-28216

          JENKINS-28216 Obtain slave logs using async callable.

          Compare: https://github.com/jenkinsci/support-core-plugin/compare/456542746987...8305e7f850d1

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Christou Path: src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java http://jenkins-ci.org/commit/support-core-plugin/8305e7f850d19c070a8785ebd3a691937ecac8d1 Log: Merge pull request #45 from christ66/ JENKINS-28216 JENKINS-28216 Obtain slave logs using async callable. Compare: https://github.com/jenkinsci/support-core-plugin/compare/456542746987...8305e7f850d1
          Hide
          schristou Steven Christou added a comment -

          Fixed and will be made available in the next release.

          Show
          schristou Steven Christou added a comment - Fixed and will be made available in the next release.

            People

            • Assignee:
              schristou Steven Christou
              Reporter:
              schristou Steven Christou
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: