Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28289

JNLP slave should exclude non proxy hosts when connecting via HTTP proxy

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      https://issues.jenkins-ci.org/browse/JENKINS-6167
      The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

      A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
      https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

      Thanks

        Attachments

          Issue Links

            Activity

            hypnoce Francis JAC created issue -
            teilo James Nord made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR#55 (Web Link)" [ 13144 ]
            evanx9 Evan Wee made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            evanx9 Evan Wee made changes -
            Description https://issues.jenkins-ci.org/browse/JENKINS-6167
            The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

            A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
            https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

            Thanks
            https://issues.jenkins-ci.org/browse/JENKINS-6167
            The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

            A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
            https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

            Thanks

            EDIT:
            An updated fix that resolves conflicts is here:
            https://github.com/jenkinsci/remoting/pull/62
            https://github.com/evanx9/remoting/commit/cb2ded8e8ba6a67dd5996a7ca90a2f4f133ec8eb
            evanx9 Evan Wee made changes -
            Remote Link This issue links to "PR#62 (Web Link)" [ 13170 ]
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 1.625.3-rejected lts-candidate
            evanx9 Evan Wee made changes -
            Remote Link This issue links to "PR#62 (Web Link)" [ 13170 ]
            evanx9 Evan Wee made changes -
            Description https://issues.jenkins-ci.org/browse/JENKINS-6167
            The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

            A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
            https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

            Thanks

            EDIT:
            An updated fix that resolves conflicts is here:
            https://github.com/jenkinsci/remoting/pull/62
            https://github.com/evanx9/remoting/commit/cb2ded8e8ba6a67dd5996a7ca90a2f4f133ec8eb
            https://issues.jenkins-ci.org/browse/JENKINS-6167
            The fix submitted for this issue does not take into account the excluded proxy hosts unlike the hudson.remoting.Util.openURLConnection method which implicitly excludes hosts.

            A fix using the same method as sun.net.www.protocol.http.HttpURLConnection is available here :
            https://github.com/hypnoce/remoting/commit/67dbd966e628c42a0aa4d3cd91a56a00b7f95030

            Thanks

            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected lts-candidate 1.625.3-rejected 1.642.2-rejected lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected 1.642.2-rejected lts-candidate 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected lts-candidate
            omar_a Omar Ahmad made changes -
            Comment [ Hi, I have chosen this week to upgrade Jenkins core to the LTS release from last month (1.642.2) and I am facing this issue when attempting to connect slaves to the master. Is there an easy way I can upgrade the remoting component from 2.53.3 to 2.56 which contains fixes, (I tried replacing the JAR in the /war/WEB-INF/lib directory but without success as the master still serves version 2.53.3), so that I can get the upgrade working? Or should I wait for the next LTS release? Thanks ]
            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected lts-candidate 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-fixed
            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-fixed 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-rejected
            olivergondza Oliver Gondža made changes -
            Link This issue is related to JENKINS-33886 [ JENKINS-33886 ]
            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-rejected 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-rejected lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-rejected lts-candidate 1.625.3-rejected 1.642.2-rejected 1.642.3-rejected 1.651.1-rejected 1.651.2-fixed
            etiennebec Etienne Bec made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            etiennebec Etienne Bec made changes -
            Status Reopened [ 4 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 163123 ] JNJira + In-Review [ 197107 ]

              People

              • Assignee:
                Unassigned
                Reporter:
                hypnoce Francis JAC
              • Votes:
                0 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: