Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28409

EnvInjectPasswordsOutputStream does not close the parent logger

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If a job uses EnvInjectPasswordWrapper, the stream close command won't be propagated to upper loggers. It means that the files may stay in open state => potential file descriptor leaks.

      The leaks may have a big impact if you try delete a job from a remote NFS storage. Plugins like Timestamper also multiply a number of unclosed files, hence there's a real risk of the open descriptors overflow.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/test/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordTest.java
            http://jenkins-ci.org/commit/envinject-plugin/7c6976052b1417bf2eedad5ea36e0f3663fbfba8
            Log:
            JENKINS-28409 - Direct unit test for the issue

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/test/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordTest.java http://jenkins-ci.org/commit/envinject-plugin/7c6976052b1417bf2eedad5ea36e0f3663fbfba8 Log: JENKINS-28409 - Direct unit test for the issue
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java
            http://jenkins-ci.org/commit/envinject-plugin/561f243a771cc350c6b90589e2d9ee2bbc17f7fc
            Log:
            [FIXED JENKINS-28409] - Properly closed parent streams in EnvInjectPasswordsOutputStream

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java http://jenkins-ci.org/commit/envinject-plugin/561f243a771cc350c6b90589e2d9ee2bbc17f7fc Log: [FIXED JENKINS-28409] - Properly closed parent streams in EnvInjectPasswordsOutputStream
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java
            src/test/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordTest.java
            http://jenkins-ci.org/commit/envinject-plugin/35453256aee34e72d346132a888b6b567127dffa
            Log:
            Merge pull request #50 from oleg-nenashev/JENKINS-28409

            [FIXED JENKINS-28409] - Properly close parent streams in EnvInjectPasswordsOutputStream

            Compare: https://github.com/jenkinsci/envinject-plugin/compare/faea23f93513...35453256aee3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordWrapper.java src/test/java/org/jenkinsci/plugins/envinject/EnvInjectPasswordTest.java http://jenkins-ci.org/commit/envinject-plugin/35453256aee34e72d346132a888b6b567127dffa Log: Merge pull request #50 from oleg-nenashev/ JENKINS-28409 [FIXED JENKINS-28409] - Properly close parent streams in EnvInjectPasswordsOutputStream Compare: https://github.com/jenkinsci/envinject-plugin/compare/faea23f93513...35453256aee3

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: