Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28421

Information provided to email-ext should be perforce email address, not perforce username

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When a username is provided to the email-ext plugin the perforce username is provided. It would be better to return the configured perforce email address for that username if it is configured.

        Attachments

          Activity

          Hide
          p4paul Paul Allen added a comment - - edited

          I'm curious if I can set hudson.tasks.Mailer.UserProperty.UserProperty. MailAddressResolver claims to look for the email as a UserProperty:

          So the common technique for a mail address resolution is to define your own {@link UserProperty} types and
          add it to {@link User} objects where more context is available. For example, an {@link SCM} implementation
          can have a lot more information about a particular user during a check out, so that would be a good place
          to capture information as {@link UserProperty}, which then later used by a {@link MailAddressResolver}.
          
          Show
          p4paul Paul Allen added a comment - - edited I'm curious if I can set hudson.tasks.Mailer.UserProperty.UserProperty. MailAddressResolver claims to look for the email as a UserProperty: So the common technique for a mail address resolution is to define your own {@link UserProperty} types and add it to {@link User} objects where more context is available. For example, an {@link SCM} implementation can have a lot more information about a particular user during a check out, so that would be a good place to capture information as {@link UserProperty}, which then later used by a {@link MailAddressResolver}.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java
          src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java
          http://jenkins-ci.org/commit/p4-plugin/5f936ad0fffc3212a1960b1d7c67c3807c657fe4
          Log:
          Add Perforce User's email to Jenkins User property.

          JENKINS-28421

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java src/main/java/org/jenkinsci/plugins/p4/client/ConnectionHelper.java http://jenkins-ci.org/commit/p4-plugin/5f936ad0fffc3212a1960b1d7c67c3807c657fe4 Log: Add Perforce User's email to Jenkins User property. JENKINS-28421
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java
          http://jenkins-ci.org/commit/p4-plugin/e117cd2c9d1a33745191f5c326d4efb0184ace85
          Log:
          Only set email if User's address in null or empty.

          JENKINS-28421

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java http://jenkins-ci.org/commit/p4-plugin/e117cd2c9d1a33745191f5c326d4efb0184ace85 Log: Only set email if User's address in null or empty. JENKINS-28421
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java
          src/main/java/org/jenkinsci/plugins/p4/email/P4AddressResolver.java
          src/main/java/org/jenkinsci/plugins/p4/email/P4UserProperty.java
          src/main/resources/org/jenkinsci/plugins/p4/email/P4UserProperty/config.jelly
          http://jenkins-ci.org/commit/p4-plugin/c1f15ea19c720a3d4840aafa478b177c0d0f8f97
          Log:
          Created P4UserProperty to store Email address.

          P4UserProperty extends UserProperty to store the Perforce User’s email.
          Then retrieves it with P4AddressResolver by extending
          MailAddressResolver.

          JENKINS-28421

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/changes/P4ChangeEntry.java src/main/java/org/jenkinsci/plugins/p4/email/P4AddressResolver.java src/main/java/org/jenkinsci/plugins/p4/email/P4UserProperty.java src/main/resources/org/jenkinsci/plugins/p4/email/P4UserProperty/config.jelly http://jenkins-ci.org/commit/p4-plugin/c1f15ea19c720a3d4840aafa478b177c0d0f8f97 Log: Created P4UserProperty to store Email address. P4UserProperty extends UserProperty to store the Perforce User’s email. Then retrieves it with P4AddressResolver by extending MailAddressResolver. JENKINS-28421
          Hide
          p4paul Paul Allen added a comment -

          Fixed 1.3.0

          Show
          p4paul Paul Allen added a comment - Fixed 1.3.0

            People

            • Assignee:
              p4paul Paul Allen
              Reporter:
              treale Thomas Reale
            • Votes:
              2 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: