Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28790

Sonar database credentials in build console output not masked since LTS version 1.596.3

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      Jenkins LTS 1.596.3 / 1.609.1 / 1.609.2 / 1.609.3
      SonarQube plugin version 2.2.1
      Windows 2012 R2
      Java 8
      Browser FireFox
    • Similar Issues:

      Description

      When using Jenkins LTS version 1.596.3 / 1.609.1 / 1.609.2 / 1.609.3 we've noticed that the passwords from Sonar builds in the buildlog weren't masked anymore but showed as plain text.
      After we downgraded Jenkins to version 1.596.2 the passwords were masked again.
      I've tested several versions of the SonarQube plugin but that didn't had any effect, therefor it seems to be a Jenkins related issue.

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4491

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4491 Result = SUCCESS
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Emilio Escobar
            Path:
            core/src/main/java/hudson/util/ArgumentListBuilder.java
            core/src/test/java/hudson/util/ArgumentListBuilderTest.java
            http://jenkins-ci.org/commit/jenkins/0782aa567b4d2cf52aec5f5f5e0e8440c01edae4
            Log:
            JENKINS-28790 solved the issue masked parameters not masked in windows system. toWindowsCommand joins all args in one, missing masked.

            (cherry picked from commit b9a72bcd967fd8b0d422ccf81daf1de576702fd1)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Emilio Escobar Path: core/src/main/java/hudson/util/ArgumentListBuilder.java core/src/test/java/hudson/util/ArgumentListBuilderTest.java http://jenkins-ci.org/commit/jenkins/0782aa567b4d2cf52aec5f5f5e0e8440c01edae4 Log: JENKINS-28790 solved the issue masked parameters not masked in windows system. toWindowsCommand joins all args in one, missing masked. (cherry picked from commit b9a72bcd967fd8b0d422ccf81daf1de576702fd1)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Emilio Escobar
            Path:
            core/src/test/java/hudson/util/ArgumentListBuilderTest.java
            http://jenkins-ci.org/commit/jenkins/f6db6670a8f9107f189fedc4fed07b1bbc6a7dc3
            Log:
            JENKINS-28790 Baptiste comments fixed

            (cherry picked from commit 7fb1ac9d9f1bc006ca9d90ccaef402eaba4404a2)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Emilio Escobar Path: core/src/test/java/hudson/util/ArgumentListBuilderTest.java http://jenkins-ci.org/commit/jenkins/f6db6670a8f9107f189fedc4fed07b1bbc6a7dc3 Log: JENKINS-28790 Baptiste comments fixed (cherry picked from commit 7fb1ac9d9f1bc006ca9d90ccaef402eaba4404a2)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Emilio Escobar
            Path:
            core/src/main/java/hudson/util/ArgumentListBuilder.java
            http://jenkins-ci.org/commit/jenkins/717c5f56bcaa8fcfae109dd87a7c6e4069a3baed
            Log:
            JENKINS-28790 NIT: tabulation issue

            (cherry picked from commit 5423f695ab83ec7d49daae538d25177872b0aada)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Emilio Escobar Path: core/src/main/java/hudson/util/ArgumentListBuilder.java http://jenkins-ci.org/commit/jenkins/717c5f56bcaa8fcfae109dd87a7c6e4069a3baed Log: JENKINS-28790 NIT: tabulation issue (cherry picked from commit 5423f695ab83ec7d49daae538d25177872b0aada)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Emilio Escobar
            Path:
            core/src/main/java/hudson/util/ArgumentListBuilder.java
            http://jenkins-ci.org/commit/jenkins/f24c536676fe9df50fd499b51c4b4ff2e6edc40c
            Log:
            JENKINS-28790 added valentina condition when the first argument is quoted.

            (cherry picked from commit 344e917cc4a1096bb1805b14f0f2e45978b62757)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Emilio Escobar Path: core/src/main/java/hudson/util/ArgumentListBuilder.java http://jenkins-ci.org/commit/jenkins/f24c536676fe9df50fd499b51c4b4ff2e6edc40c Log: JENKINS-28790 added valentina condition when the first argument is quoted. (cherry picked from commit 344e917cc4a1096bb1805b14f0f2e45978b62757)

              People

              • Assignee:
                escoem Emilio Escobar
                Reporter:
                janjaap Jan-Jaap Spijkerman
              • Votes:
                7 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: