Details

    • Similar Issues:

      Description

      This plugin shows in the UI some icons (with different sizes) to indicate actions. These icons are broken because its URL is wrong. i.e.

      /**
       * {@inheritDoc}
       */
      public String getIconFileName() {
          return isDeployPossible(owner) ? Jenkins.RESOURCE_PATH
                  + "/plugin/cloudbees-deployer-plugin/images/24x24/deploy-now.png" : null;
      }
      

      Why is wrong? Because the short-name of this plugin is deployer-framework not cloudbees-deployer-plugin.

        Attachments

          Activity

          Hide
          recena Manuel Recena Soto added a comment -

          Sent PR.

          Show
          recena Manuel Recena Soto added a comment - Sent PR .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: recena
          Path:
          src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java
          src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly
          http://jenkins-ci.org/commit/deployer-framework-plugin/df99785f022471124b10ec0b45416c13844a52cc
          Log:
          Related to JENKINS-28894 - Broken icons

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: recena Path: src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly http://jenkins-ci.org/commit/deployer-framework-plugin/df99785f022471124b10ec0b45416c13844a52cc Log: Related to JENKINS-28894 - Broken icons
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java
          src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly
          src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly
          http://jenkins-ci.org/commit/deployer-framework-plugin/529182f5ddc060f0950b96911dae027175609929
          Log:
          Merge pull request #1 from recena/master

          Related to JENKINS-28894 - Broken icons

          Compare: https://github.com/jenkinsci/deployer-framework-plugin/compare/285219287815...529182f5ddc0

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/plugins/deployer/DeployNowProjectAction.java src/main/java/com/cloudbees/plugins/deployer/DeployNowRunAction.java src/main/resources/com/cloudbees/plugins/deployer/DeployNowColumn/column.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowJobProperty/config.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowProjectAction/configure.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/_deploy.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployNowRunAction/configure.jelly src/main/resources/com/cloudbees/plugins/deployer/DeployPublisher/config.jelly http://jenkins-ci.org/commit/deployer-framework-plugin/529182f5ddc060f0950b96911dae027175609929 Log: Merge pull request #1 from recena/master Related to JENKINS-28894 - Broken icons Compare: https://github.com/jenkinsci/deployer-framework-plugin/compare/285219287815...529182f5ddc0

            People

            • Assignee:
              recena Manuel Recena Soto
              Reporter:
              recena Manuel Recena Soto
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: