Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28913

unique-id stores empty ids.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: unique-id
    • Labels:
      None
    • Similar Issues:

      Description

      WHen the unique id plugin creates an ID for a new job the id persisted to disk is the empty string.

        Attachments

          Activity

          teilo James Nord created issue -
          teilo James Nord made changes -
          Field Original Value New Value
          Assignee recampbell [ recampbell ] James Nord [ teilo ]
          teilo James Nord made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Nord
          Path:
          src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java
          src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java
          http://jenkins-ci.org/commit/unique-id-plugin/f79e4cd342fb830c47adf3d3732e3988ac6c6018
          Log:
          [FIXED JENKINS-28913] write the id to the correct file.

          When sotring the ID write it to the correct file.
          Add unit tests to check the uniqueness of the ID to catch regresssions.
          Add some code to migrate an empty id. (this will only happen for new
          jobs/builds created with 2.0 or 2.0.1 of the plugin.)

          Migrations will be ok.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Nord Path: src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java http://jenkins-ci.org/commit/unique-id-plugin/f79e4cd342fb830c47adf3d3732e3988ac6c6018 Log: [FIXED JENKINS-28913] write the id to the correct file. When sotring the ID write it to the correct file. Add unit tests to check the uniqueness of the ID to catch regresssions. Add some code to migrate an empty id. (this will only happen for new jobs/builds created with 2.0 or 2.0.1 of the plugin.) Migrations will be ok.
          scm_issue_link SCM/JIRA link daemon made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Nord
          Path:
          src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java
          src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java
          http://jenkins-ci.org/commit/unique-id-plugin/aa7d348416c542b4fce20ca0d29822ff42bfa9f8
          Log:
          JENKINS-28913 correctly regenerate the ID.

          If the id was not generated correctly then delete the file before
          regenerating the ID, otherwise the new ID will never be created.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Nord Path: src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java http://jenkins-ci.org/commit/unique-id-plugin/aa7d348416c542b4fce20ca0d29822ff42bfa9f8 Log: JENKINS-28913 correctly regenerate the ID. If the id was not generated correctly then delete the file before regenerating the ID, otherwise the new ID will never be created.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: James Nord
          Path:
          src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java
          src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java
          http://jenkins-ci.org/commit/unique-id-plugin/98adff6e1aef3a3bb4f175b4aabaa5c941bd2433
          Log:
          Merge pull request #5 from jenkinsci/JENKINS-28913

          [FIXED JENKINS-28913] write the id to the correct file.

          Compare: https://github.com/jenkinsci/unique-id-plugin/compare/1a7b37a8ea11...98adff6e1aef

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: James Nord Path: src/main/java/org/jenkinsci/plugins/uniqueid/implv2/PersistenceRootIdStore.java src/test/java/org/jenkinsci/plugins/uniqueid/IdTest.java http://jenkins-ci.org/commit/unique-id-plugin/98adff6e1aef3a3bb4f175b4aabaa5c941bd2433 Log: Merge pull request #5 from jenkinsci/ JENKINS-28913 [FIXED JENKINS-28913] write the id to the correct file. Compare: https://github.com/jenkinsci/unique-id-plugin/compare/1a7b37a8ea11...98adff6e1aef
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 163777 ] JNJira + In-Review [ 197315 ]

            People

            • Assignee:
              teilo James Nord
              Reporter:
              teilo James Nord
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: