Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28937

Manual trigger for the downstream job is shown even if the build failed

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
      None
    • Environment:
      Jenkins version 1.594
      Delivery Pipeline plugin 0.9.4
      Build Pipeline Plugin 1.4.7
    • Similar Issues:

      Description

      I have three jobs: A, B and C
      Job A is set to manually trigger job B
      Job B is set to manually trigger job C

      I run the Job A, it passes and then the manual trigger for job B is displayed -> this is ok.
      I run the job B, it fails, but it stills enable the manual trigger for the downstream job (Job C in this case).

      I think that the expected result is to don't have the manual trigger enabled for the downstream job is the job fails.

      Attached a screenshot.

        Attachments

          Activity

          marius_balteanu Marius Balteanu created issue -
          marius_balteanu Marius Balteanu made changes -
          Field Original Value New Value
          Summary Manual trigger is shown even if the build failed Manual trigger for the downstream job is shown even if the build failed
          Hide
          patbos Patrik Boström added a comment -

          Reproduced and have created PR https://github.com/Diabol/delivery-pipeline-plugin/pull/121 with a fix for the problem.

          Show
          patbos Patrik Boström added a comment - Reproduced and have created PR https://github.com/Diabol/delivery-pipeline-plugin/pull/121 with a fix for the problem.
          patbos Patrik Boström made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          patbos Patrik Boström added a comment -

          Merged PR

          Show
          patbos Patrik Boström added a comment - Merged PR
          patbos Patrik Boström made changes -
          Status In Progress [ 3 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          bbacio Burak Bacioglu added a comment -

          Is it possible to make this optional? We rely on this button being enabled for some of our pipelines. For example we have a pipeline that creates new stacks, builds and deploys feature branches. They might as well fail as they are not productized code and are still in development. However we have a final stage in our pipeline called cleanup. Regardless of whether the previous stage (build/deploy) succeeded or failed, one can execute cleanup stage to remove the stack and delete the feature branch.

          Show
          bbacio Burak Bacioglu added a comment - Is it possible to make this optional? We rely on this button being enabled for some of our pipelines. For example we have a pipeline that creates new stacks, builds and deploys feature branches. They might as well fail as they are not productized code and are still in development. However we have a final stage in our pipeline called cleanup. Regardless of whether the previous stage (build/deploy) succeeded or failed, one can execute cleanup stage to remove the stack and delete the feature branch.
          Hide
          marius_balteanu Marius Balteanu added a comment -

          Or maybe it should be implemented in the Build Pipeline Plugin as option exactly like in the "Build Other Project" post build action.

          Show
          marius_balteanu Marius Balteanu added a comment - Or maybe it should be implemented in the Build Pipeline Plugin as option exactly like in the "Build Other Project" post build action.
          Hide
          patbos Patrik Boström added a comment -

          I think this should be a option in the manual trigger from the Build Pipeline Plugin to have an option "Trigger when build is" with options like stable, always...

          Show
          patbos Patrik Boström added a comment - I think this should be a option in the manual trigger from the Build Pipeline Plugin to have an option "Trigger when build is" with options like stable, always...
          Hide
          patbos Patrik Boström added a comment -

          Released in 0.9.5

          Show
          patbos Patrik Boström added a comment - Released in 0.9.5
          patbos Patrik Boström made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 163801 ] JNJira + In-Review [ 208886 ]

            People

            • Assignee:
              patbos Patrik Boström
              Reporter:
              marius_balteanu Marius Balteanu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: