Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29048

st:include for Descriptor should use not from="${d}" but class="${d.klazz}"

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
      None
    • Environment:
      Jenkins 1.617
    • Similar Issues:

      Description

      Let's take following case:

      • Plugin A defines a sub class of Descriptor (PluginADescriptor)
      • Plugin B depending on plugin A defines a Describable class described by an instance of PluginADescriptor (DescribableB).
        • Watch that it is described by an instance of *not a subclass of * PluginADescriptor but PluginADescriptor itself.

      This is exactly the case SimpleBuildSelectorDescriptor in copyartifact-plugin.

      In this case, the following jelly fails:

      <st:include from="${d}" page="${d.configPage}" />
      

      as stapler try to load config.jelly from plugin A, but it's actually in plugin B.

      That should be:

      <st:include class="${d.klazz}" page="${d.configPage}" />
      

        Attachments

          Issue Links

            Activity

            ikedam ikedam created issue -
            ikedam ikedam made changes -
            Field Original Value New Value
            Link This issue is blocking JENKINS-28972 [ JENKINS-28972 ]
            Hide
            ikedam ikedam added a comment -

            Affected tags in core:

            • form/descriptorRadioList.jelly
            • form/hetero-list.jelly
            • form/dropdownDescriptorSelector.jelly
            • form/descriptorList.jelly
            • form/property.jelly
            • form/hetero-radio.jelly
            • form/optionalProperty.jelly
            • hudson/security/GlobalSecurityConfiguration/index.groovy
            • hudson/model/User/configure.jelly
            • jenkins/model/Jenkins/configure.jelly
            • hudson/security/HudsonPrivateSecurityRealm/config.jelly
            • hudson/PluginManager/advanced.jelly
            • hudson/project/config-scm.jelly
            • hudson/slaves/DumbSlave/configure-entries.jelly
            Show
            ikedam ikedam added a comment - Affected tags in core: form/descriptorRadioList.jelly form/hetero-list.jelly form/dropdownDescriptorSelector.jelly form/descriptorList.jelly form/property.jelly form/hetero-radio.jelly form/optionalProperty.jelly hudson/security/GlobalSecurityConfiguration/index.groovy hudson/model/User/configure.jelly jenkins/model/Jenkins/configure.jelly hudson/security/HudsonPrivateSecurityRealm/config.jelly hudson/PluginManager/advanced.jelly hudson/project/config-scm.jelly hudson/slaves/DumbSlave/configure-entries.jelly
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 163914 ] JNJira + In-Review [ 181432 ]

              People

              • Assignee:
                ikedam ikedam
                Reporter:
                ikedam ikedam
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: