Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29153

tap plugin fails job when not have to

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hi,
      more details in the attached pdf.

      short version - tap plugins fails job while configured not to.

        Attachments

          Activity

          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hi

          Thanks for taking the time to report this issue, attaching detailed description, and sorry for the delay to get back to you.

          So in summary, if I understood it correctly, the following TAP stream

          #cat /var/lib/jenkins/jobs/gh-mellanox-v1.8-PR/builds/137/tap-master-files/cov_stat.tap
          not ok - coverity detected 1411 failures in all # SKIP
          ok - coverity found no issues for oshmem
          ok - coverity found no issues for yalla
          ok - coverity found no issues for mxm
          ok - coverity found no issues for fca
          ok - coverity found no issues for hcoll
          

          Is marked as containing failed tests. The first test result in the TAP stream is a not ok test (failure), but should be skipped, and not influence in the build status.

          Show
          kinow Bruno P. Kinoshita added a comment - Hi Thanks for taking the time to report this issue, attaching detailed description, and sorry for the delay to get back to you. So in summary, if I understood it correctly, the following TAP stream #cat /var/lib/jenkins/jobs/gh-mellanox-v1.8-PR/builds/137/tap-master-files/cov_stat.tap not ok - coverity detected 1411 failures in all # SKIP ok - coverity found no issues for oshmem ok - coverity found no issues for yalla ok - coverity found no issues for mxm ok - coverity found no issues for fca ok - coverity found no issues for hcoll Is marked as containing failed tests. The first test result in the TAP stream is a not ok test (failure), but should be skipped, and not influence in the build status.
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Successfully reproduced the issue in my environment, will work to fix it and include in the next release. The only problem is that we need to make sure that other metrics take into consideration the skip directive as well.

          Show
          kinow Bruno P. Kinoshita added a comment - Successfully reproduced the issue in my environment, will work to fix it and include in the next release. The only problem is that we need to make sure that other metrics take into consideration the skip directive as well.
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hmmm, looks like there's a bug in tap4j as well. Will fix that first.

          https://github.com/tupilabs/tap4j/issues/37

          Show
          kinow Bruno P. Kinoshita added a comment - Hmmm, looks like there's a bug in tap4j as well. Will fix that first. https://github.com/tupilabs/tap4j/issues/37
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          pom.xml
          src/main/java/org/tap4j/plugin/TapParser.java
          http://jenkins-ci.org/commit/tap-plugin/88720b64b1a7cdb89aeb5e6fcf23e5618955a4f4
          Log:
          [FIXED JENKINS-29153] Update to tap4j 4.1.1 and introduce new method to ignore skipped tests (instead of considering them as failures)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: pom.xml src/main/java/org/tap4j/plugin/TapParser.java http://jenkins-ci.org/commit/tap-plugin/88720b64b1a7cdb89aeb5e6fcf23e5618955a4f4 Log: [FIXED JENKINS-29153] Update to tap4j 4.1.1 and introduce new method to ignore skipped tests (instead of considering them as failures)
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Released in 1.24

          Show
          kinow Bruno P. Kinoshita added a comment - Released in 1.24

            People

            • Assignee:
              kinow Bruno P. Kinoshita
              Reporter:
              dubman Mike Dubman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: