Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29527

AuthorizationMatrixProperty converter: Inheritance blocking may be passed incorrectly

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If "useProjectSecurity" appears in the marshalled stream before "blocksInheritance", the second option may be ignored => the project may start taking inherited permissions.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/security/AuthorizationMatrixProperty.java
          src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java
          http://jenkins-ci.org/commit/matrix-auth-plugin/227960a8d230ec79741903948c02064c5e195a34
          Log:
          Fix issues discovered by FindBugs. 1 issues has been postponed as JENKINS-29527

          Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/46bc8c9cf52b...227960a8d230

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/security/AuthorizationMatrixProperty.java src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java http://jenkins-ci.org/commit/matrix-auth-plugin/227960a8d230ec79741903948c02064c5e195a34 Log: Fix issues discovered by FindBugs. 1 issues has been postponed as JENKINS-29527 Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/46bc8c9cf52b...227960a8d230
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/security/AuthorizationMatrixProperty.java
          http://jenkins-ci.org/commit/matrix-auth-plugin/b0c22a0289bf78e545c891ce945c8f2628366ee5
          Log:
          [FIXED JENKINS-29527] - AuthorizationMatrixProperty converter: Inheritance blocking may be passed incorrectly

          If "useProjectSecurity" appears in the marshalled stream before "blocksInheritance", the second option may be ignored => the project may start taking inherited permissions. However, seems the code just iterates through fields => we should not use the else clause. The assigned "prop" variable is never used, so it's another clue of the bug

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/security/AuthorizationMatrixProperty.java http://jenkins-ci.org/commit/matrix-auth-plugin/b0c22a0289bf78e545c891ce945c8f2628366ee5 Log: [FIXED JENKINS-29527] - AuthorizationMatrixProperty converter: Inheritance blocking may be passed incorrectly If "useProjectSecurity" appears in the marshalled stream before "blocksInheritance", the second option may be ignored => the project may start taking inherited permissions. However, seems the code just iterates through fields => we should not use the else clause. The assigned "prop" variable is never used, so it's another clue of the bug
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/hudson/security/AuthorizationMatrixProperty.java
          http://jenkins-ci.org/commit/matrix-auth-plugin/74cbb6e79caacb9b3c3adeea2aeee9641aa8ec51
          Log:
          Merge pull request #3 from jenkinsci/findbugs-enable

          [FIXED JENKINS-29527] - AuthorizationMatrixProperty converter: Inheritance blocking may be passed incorrectly

          Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/a30a95b2f249...74cbb6e79caa

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/hudson/security/AuthorizationMatrixProperty.java http://jenkins-ci.org/commit/matrix-auth-plugin/74cbb6e79caacb9b3c3adeea2aeee9641aa8ec51 Log: Merge pull request #3 from jenkinsci/findbugs-enable [FIXED JENKINS-29527] - AuthorizationMatrixProperty converter: Inheritance blocking may be passed incorrectly Compare: https://github.com/jenkinsci/matrix-auth-plugin/compare/a30a95b2f249...74cbb6e79caa

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: