Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-29650

recording the TAP-results waits for checkpoint

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: tap-plugin
    • Labels:
      None
    • Environment:
      Linux
      Jenkins 1.621
      TAP Plugin 1.23
    • Similar Issues:

      Description

      Most jobs we have run arout 1:30 hrs. We have some pre-checks that should informs us quicker if something fundamental or important is not correct. There pre-checks are done within 1 or 2 minutes.

      However, the TAP-Plugin waits for a checkpoint for a previous build, effectively stretching the otherwise 1-2 minute feedback cycle to 1:30 hours. I would be enough to disable this behaviour with a per-job option.

        Attachments

          Activity

          kronn Matthias Viehweger created issue -
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hmmmm, I'm quite sure I've seen this issue in one of the plug-ins I maintain (guess it was NUnit?), so I'm not surprised to recognise the bug. Thanks for reporting, stay tuned as I'll try to start a dev cycle on the plug-in in the next days.

          Show
          kinow Bruno P. Kinoshita added a comment - Hmmmm, I'm quite sure I've seen this issue in one of the plug-ins I maintain (guess it was NUnit?), so I'm not surprised to recognise the bug. Thanks for reporting, stay tuned as I'll try to start a dev cycle on the plug-in in the next days.
          Hide
          kronn Matthias Viehweger added a comment -

          I'm not a Java-developer, but if you show me how this is done in another plugin, then I can do the grunt-work of actually writing it, so you just have a pull-request on github to review.

          Show
          kronn Matthias Viehweger added a comment - I'm not a Java-developer, but if you show me how this is done in another plugin, then I can do the grunt-work of actually writing it, so you just have a pull-request on github to review.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/TapPublisher.java
          http://jenkins-ci.org/commit/tap-plugin/4343691e0f23e612c3639033262521da419592e3
          Log:
          [FIXED JENKINS-29650] Don't use a build step synchronization, defaulting to NONE.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/TapPublisher.java http://jenkins-ci.org/commit/tap-plugin/4343691e0f23e612c3639033262521da419592e3 Log: [FIXED JENKINS-29650] Don't use a build step synchronization, defaulting to NONE.
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hi Matthias. I think I remembered what was the problem. It was the required synchronization in Jenkins. At the moment, we have a build step, which means the publisher in the plug-in runs after the build step in the previous build has been executed.

          Let me know if that fixes your issue.

          I need to dig deeper into Jenkins API and thoroughly understand the required build monitor service, as well as checkpoints :o) but hopefully that will fix your issue for now.

          Thanks for reporting
          Bruno

          Show
          kinow Bruno P. Kinoshita added a comment - Hi Matthias. I think I remembered what was the problem. It was the required synchronization in Jenkins. At the moment, we have a build step, which means the publisher in the plug-in runs after the build step in the previous build has been executed. Let me know if that fixes your issue. I need to dig deeper into Jenkins API and thoroughly understand the required build monitor service, as well as checkpoints :o) but hopefully that will fix your issue for now. Thanks for reporting Bruno
          Hide
          kronn Matthias Viehweger added a comment -

          From what I understand, this should fix the problem. Can you tell me how I can test this? So far, I only installed plugins through the jenkins-plugin UI.

          Do I need to compile the plugin into a hpi or jar or something like that?
          if so, how is that done?

          Can I just edit the files on disk and restart jenkins?
          where would the files be?

          Sorry for the noobish questions and thanks for your work!

          Show
          kronn Matthias Viehweger added a comment - From what I understand, this should fix the problem. Can you tell me how I can test this? So far, I only installed plugins through the jenkins-plugin UI. Do I need to compile the plugin into a hpi or jar or something like that? if so, how is that done? Can I just edit the files on disk and restart jenkins? where would the files be? Sorry for the noobish questions and thanks for your work!
          Hide
          kronn Matthias Viehweger added a comment -

          I managed to compile the plugin from source and installed the resulting hpi into our jenkins-instance. I will let this run for a week and tell you if I can still observe problems.

          After a few tests with low concurrency, I did find no ovbious error.

          Show
          kronn Matthias Viehweger added a comment - I managed to compile the plugin from source and installed the resulting hpi into our jenkins-instance. I will let this run for a week and tell you if I can still observe problems. After a few tests with low concurrency, I did find no ovbious error.
          Hide
          kronn Matthias Viehweger added a comment -

          After a bit more than a week of real-life testing, I did not encounter the error againg.

          I am looking forward to the next release so that I can switch back to the normal version.

          Show
          kronn Matthias Viehweger added a comment - After a bit more than a week of real-life testing, I did not encounter the error againg. I am looking forward to the next release so that I can switch back to the normal version.
          kronn Matthias Viehweger made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 164627 ] JNJira + In-Review [ 209061 ]

            People

            • Assignee:
              kinow Bruno P. Kinoshita
              Reporter:
              kronn Matthias Viehweger
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: