Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Util.isOverridden works only on public methods.

      It needs to be improved in order to inspect non-public too through the inheritance. For example is this case:

      public abstract class Base {
          protected abstract void method();
      }
      public abstract class Intermediate extends Base {
          protected void method() {}
      }
      public class Derived extends Intermediate {}
      

      A call to isOverridden(Base.class, Derived.class, "method") should return true.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java
            src/main/java/jenkins/plugins/git/MethodUtils.java
            http://jenkins-ci.org/commit/git-plugin/c3a66f296ef1ccbf117b4a1f85cdd56577c7b1c0
            Log:
            JENKINS-43507 Add workaround for JENKINS-30002 until available in baseline version of Jenkins core

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/plugins/git/AbstractGitSCMSource.java src/main/java/jenkins/plugins/git/MethodUtils.java http://jenkins-ci.org/commit/git-plugin/c3a66f296ef1ccbf117b4a1f85cdd56577c7b1c0 Log: JENKINS-43507 Add workaround for JENKINS-30002 until available in baseline version of Jenkins core
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            changelog.html
            core/src/main/java/hudson/Util.java
            core/src/main/java/hudson/console/ConsoleLogFilter.java
            core/src/main/java/hudson/model/Label.java
            core/src/main/java/hudson/model/Queue.java
            core/src/main/java/hudson/model/Run.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            core/src/main/java/hudson/tasks/BuildWrappers.java
            core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
            core/src/main/resources/lib/layout/task.jelly
            core/src/test/java/hudson/FilePathTest.java
            core/src/test/java/hudson/LauncherTest.java
            core/src/test/java/hudson/util/IsOverriddenTest.java
            core/src/test/java/hudson/util/ProcessTreeTest.java
            test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
            test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            test/src/test/java/hudson/console/ConsoleLogFilterTest.java
            test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
            test/src/test/java/hudson/model/NodeTest.java
            test/src/test/java/hudson/model/QueueTest.java
            test/src/test/java/hudson/slaves/DummyCloudImpl.java
            test/src/test/java/hudson/slaves/JNLPLauncherTest.java
            test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java
            test/src/test/java/hudson/tasks/ShellTest.java
            test/src/test/java/hudson/tools/JDKInstallerTest.java
            test/src/test/java/hudson/util/ProcessTreeKillerTest.java
            test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
            http://jenkins-ci.org/commit/jenkins/955eb7274a02e3549493cd2e1e0de785a0893784
            Log:
            Merge branch 'master' into plugin-manager-dependants

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html core/src/main/java/hudson/Util.java core/src/main/java/hudson/console/ConsoleLogFilter.java core/src/main/java/hudson/model/Label.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/hudson/tasks/BuildWrappers.java core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java core/src/main/resources/lib/layout/task.jelly core/src/test/java/hudson/FilePathTest.java core/src/test/java/hudson/LauncherTest.java core/src/test/java/hudson/util/IsOverriddenTest.java core/src/test/java/hudson/util/ProcessTreeTest.java test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy test/src/test/java/hudson/console/ConsoleLogFilterTest.java test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java test/src/test/java/hudson/model/NodeTest.java test/src/test/java/hudson/model/QueueTest.java test/src/test/java/hudson/slaves/DummyCloudImpl.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java test/src/test/java/hudson/tasks/ShellTest.java test/src/test/java/hudson/tools/JDKInstallerTest.java test/src/test/java/hudson/util/ProcessTreeKillerTest.java test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java http://jenkins-ci.org/commit/jenkins/955eb7274a02e3549493cd2e1e0de785a0893784 Log: Merge branch 'master' into plugin-manager-dependants master: (58 commits) Changelog: Replace the PR reference by the JIRA issue reference Noting https://github.com/jenkinsci/jenkins/pull/1818 Noting https://github.com/jenkinsci/jenkins/pull/1804 JENKINS-30002 Improve Util.isOverridden Noting #1842 [FIXED JENKINS-30777] this concludes the fix JENKINS-30777 also allow slaves to decorate logger JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild. Diamond operator [FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger Noting JENKINS-30084 in changelog JENKINS-30084 remove extra space JENKINS-30084 address feedbacks JENKINS-30084 indent back JENKINS-30084 fixing test JENKINS-30084 fixing test JENKINS-30084 enhancing test case JENKINS-30084 test added to make sure a flyweight task can be blocked at last minute JENKINS-30084 fix regression when flyweight task is blocked by upstream/downstream project JENKINS-30084 some more polish ...
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4302
            JENKINS-30002 Improve Util.isOverridden (Revision 89a0050ceaf2a50517056582d1c188052f994fd7)

            Result = SUCCESS
            amuniz : 89a0050ceaf2a50517056582d1c188052f994fd7
            Files :

            • core/src/test/java/hudson/util/IsOverriddenTest.java
            • core/src/main/java/hudson/Util.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4302 JENKINS-30002 Improve Util.isOverridden (Revision 89a0050ceaf2a50517056582d1c188052f994fd7) Result = SUCCESS amuniz : 89a0050ceaf2a50517056582d1c188052f994fd7 Files : core/src/test/java/hudson/util/IsOverriddenTest.java core/src/main/java/hudson/Util.java
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Should become available in 1.632

            Show
            oleg_nenashev Oleg Nenashev added a comment - Should become available in 1.632
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/Util.java
            core/src/test/java/hudson/util/IsOverriddenTest.java
            http://jenkins-ci.org/commit/jenkins/6adbb33e6b2c267e1832ecb801f7bcc364331d5a
            Log:
            Merge pull request #1804 from amuniz/JENKINS-30002

            JENKINS-30002 Improve Util.isOverridden

            Compare: https://github.com/jenkinsci/jenkins/compare/dd8f775a99cf...6adbb33e6b2c

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/Util.java core/src/test/java/hudson/util/IsOverriddenTest.java http://jenkins-ci.org/commit/jenkins/6adbb33e6b2c267e1832ecb801f7bcc364331d5a Log: Merge pull request #1804 from amuniz/ JENKINS-30002 JENKINS-30002 Improve Util.isOverridden Compare: https://github.com/jenkinsci/jenkins/compare/dd8f775a99cf...6adbb33e6b2c
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Antonio Muñiz
            Path:
            core/src/main/java/hudson/Util.java
            core/src/test/java/hudson/util/IsOverriddenTest.java
            http://jenkins-ci.org/commit/jenkins/89a0050ceaf2a50517056582d1c188052f994fd7
            Log:
            JENKINS-30002 Improve Util.isOverridden

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: core/src/main/java/hudson/Util.java core/src/test/java/hudson/util/IsOverriddenTest.java http://jenkins-ci.org/commit/jenkins/89a0050ceaf2a50517056582d1c188052f994fd7 Log: JENKINS-30002 Improve Util.isOverridden
            Show
            amuniz Antonio Muñiz added a comment - PR sent: https://github.com/jenkinsci/jenkins/pull/1804

              People

              • Assignee:
                amuniz Antonio Muñiz
                Reporter:
                amuniz Antonio Muñiz
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: