Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30223

Migrator for Credential.java is failing

    Details

    • Similar Issues:

      Description

      ElasticBox plugin is using github plugin to connect to GitHub. It uses Crendential class that GitHub-plugin has removed in 1.13 release.

      It seems that there is a migration to move the class from com.cloudbees.jenkins.Credential.java to org.jenkinsci.plugins.github.deprecated.Credential.java but when we install ElasticBox plugin, that migration is failing. I've attached jenkins log.

      It seems also that you removed login() function from Credential class, so although migration works, the compatibility with a plugin that is depending on this, is not working anymore.

        Attachments

          Activity

          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          Thanks a lot for your help!

          Show
          ignaciofuertes Ignacio Fuertes added a comment - Thanks a lot for your help!
          Hide
          lanwen Kirill Merkushev added a comment -

          will release gh 1.13.3 with reverted class tomorrow in the morning

          Show
          lanwen Kirill Merkushev added a comment - will release gh 1.13.3 with reverted class tomorrow in the morning
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kirill Merkushev
          Path:
          src/main/java/com/cloudbees/jenkins/Credential.java
          src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java
          src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java
          src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java
          src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java
          src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java
          http://jenkins-ci.org/commit/github-plugin/b10ad388815a35617fe5fbb79171f116eb814a64
          Log:
          [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential

          as of it makes fail to boot jenkins after installation of plugin which depends on this class.
          Also remove migration to another package for this class and use it directly

          (cherry picked from commit 061d849)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kirill Merkushev Path: src/main/java/com/cloudbees/jenkins/Credential.java src/main/java/com/cloudbees/jenkins/GitHubPushTrigger.java src/main/java/org/jenkinsci/plugins/github/config/GitHubServerConfig.java src/main/java/org/jenkinsci/plugins/github/deprecated/Credential.java src/main/java/org/jenkinsci/plugins/github/migration/Migrator.java src/test/java/org/jenkinsci/plugins/github/migration/MigratorTest.java http://jenkins-ci.org/commit/github-plugin/b10ad388815a35617fe5fbb79171f116eb814a64 Log: [FIXES JENKINS-30223] return back com.cloudbees.jenkins.Credential as of it makes fail to boot jenkins after installation of plugin which depends on this class. Also remove migration to another package for this class and use it directly (cherry picked from commit 061d849)
          Hide
          lanwen Kirill Merkushev added a comment -

          1.13.3 shipped

          Show
          lanwen Kirill Merkushev added a comment - 1.13.3 shipped
          Hide
          ignaciofuertes Ignacio Fuertes added a comment -

          Great, Thanks!

          Show
          ignaciofuertes Ignacio Fuertes added a comment - Great, Thanks!

            People

            • Assignee:
              lanwen Kirill Merkushev
              Reporter:
              ignaciofuertes Ignacio Fuertes
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: