Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30371

Symlinks still not supported on unix with JGit 3.7.1

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
      None
    • Environment:
      Ubuntu 12.04
      Java 1.7
      Jenkins 1.628
      git-client-plugin 1.19.0 (JGit 3.7.1.201504261725-r)
      git-plugin 2.4.0
    • Similar Issues:

      Description

      Configuring Jenkins to use JGit, cloning a git repo containing symlinks leads to a clone where symlinks are replaced by files. The created clone config file contains the following:

      [core]
          symlinks = false

      According to what I read in this JGit issue, I thought the issue would have been solved by meeting the following conditions:

      • running Jenkins on java 7
      • Using JGit>3.7.0, i.e. using git-client-plugin>=1.18.0

      It seems I was wrong, but I don't know where to look now.

        Attachments

          Activity

          Hide
          markewaite Mark Waite added a comment -

          Pull request 193 proposes the change to include symlink support with JGit on Java 7.

          Interactive testing of that change is still needed, but the automated tests pass, and the code compiles and executes tests on Java 6 and Java 7.

          Show
          markewaite Mark Waite added a comment - Pull request 193 proposes the change to include symlink support with JGit on Java 7. Interactive testing of that change is still needed, but the automated tests pass, and the code compiles and executes tests on Java 6 and Java 7.
          Hide
          alexf Alexandre Feblot added a comment -

          Thanks Mark!
          I cross my fingers now to see it merged soon.

          Show
          alexf Alexandre Feblot added a comment - Thanks Mark! I cross my fingers now to see it merged soon.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mark Waite
          Path:
          pom.xml
          http://jenkins-ci.org/commit/git-client-plugin/cce0f8b30373ebce707aaf8457640cea7fe4489d
          Log:
          JENKINS-30371 Distribute JGit java7 jar to allow JGit symlink support

          JGit symlink support is optional with JGit 3.7.1. It requires a copy of
          the JGit java7 jar, a Java 7 VM, and a file system which supports symbolic
          links. Including the jar file in a Java 6 environment is safe because
          the JGit code won't load the additional jar when running on Java 6.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: pom.xml http://jenkins-ci.org/commit/git-client-plugin/cce0f8b30373ebce707aaf8457640cea7fe4489d Log: JENKINS-30371 Distribute JGit java7 jar to allow JGit symlink support JGit symlink support is optional with JGit 3.7.1. It requires a copy of the JGit java7 jar, a Java 7 VM, and a file system which supports symbolic links. Including the jar file in a Java 6 environment is safe because the JGit code won't load the additional jar when running on Java 6.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mark Waite
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java
          http://jenkins-ci.org/commit/git-client-plugin/d48982900e34e7c821c91b124cc4d523e439570c
          Log:
          Merge pull request #193 from MarkEWaite/master-JENKINS-30371-jgit-symlinks

          [Fix JENKINS-30371] allow symlinks with jgit

          Compare: https://github.com/jenkinsci/git-client-plugin/compare/11d9be244177...d48982900e34

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: pom.xml src/test/java/org/jenkinsci/plugins/gitclient/GitAPITestCase.java http://jenkins-ci.org/commit/git-client-plugin/d48982900e34e7c821c91b124cc4d523e439570c Log: Merge pull request #193 from MarkEWaite/master- JENKINS-30371 -jgit-symlinks [Fix JENKINS-30371] allow symlinks with jgit Compare: https://github.com/jenkinsci/git-client-plugin/compare/11d9be244177...d48982900e34
          Hide
          markewaite Mark Waite added a comment -

          Fix included in git client plugin 1.19.1 released 26 Dec 2015

          Show
          markewaite Mark Waite added a comment - Fix included in git client plugin 1.19.1 released 26 Dec 2015

            People

            • Assignee:
              markewaite Mark Waite
              Reporter:
              alexf Alexandre Feblot
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: