Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30626

PingGHEventSubscriber crashes in response to organization-level webhooks

    Details

    • Similar Issues:

      Description

      If you configure the /github-webhook/ on a GitHub organization, pings get a 200 status code but print a stack trace in Jenkins:

      ... org.jenkinsci.plugins.github.extension.GHEventsSubscriber$4 applyNullSafe
      SEVERE: Subscriber org.jenkinsci.plugins.github.webhook.subscriber.PingGHEventSubscriber failed to process PING hook, skipping...
      net.sf.json.JSONException: null object
      	at net.sf.json.JSONObject.verifyIsNull(JSONObject.java:2688)
      	at net.sf.json.JSONObject.getString(JSONObject.java:2035)
      	at org.jenkinsci.plugins.github.webhook.subscriber.PingGHEventSubscriber.onEvent(PingGHEventSubscriber.java:56)
      	at org.jenkinsci.plugins.github.extension.GHEventsSubscriber$4.applyNullSafe(GHEventsSubscriber.java:134)
      	at org.jenkinsci.plugins.github.extension.GHEventsSubscriber$4.applyNullSafe(GHEventsSubscriber.java:130)
      	at org.jenkinsci.plugins.github.util.misc.NullSafeFunction.apply(NullSafeFunction.java:18)
      	at com.google.common.collect.Iterators$8.next(Iterators.java:812)
      	at com.google.common.collect.Lists.newArrayList(Lists.java:139)
      	at com.google.common.collect.Lists.newArrayList(Lists.java:119)
      	at org.jenkinsci.plugins.github.util.FluentIterableWrapper.toList(FluentIterableWrapper.java:137)
      	at com.cloudbees.jenkins.GitHubWebHook.doIndex(GitHubWebHook.java:96)
      

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/github/webhook/subscriber/PingGHEventSubscriber.java
            src/test/java/org/jenkinsci/plugins/github/webhook/subscriber/PingGHEventSubscriberTest.java
            src/test/resources/com/cloudbees/jenkins/GitHubWebHookFullTest/payloads/orgping.json
            http://jenkins-ci.org/commit/github-plugin/03b1c879698eb76c8348b7e8b3514f1c9fb7ad41
            Log:
            [FIXED JENKINS-30626] Handle pings from organization webhooks

            Closes #89

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/github/webhook/subscriber/PingGHEventSubscriber.java src/test/java/org/jenkinsci/plugins/github/webhook/subscriber/PingGHEventSubscriberTest.java src/test/resources/com/cloudbees/jenkins/GitHubWebHookFullTest/payloads/orgping.json http://jenkins-ci.org/commit/github-plugin/03b1c879698eb76c8348b7e8b3514f1c9fb7ad41 Log: [FIXED JENKINS-30626] Handle pings from organization webhooks Closes #89

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: