Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30777

ConsoleLogFilter isn't truly global

    Details

    • Similar Issues:

      Description

      Workflow does not honor global ConsoleLogFilter extensions.

      This prevents a plugin from automatically intercepting all the log processing. This is useful for example if your company runs fluentd, logstash, or any other centralized log aggregation service.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/console/ConsoleLogFilter.java
            core/src/main/java/hudson/model/Run.java
            http://jenkins-ci.org/commit/jenkins/36eea3dccfd75c76c22092878de30866956f3ebf
            Log:
            JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/console/ConsoleLogFilter.java core/src/main/java/hudson/model/Run.java http://jenkins-ci.org/commit/jenkins/36eea3dccfd75c76c22092878de30866956f3ebf Log: JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/console/ConsoleLogFilter.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            test/src/test/java/hudson/console/ConsoleLogFilterTest.java
            http://jenkins-ci.org/commit/jenkins/4c4367113fff8fd9388ac3659504177aedd32f33
            Log:
            JENKINS-30777 also allow slaves to decorate logger

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/console/ConsoleLogFilter.java core/src/main/java/hudson/slaves/SlaveComputer.java test/src/test/java/hudson/console/ConsoleLogFilterTest.java http://jenkins-ci.org/commit/jenkins/4c4367113fff8fd9388ac3659504177aedd32f33 Log: JENKINS-30777 also allow slaves to decorate logger
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/5e2b154261180e1fec4afdd4861dc82cc264a552
            Log:
            [FIXED JENKINS-30777] this concludes the fix

            Compare: https://github.com/jenkinsci/jenkins/compare/ba93862659b2...5e2b15426118

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/5e2b154261180e1fec4afdd4861dc82cc264a552 Log: [FIXED JENKINS-30777] this concludes the fix Compare: https://github.com/jenkinsci/jenkins/compare/ba93862659b2...5e2b15426118
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4299
            JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild. (Revision 36eea3dccfd75c76c22092878de30866956f3ebf)
            JENKINS-30777 also allow slaves to decorate logger (Revision 4c4367113fff8fd9388ac3659504177aedd32f33)
            [FIXED JENKINS-30777] this concludes the fix (Revision 5e2b154261180e1fec4afdd4861dc82cc264a552)

            Result = UNSTABLE
            kohsuke : 36eea3dccfd75c76c22092878de30866956f3ebf
            Files :

            • core/src/main/java/hudson/model/Run.java
            • core/src/main/java/hudson/console/ConsoleLogFilter.java

            kohsuke : 4c4367113fff8fd9388ac3659504177aedd32f33
            Files :

            • core/src/main/java/hudson/console/ConsoleLogFilter.java
            • test/src/test/java/hudson/console/ConsoleLogFilterTest.java
            • core/src/main/java/hudson/slaves/SlaveComputer.java

            kohsuke : 5e2b154261180e1fec4afdd4861dc82cc264a552
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4299 JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild. (Revision 36eea3dccfd75c76c22092878de30866956f3ebf) JENKINS-30777 also allow slaves to decorate logger (Revision 4c4367113fff8fd9388ac3659504177aedd32f33) [FIXED JENKINS-30777] this concludes the fix (Revision 5e2b154261180e1fec4afdd4861dc82cc264a552) Result = UNSTABLE kohsuke : 36eea3dccfd75c76c22092878de30866956f3ebf Files : core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/console/ConsoleLogFilter.java kohsuke : 4c4367113fff8fd9388ac3659504177aedd32f33 Files : core/src/main/java/hudson/console/ConsoleLogFilter.java test/src/test/java/hudson/console/ConsoleLogFilterTest.java core/src/main/java/hudson/slaves/SlaveComputer.java kohsuke : 5e2b154261180e1fec4afdd4861dc82cc264a552 Files : changelog.html
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            changelog.html
            core/src/main/java/hudson/Util.java
            core/src/main/java/hudson/console/ConsoleLogFilter.java
            core/src/main/java/hudson/model/Label.java
            core/src/main/java/hudson/model/Queue.java
            core/src/main/java/hudson/model/Run.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            core/src/main/java/hudson/tasks/BuildWrappers.java
            core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
            core/src/main/resources/lib/layout/task.jelly
            core/src/test/java/hudson/FilePathTest.java
            core/src/test/java/hudson/LauncherTest.java
            core/src/test/java/hudson/util/IsOverriddenTest.java
            core/src/test/java/hudson/util/ProcessTreeTest.java
            test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
            test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy
            test/src/test/java/hudson/console/ConsoleLogFilterTest.java
            test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
            test/src/test/java/hudson/model/NodeTest.java
            test/src/test/java/hudson/model/QueueTest.java
            test/src/test/java/hudson/slaves/DummyCloudImpl.java
            test/src/test/java/hudson/slaves/JNLPLauncherTest.java
            test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java
            test/src/test/java/hudson/tasks/ShellTest.java
            test/src/test/java/hudson/tools/JDKInstallerTest.java
            test/src/test/java/hudson/util/ProcessTreeKillerTest.java
            test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
            http://jenkins-ci.org/commit/jenkins/955eb7274a02e3549493cd2e1e0de785a0893784
            Log:
            Merge branch 'master' into plugin-manager-dependants

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html core/src/main/java/hudson/Util.java core/src/main/java/hudson/console/ConsoleLogFilter.java core/src/main/java/hudson/model/Label.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/hudson/tasks/BuildWrappers.java core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java core/src/main/resources/lib/layout/task.jelly core/src/test/java/hudson/FilePathTest.java core/src/test/java/hudson/LauncherTest.java core/src/test/java/hudson/util/IsOverriddenTest.java core/src/test/java/hudson/util/ProcessTreeTest.java test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/groovy/jenkins/model/PeepholePermalinkTest.groovy test/src/test/java/hudson/console/ConsoleLogFilterTest.java test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java test/src/test/java/hudson/model/NodeTest.java test/src/test/java/hudson/model/QueueTest.java test/src/test/java/hudson/slaves/DummyCloudImpl.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java test/src/test/java/hudson/tasks/ShellTest.java test/src/test/java/hudson/tools/JDKInstallerTest.java test/src/test/java/hudson/util/ProcessTreeKillerTest.java test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java http://jenkins-ci.org/commit/jenkins/955eb7274a02e3549493cd2e1e0de785a0893784 Log: Merge branch 'master' into plugin-manager-dependants master: (58 commits) Changelog: Replace the PR reference by the JIRA issue reference Noting https://github.com/jenkinsci/jenkins/pull/1818 Noting https://github.com/jenkinsci/jenkins/pull/1804 JENKINS-30002 Improve Util.isOverridden Noting #1842 [FIXED JENKINS-30777] this concludes the fix JENKINS-30777 also allow slaves to decorate logger JENKINS-30777 Generalized the signature to work with Run, not just AbstractBuild. Diamond operator [FIXED JENKINS-29876] CheckForNull job in ReverseBuildTrigger Noting JENKINS-30084 in changelog JENKINS-30084 remove extra space JENKINS-30084 address feedbacks JENKINS-30084 indent back JENKINS-30084 fixing test JENKINS-30084 fixing test JENKINS-30084 enhancing test case JENKINS-30084 test added to make sure a flyweight task can be blocked at last minute JENKINS-30084 fix regression when flyweight task is blocked by upstream/downstream project JENKINS-30084 some more polish ...
            Hide
            jglick Jesse Glick added a comment -

            Whether this is actually “Fixed” is dubious: no test was added, no linked PR showed an implementation, and the new signature is never called. Anyway it is unlikely that this is the extension point we would have wanted for the stated use case to begin with (there might be others).

            Show
            jglick Jesse Glick added a comment - Whether this is actually “Fixed” is dubious: no test was added, no linked PR showed an implementation, and the new signature is never called. Anyway it is unlikely that this is the extension point we would have wanted for the stated use case to begin with (there might be others).
            Hide
            jglick Jesse Glick added a comment -

            And I am unable to find a single example of a ConsoleLogFilter actually registered as an @Extension anywhere.

            Show
            jglick Jesse Glick added a comment - And I am unable to find a single example of a ConsoleLogFilter actually registered as an @Extension anywhere.
            Hide
            jglick Jesse Glick added a comment -

            The extension index shows no genuine extensions, only implementations used from BuildWrapper. This search turns up only ConsoleLogFilterTest, which anyway annotates Computer not Run. So this appears to be an unused API, unless there are private implementations out there somewhere.

            Show
            jglick Jesse Glick added a comment - The extension index shows no genuine extensions, only implementations used from BuildWrapper . This search turns up only ConsoleLogFilterTest , which anyway annotates Computer not Run . So this appears to be an unused API, unless there are private implementations out there somewhere.

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: