Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31129

Avoid gratuitous folder recomputation after saves

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently scheduleBuild is called from every save, but this is no good since that is called from onDeleted—so a child, once deleted, can get triggered in a zombie mode, leading to bizarre bugs.

      Probably should limit automatic build scheduling to a UI configSubmit and perhaps some other selected conditions.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
            http://jenkins-ci.org/commit/workflow-plugin/6fa8d48d5e8bc04cc91f3bbce662236b2ddc75c5
            Log:
            JENKINS-31129 Adapting test to behavioral change.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-plugin/6fa8d48d5e8bc04cc91f3bbce662236b2ddc75c5 Log: JENKINS-31129 Adapting test to behavioral change.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
            http://jenkins-ci.org/commit/workflow-plugin/120f065d34b8b5ec7207a06db44d44148bb52622
            Log:
            Merge pull request #240 from jglick/schedule-on-submit-JENKINS-31129

            JENKINS-31129 Adapting test to behavioral change

            Compare: https://github.com/jenkinsci/workflow-plugin/compare/051aeba3ce9f...120f065d34b8

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-plugin/120f065d34b8b5ec7207a06db44d44148bb52622 Log: Merge pull request #240 from jglick/schedule-on-submit- JENKINS-31129 JENKINS-31129 Adapting test to behavioral change Compare: https://github.com/jenkinsci/workflow-plugin/compare/051aeba3ce9f...120f065d34b8
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/105136286a3d0d9338c5215faddbb8faba8e794b
            Log:
            [FIXED JENKINS-31129] Call scheduleBuild only after doConfigSubmit, not any save.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/105136286a3d0d9338c5215faddbb8faba8e794b Log: [FIXED JENKINS-31129] Call scheduleBuild only after doConfigSubmit, not any save.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java
            src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/9cbe993366137de106dbab2cfb7dfc51433324c8
            Log:
            Merge pull request #23 from jglick/schedule-on-submit-JENKINS-31129

            JENKINS-31129 Call scheduleBuild only after doConfigSubmit, not any save

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/725e2c0a8177...9cbe99336613

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/AbstractFolder.java src/main/java/com/cloudbees/hudson/plugins/folder/computed/ComputedFolder.java http://jenkins-ci.org/commit/cloudbees-folder-plugin/9cbe993366137de106dbab2cfb7dfc51433324c8 Log: Merge pull request #23 from jglick/schedule-on-submit- JENKINS-31129 JENKINS-31129 Call scheduleBuild only after doConfigSubmit, not any save Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/725e2c0a8177...9cbe99336613
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/b3024f9b1af1dd6663909502f25b9fce37421ce7
            Log:
            JENKINS-31129 Adapting test to behavioral change.
            Originally-Committed-As: 6fa8d48d5e8bc04cc91f3bbce662236b2ddc75c5

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/b3024f9b1af1dd6663909502f25b9fce37421ce7 Log: JENKINS-31129 Adapting test to behavioral change. Originally-Committed-As: 6fa8d48d5e8bc04cc91f3bbce662236b2ddc75c5
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            multibranch/pom.xml
            multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java
            http://jenkins-ci.org/commit/workflow-multibranch-plugin/cc4ba65fc1b97a6e3bcfe5d4d88a806381168dfe
            Log:
            Merge pull request #240 from jglick/schedule-on-submit-JENKINS-31129

            JENKINS-31129 Adapting test to behavioral change
            Originally-Committed-As: 120f065d34b8b5ec7207a06db44d44148bb52622

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: multibranch/pom.xml multibranch/src/test/java/org/jenkinsci/plugins/workflow/multibranch/WorkflowMultiBranchProjectFactoryTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/cc4ba65fc1b97a6e3bcfe5d4d88a806381168dfe Log: Merge pull request #240 from jglick/schedule-on-submit- JENKINS-31129 JENKINS-31129 Adapting test to behavioral change Originally-Committed-As: 120f065d34b8b5ec7207a06db44d44148bb52622

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: