Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31159

Release post build steps for Matrix project cannot be set from UI

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Assigning release build steps to After failed or successful release build and all matrix configurations is impossible from Jelly UI because of code duplication in src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly 2.5.3:

      Line 105

      		    <!-- Post build steps -->
      		    <label class="attach-previous">${%After failed or successful release build}</label>
      		    <f:hetero-list name="postBuildSteps" hasHeader="true"
      		             descriptors="${h2.getBuildSteps(it)}"
      		             items="${instance.postBuildSteps}"
      		             addCaption="${%Add release step}"/>
      

      is duplicated at line 160:

      		    <!-- Post build steps -->
      		    <label class="attach-previous">${%After failed or successful release build and all matrix configurations}</label>
      		    <f:hetero-list name="postBuildSteps" hasHeader="true"
      		             descriptors="${h2.getBuildSteps(it)}"
      		             items="${instance.postBuildSteps}"
      		             addCaption="${%Add release step}"/>
      

      whereas it should use postMatrixBuildSteps instead of postBuildSteps.

      This results in the post build steps steps to be duplicated each time the page is saved.

      The only workaround is NOT to rely on Jenkins Jelly UI to configure such job (XML editing / Jenkins API).

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Fiouz
          Path:
          src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly
          src/test/java/hudson/plugins/release/TestReleasePluginMatrixJob.java
          http://jenkins-ci.org/commit/release-plugin/a648f5dd4f04109337e215a1072d7a2b07c3c7f6
          Log:
          JENKINS-31159 Fix postMatrixBuildSteps

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fiouz Path: src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly src/test/java/hudson/plugins/release/TestReleasePluginMatrixJob.java http://jenkins-ci.org/commit/release-plugin/a648f5dd4f04109337e215a1072d7a2b07c3c7f6 Log: JENKINS-31159 Fix postMatrixBuildSteps
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bulat Shakirzyanov
          Path:
          src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly
          src/test/java/hudson/plugins/release/TestReleasePluginMatrixJob.java
          http://jenkins-ci.org/commit/release-plugin/796f8c50cc766e4ac1c91a5b67820e0cb1fc4379
          Log:
          Merge pull request #13 from Fiouz/JENKINS-31159

          JENKINS-31159 Fix postMatrixBuildSteps

          Compare: https://github.com/jenkinsci/release-plugin/compare/9f80451aa1c6...796f8c50cc76

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bulat Shakirzyanov Path: src/main/resources/hudson/plugins/release/ReleaseWrapper/config.jelly src/test/java/hudson/plugins/release/TestReleasePluginMatrixJob.java http://jenkins-ci.org/commit/release-plugin/796f8c50cc766e4ac1c91a5b67820e0cb1fc4379 Log: Merge pull request #13 from Fiouz/ JENKINS-31159 JENKINS-31159 Fix postMatrixBuildSteps Compare: https://github.com/jenkinsci/release-plugin/compare/9f80451aa1c6...796f8c50cc76
          Hide
          fchuong Frédéric Chuong added a comment -

          Thanks for accepting the pull request, the problem is now gone with 2.5.4.

          Show
          fchuong Frédéric Chuong added a comment - Thanks for accepting the pull request, the problem is now gone with 2.5.4 .

            People

            • Assignee:
              petehayes Peter Hayes
              Reporter:
              fchuong Frédéric Chuong
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: