Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31344

Allow users to clear out individual approved signatures from the UI

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Duplicate
    • Component/s: script-security-plugin
    • Labels:
    • Environment:
      workflow-1.10.1
      FreeBSD 10.2
      Jenkins 1.635
      OpenJDK 1.8.0_60-b24
    • Similar Issues:

      Description

      Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures with a "Clear Approvals" button (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

      This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

      https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java

        Attachments

          Issue Links

            Activity

            ganthore Mark Austin created issue -
            ganthore Mark Austin made changes -
            Field Original Value New Value
            Description Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures "Clear Approvals" (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

            This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

            https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java#L142
            Larger installations may have a lot of approved signatures and the current UI only allows one to clear all signatures with a "Clear Approvals" button (see screen shot below). It would be nice if the UI would allow one to clear individual signatures. A base example would be if the user accidentally approved System.exit but does not want that to run!

            This seems like a matter of reversing the way things are hashed in the below code and adding it as a new function that is called by a button from the UI?

            https://github.com/jenkinsci/script-security-plugin/blob/master/src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptApproval.java
            jglick Jesse Glick made changes -
            Component/s script-security-plugin [ 18520 ]
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Labels ui
            jglick Jesse Glick made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            jglick Jesse Glick made changes -
            Link This issue duplicates JENKINS-22660 [ JENKINS-22660 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Duplicate [ 3 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 166632 ] JNJira + In-Review [ 198022 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                ganthore Mark Austin
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: