Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31356

Re-execute promotion renders white page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: promoted-builds-plugin
    • Labels:
      None
    • Environment:
      Windows 2008 master, with Core 1.609.3 or higher, Plugin version 2.19+
    • Similar Issues:

      Description

      We have experiencing a Re-execute promotion white page issue since version 2.19. The latest version still has the issue as well. We had to patch 2.19 ourselves, but it requires a lot of work to re-patch the latest plugin if we want to upgrade.

      We use Active Directory for authenticating users to Jenkins. If we set up a promotion in a job, and grant an Active Directory group access as “Approvers", they can easily see the approve button. Clicking the approve button works fine. After the promotion, a re-execute promotion button appears. Clicking the button renders a white page, even if the user is logged in.

      If we "Enable project-based security” on the job, and add the Active Directory group in there, with the “Promotion” box checked, the re-execute button works just fine. However, they then see a “Force Promotion” button next to each of the promotions, even ones they should not have access to.

      If possible, please fix the re-execute promotion for promotions where the group or user is not part of the "Enable project-based security” listing?

      Thank you.

        Attachments

          Activity

          Hide
          shinstudio shane kim added a comment -
          Show
          shinstudio shane kim added a comment - Made a pull request for the issue. https://github.com/jenkinsci/promoted-builds-plugin/pull/70
          Show
          shinstudio shane kim added a comment - https://github.com/shinstudio/promoted-builds-plugin/commit/edc921cf4fbf74e1cc689eca0dba527fe9f7f0d1
          Hide
          jurgens00 jurgezero added a comment -

          Any update on the pull request?

          Show
          jurgens00 jurgezero added a comment - Any update on the pull request?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Shane Kim
          Path:
          src/main/java/hudson/plugins/promoted_builds/Status.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/edc921cf4fbf74e1cc689eca0dba527fe9f7f0d1
          Log:
          JENKINS-31356 Manual condition and re-execute promotion bug. doBuild checked an user for only project permission level when it had to check the approver list as well

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Shane Kim Path: src/main/java/hudson/plugins/promoted_builds/Status.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java http://jenkins-ci.org/commit/promoted-builds-plugin/edc921cf4fbf74e1cc689eca0dba527fe9f7f0d1 Log: JENKINS-31356 Manual condition and re-execute promotion bug. doBuild checked an user for only project permission level when it had to check the approver list as well
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/plugins/promoted_builds/Status.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/069d9fd258ecf89377738c571589bb8bee6ae68e
          Log:
          Merge pull request #70 from shinstudio/master

          JENKINS-31356 Manual condition and re-execute promotion bug.

          Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/e62fc4bb49e7...069d9fd258ec

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/promoted_builds/Status.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java http://jenkins-ci.org/commit/promoted-builds-plugin/069d9fd258ecf89377738c571589bb8bee6ae68e Log: Merge pull request #70 from shinstudio/master JENKINS-31356 Manual condition and re-execute promotion bug. Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/e62fc4bb49e7...069d9fd258ec
          Hide
          shinstudio shane kim added a comment -

          The pull request was merged into the master.

          Show
          shinstudio shane kim added a comment - The pull request was merged into the master.

            People

            • Assignee:
              shinstudio shane kim
              Reporter:
              jurgens00 jurgezero
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: