Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31421

Show the number of duplicate lines in the graph

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: dry-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      It would be very useful if the DRY plugin graph showed the total number of duplicate lines.

      The IMHO the number of duplicate lines is a much better indicator of the amount of duplicate code than the number of issues.

      Thanks!

        Attachments

          Activity

          Hide
          drulli Ulli Hafner added a comment - - edited

          I think it would be more useful if both options are available: number of issues and number of lines. I.e. a new graph needs to be created.

          Interested in developing such a graph class? An example is available in the findbugs plug-in. Or the original Graph is in class PriorityGraph.

          Show
          drulli Ulli Hafner added a comment - - edited I think it would be more useful if both options are available: number of issues and number of lines. I.e. a new graph needs to be created. Interested in developing such a graph class? An example is available in the findbugs plug-in . Or the original Graph is in class PriorityGraph .
          Hide
          drulli Ulli Hafner added a comment -

          Can you please also add some details: what should be shown in the graph? Just a line graph, an area graph, etc. which colors, etc.

          Show
          drulli Ulli Hafner added a comment - Can you please also add some details: what should be shown in the graph? Just a line graph, an area graph, etc. which colors, etc.
          Hide
          pepperino Chris Pepper added a comment -

          Sorry, I didn't see your comment. I think the plugin should just have an option that instead of the number of issues, the number of total duplicate lines is used. The type of graph can be the same as before. In the "Duplicate code" details page in could be the same, instead of showing the number of issues per file/folder it would show the number of lines of duplicate code.

          I don't have time for developing this at the moment, sorry. I just thought I'd make to comment as it would be nice to have.

          Show
          pepperino Chris Pepper added a comment - Sorry, I didn't see your comment. I think the plugin should just have an option that instead of the number of issues, the number of total duplicate lines is used. The type of graph can be the same as before. In the "Duplicate code" details page in could be the same, instead of showing the number of issues per file/folder it would show the number of lines of duplicate code. I don't have time for developing this at the moment, sorry. I just thought I'd make to comment as it would be nice to have.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/dry/DryProjectAction.java
          src/main/java/hudson/plugins/dry/DryResult.java
          src/main/java/hudson/plugins/dry/DuplicatedLinesGraph.java
          src/main/resources/hudson/plugins/dry/Messages.properties
          src/main/resources/hudson/plugins/dry/Messages_de.properties
          http://jenkins-ci.org/commit/dry-plugin/4ea956f667a9cf21669af7765fce90d1e62fc8cd
          Log:
          [FIXED JENKINS-31421] Added a new graph that shows the number of duplicated lines.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/dry/DryProjectAction.java src/main/java/hudson/plugins/dry/DryResult.java src/main/java/hudson/plugins/dry/DuplicatedLinesGraph.java src/main/resources/hudson/plugins/dry/Messages.properties src/main/resources/hudson/plugins/dry/Messages_de.properties http://jenkins-ci.org/commit/dry-plugin/4ea956f667a9cf21669af7765fce90d1e62fc8cd Log: [FIXED JENKINS-31421] Added a new graph that shows the number of duplicated lines.
          Hide
          pepperino Chris Pepper added a comment -

          Thanks! I'll give it a try

          Show
          pepperino Chris Pepper added a comment - Thanks! I'll give it a try
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/graph/CategoryBuildResultGraph.java
          src/main/resources/hudson/plugins/analysis/Messages.properties
          src/main/resources/hudson/plugins/analysis/Messages_de.properties
          http://jenkins-ci.org/commit/analysis-core-plugin/0055ce33cf28710424ac0518216c0ab05de9ad22
          Log:
          JENKINS-31421 Make y-axis label configurable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/graph/CategoryBuildResultGraph.java src/main/resources/hudson/plugins/analysis/Messages.properties src/main/resources/hudson/plugins/analysis/Messages_de.properties http://jenkins-ci.org/commit/analysis-core-plugin/0055ce33cf28710424ac0518216c0ab05de9ad22 Log: JENKINS-31421 Make y-axis label configurable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          dry.iml
          pom.xml
          src/main/java/hudson/plugins/dry/DuplicatedLinesGraph.java
          src/main/resources/hudson/plugins/dry/Messages.properties
          src/main/resources/hudson/plugins/dry/Messages_de.properties
          http://jenkins-ci.org/commit/dry-plugin/c1f829813a7d02586b4c28ce7c64ecfc3c731b7f
          Log:
          JENKINS-31421 Make y-axis label configurable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: dry.iml pom.xml src/main/java/hudson/plugins/dry/DuplicatedLinesGraph.java src/main/resources/hudson/plugins/dry/Messages.properties src/main/resources/hudson/plugins/dry/Messages_de.properties http://jenkins-ci.org/commit/dry-plugin/c1f829813a7d02586b4c28ce7c64ecfc3c731b7f Log: JENKINS-31421 Make y-axis label configurable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          analysis-core
          dry
          http://jenkins-ci.org/commit/analysis-suite-plugin/84b8f340264fd1eac25cde51f3e1a43afad7346e
          Log:
          JENKINS-31421 Make y-axis label configurable.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: analysis-core dry http://jenkins-ci.org/commit/analysis-suite-plugin/84b8f340264fd1eac25cde51f3e1a43afad7346e Log: JENKINS-31421 Make y-axis label configurable.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              pepperino Chris Pepper
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: