Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31511

Recent (since 1.628) bug introduced into pluginManager filter UI

    Details

    • Similar Issues:

      Description

      Jenkins was, on typing characters into the filter section of the plugin window, filtering results, it no longer works as expected. Attached are screenshots for 1.628 and 1.638 for comparison. Note the filter string of "OWA" is reflected in 1.628, the other screenshot is 1.638 (version number is scrolled off the screen).

        Attachments

          Activity

          Hide
          csimons Christopher Simons added a comment - - edited

          Verified bug exists from Chrome in 46.0.2490.80 (Linux 64-bit) on repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'.

          When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab. When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term.

          Results of git-bisect debugging:

          3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit
          commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195
          Author: tfennelly <tom.fennelly@gmail.com>
          Date:   Fri Sep 25 12:22:46 2015 +0100
          
              Only allow disable or uninstall when all dependants or dependencies are disabled/enabled
          
          Show
          csimons Christopher Simons added a comment - - edited Verified bug exists from Chrome in 46.0.2490.80 (Linux 64-bit) on repository tag 'jenkins-1.638' but does not exist on tag 'jenkins-1.628'. When testing, note that the search does not seem to be broken on the default tab, but is broken on the "Installed" tab. When entering a search term, the list results do seem to change sometimes, but more results are returned than are warranted by the search term. Results of git-bisect debugging: 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 is the first bad commit commit 3b5424e507be2e59eabfd3f55ce16cd2b58a6195 Author: tfennelly <tom.fennelly@gmail.com> Date: Fri Sep 25 12:22:46 2015 +0100 Only allow disable or uninstall when all dependants or dependencies are disabled/enabled
          Hide
          danielbeck Daniel Beck added a comment -

          Christopher Simons Are you planning to work on this as you assigned yourself?

          Show
          danielbeck Daniel Beck added a comment - Christopher Simons Are you planning to work on this as you assigned yourself?
          Hide
          csimons Christopher Simons added a comment - - edited

          Daniel Beck Initially I planned to fix this but have since gotten sidetracked by other demands. I've unassigned this.

          Show
          csimons Christopher Simons added a comment - - edited Daniel Beck Initially I planned to fix this but have since gotten sidetracked by other demands. I've unassigned this.
          Hide
          danielbeck Daniel Beck added a comment -

          This is funny – the filtering actually works, but it also considers plugins that have an (explicit or implied) dependency on any plugin with that name. In the case of OWASP Markup Formatter Plugin, this is (due to how dependencies to detached-from-core plugins work and when this one was detached from core) almost every plugin. If you filter for a string that does not match any plugin that has been detached from core (mostly what Jenkins came bundled with), it works as expected.

          Not sure whether this is deliberate. Pinging Tom FENNELLY to shed some light on this.

          Show
          danielbeck Daniel Beck added a comment - This is funny – the filtering actually works, but it also considers plugins that have an (explicit or implied) dependency on any plugin with that name. In the case of OWASP Markup Formatter Plugin, this is (due to how dependencies to detached-from-core plugins work and when this one was detached from core) almost every plugin. If you filter for a string that does not match any plugin that has been detached from core (mostly what Jenkins came bundled with), it works as expected. Not sure whether this is deliberate. Pinging Tom FENNELLY to shed some light on this.
          Hide
          danielbeck Daniel Beck added a comment -

          The behavior remains; with recent plugin releases more easily observable when typing command-launcher as that has been detached from core fairly recently.

          Show
          danielbeck Daniel Beck added a comment - The behavior remains; with recent plugin releases more easily observable when typing command-launcher as that has been detached from core fairly recently.
          Hide
          danielbeck Daniel Beck added a comment - - edited

          applyFilter in PluginManager/_table.js does not handle the fact that each row has hidden divs containing the plugin dependency information in span}}s. So it's not as trivial as just {{innerHTML.

          Show
          danielbeck Daniel Beck added a comment - - edited applyFilter in  PluginManager/_table.js does not handle the fact that each row has hidden divs containing the plugin dependency information in span}}s. So it's not as trivial as just {{innerHTML .

            People

            • Assignee:
              Unassigned
              Reporter:
              ronabop Ronald Gundlach-Chmara
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: