Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31908

Promotions History sort in a job is wrong

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: promoted-builds-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.639, Promoted Builds plugin 2.24
    • Similar Issues:

      Description

      In the "Job's Promotion History", the promotions are sorted alphabetically according to their ids (e.g. #42). It should be sorted chronologically (using the Number instead of the Id for example).

      The last promoted build is also wrong since it sorts the list before taking the last item.

        Attachments

          Activity

          Show
          oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/promoted-builds-plugin/pull/78
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Benjamin Baumann
          Path:
          src/main/java/hudson/plugins/promoted_builds/Promotion.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/13c3a197ffdc3e3a241b96ed75d8ca95cabc5833
          Log:
          Sort Promotion By Number

          Instead of sorting promotions by id (e.g. #42), sorts promotions by number (e.g. 42). Fixes the display of the promotion list history for a job.
          [FIXED JENKINS-31908]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Benjamin Baumann Path: src/main/java/hudson/plugins/promoted_builds/Promotion.java http://jenkins-ci.org/commit/promoted-builds-plugin/13c3a197ffdc3e3a241b96ed75d8ca95cabc5833 Log: Sort Promotion By Number Instead of sorting promotions by id (e.g. #42), sorts promotions by number (e.g. 42). Fixes the display of the promotion list history for a job. [FIXED JENKINS-31908]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/hudson/plugins/promoted_builds/Promotion.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/b2ca190613909df2b44e27062ff1b4b066620a74
          Log:
          Merge pull request #78 from bbaumann/master

          [FIXED JENKINS-31908] - Sort Promotion By Number

          Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/66e9432878c1...b2ca19061390

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/plugins/promoted_builds/Promotion.java http://jenkins-ci.org/commit/promoted-builds-plugin/b2ca190613909df2b44e27062ff1b4b066620a74 Log: Merge pull request #78 from bbaumann/master [FIXED JENKINS-31908] - Sort Promotion By Number Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/66e9432878c1...b2ca19061390

            People

            • Assignee:
              bbaumann Benjamin Baumann
              Reporter:
              bbaumann Benjamin Baumann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: