Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31932

Performance regression after fixing synchronization issue when setting JDK installations. (issue 28292)

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      Ubuntu 14.04.1 LTS 64bit
      Jenkins ver. 1.625.2
      Java(TM) SE Runtime Environment (build 1.7.0_76-b13)
    • Similar Issues:

      Description

      The fix for JENKINS-28292 included in 1.618 is causing performance
      issues - requests are hanging on Jenkins.getJDKs for a very long time
      (sometimes minutes). This does happen on 2 of our Jenkins instances and can be observed at least few times per day by different users. I don't have a thread dump available but I'll try to get it for reference.

        Attachments

          Issue Links

            Activity

            lkarnasiewicz Lukasz Karnasiewicz created issue -
            lkarnasiewicz Lukasz Karnasiewicz made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            lkarnasiewicz Lukasz Karnasiewicz made changes -
            Environment Ubuntu 14.04.1 LTS 64bit
            Jenkins ver. 1.625.2
            Java(TM) SE Runtime Environment (build 1.7.0_76-b13)
            Description The fix for JENKINS-28292 included in 1.618 is causing performance
            issues - requests are hanging on Jenkins.getJDKs for a very long time
            (sometimes minutes). This does happen at least a few times per day for
            every user. I don't have a thread dump available but I'll try to get it
            for reference.
            The fix for JENKINS-28292 included in 1.618 is causing performance
            issues - requests are hanging on Jenkins.getJDKs for a very long time
            (sometimes minutes). This does happen on 2 of our Jenkins instances and can be observed at least few times per day by different users. I don't have a thread dump available but I'll try to get it for reference.
            lkarnasiewicz Lukasz Karnasiewicz made changes -
            Link This issue is related to JENKINS-28292 [ JENKINS-28292 ]
            Show
            lkarnasiewicz Lukasz Karnasiewicz added a comment - Fix: https://github.com/jenkinsci/jenkins/pull/1947
            lkarnasiewicz Lukasz Karnasiewicz made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            danielbeck Daniel Beck made changes -
            Labels regression
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/9a239081e945f9b1d3076bec59266d01f0857f47
            Log:
            avoid synchronization for Jenkinsget/setJDKs, use a volatile field instead

            [FIXES JENKINS-31932]

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/9a239081e945f9b1d3076bec59266d01f0857f47 Log: avoid synchronization for Jenkinsget/setJDKs, use a volatile field instead [FIXES JENKINS-31932]
            scm_issue_link SCM/JIRA link daemon made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/0a5b03688ba6884429bb3d2a06be8b7955694420
            Log:
            Merge pull request #1971 from daspilker/JENKINS-31932

            JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs

            Compare: https://github.com/jenkinsci/jenkins/compare/3f7163207fd7...0a5b03688ba6

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/0a5b03688ba6884429bb3d2a06be8b7955694420 Log: Merge pull request #1971 from daspilker/ JENKINS-31932 JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs Compare: https://github.com/jenkinsci/jenkins/compare/3f7163207fd7...0a5b03688ba6
            danielbeck Daniel Beck made changes -
            Labels regression lts-candidate regression
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate regression 1.642.2-fixed regression
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/3be09ad1b4392a3a108c2c09abae3c554937b774
            Log:
            Merge pull request #1971 from daspilker/JENKINS-31932

            JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs
            (cherry picked from commit 0a5b03688ba6884429bb3d2a06be8b7955694420)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/3be09ad1b4392a3a108c2c09abae3c554937b774 Log: Merge pull request #1971 from daspilker/ JENKINS-31932 JENKINS-31932 avoid synchronization for Jenkinsget/setJDKs (cherry picked from commit 0a5b03688ba6884429bb3d2a06be8b7955694420)
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 167403 ] JNJira + In-Review [ 198181 ]

              People

              • Assignee:
                lkarnasiewicz Lukasz Karnasiewicz
                Reporter:
                lkarnasiewicz Lukasz Karnasiewicz
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: