Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-31967

Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Specifying 0.1 in Health report amplification factor will result in bad groovy:
      step([$class: 'JUnitResultArchiver', healthScaleFactor: <object of type java.lang.Double>, testResults: '**/target/surefire-reports/*.xml'])

      This'll happen with 20.0, 10.5, whatever - any decimal ends up showing up like this.

        Attachments

          Issue Links

            Activity

            abayer Andrew Bayer created issue -
            Hide
            jglick Jesse Glick added a comment -

            Means DescribableHelper and/or Snippetizer are not yet handling all primitive types. Should be an easy fix.

            Show
            jglick Jesse Glick added a comment - Means DescribableHelper and/or Snippetizer are not yet handling all primitive types. Should be an easy fix.
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Epic Link JENKINS-35393 [ 171186 ]
            jglick Jesse Glick made changes -
            Component/s structs-plugin [ 21442 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 167440 ] JNJira + In-Review [ 182732 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Component/s workflow-cps-plugin [ 21713 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-38004 [ JENKINS-38004 ]
            jglick Jesse Glick made changes -
            Link This issue is duplicated by JENKINS-40363 [ JENKINS-40363 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-40508 [ JENKINS-40508 ]
            Hide
            undera Andrey Pokhilko added a comment -

            Hi,

            Any hope this will be fixed soon? Looks pretty trivial to fix...

            Show
            undera Andrey Pokhilko added a comment - Hi, Any hope this will be fixed soon? Looks pretty trivial to fix...
            oleg_nenashev Oleg Nenashev made changes -
            Summary Specifying decimal numbers for JUnit health factor in Workflow snippets results in invalid code Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code
            oleg_nenashev Oleg Nenashev made changes -
            Labels newbie-friendly
            Show
            undera Andrey Pokhilko added a comment - https://github.com/jenkinsci/workflow-cps-plugin/pull/116  FYI
            Hide
            jglick Jesse Glick added a comment -

            That is only half the fix.

            Show
            jglick Jesse Glick added a comment - That is only half the fix.
            jglick Jesse Glick made changes -
            Remote Link This issue links to "structs PR 16 (Web Link)" [ 16911 ]
            jglick Jesse Glick made changes -
            Assignee Jesse Glick [ jglick ] Artem Fedorov [ artem_fedorov ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jglick Jesse Glick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            jglick Jesse Glick made changes -
            Remote Link This issue links to "workflow-cps PR 116 (Web Link)" [ 16912 ]
            Show
            artem_fedorov Artem Fedorov added a comment - Please, review this requests: https://github.com/jenkinsci/workflow-cps-plugin/pull/116 https://github.com/jenkinsci/structs-plugin/pull/16
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Artem Fedorov
            Path:
            plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java
            http://jenkins-ci.org/commit/structs-plugin/849c5dcb32f90488f2294d831ba378fc87f50231
            Log:
            fixed defaults for Java standard types

            https://issues.jenkins-ci.org/browse/JENKINS-31967

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Artem Fedorov Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java http://jenkins-ci.org/commit/structs-plugin/849c5dcb32f90488f2294d831ba378fc87f50231 Log: fixed defaults for Java standard types https://issues.jenkins-ci.org/browse/JENKINS-31967
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java
            plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
            http://jenkins-ci.org/commit/structs-plugin/5eaa47767082b8bc3a2e40447a111055b82a46bc
            Log:
            Merged #16: JENKINS-31967 Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code

            Compare: https://github.com/jenkinsci/structs-plugin/compare/8d0f4ad0109f...5eaa47767082

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java http://jenkins-ci.org/commit/structs-plugin/5eaa47767082b8bc3a2e40447a111055b82a46bc Log: Merged #16: JENKINS-31967 Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code Compare: https://github.com/jenkinsci/structs-plugin/compare/8d0f4ad0109f...5eaa47767082
            jglick Jesse Glick made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Artem Fedorov
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/bfc47a2598ae79110d41d036fcbbe7920305cbab
            Log:
            fixed exception with standard java types

            https://issues.jenkins-ci.org/browse/JENKINS-31967

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Artem Fedorov Path: src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java http://jenkins-ci.org/commit/workflow-cps-plugin/bfc47a2598ae79110d41d036fcbbe7920305cbab Log: fixed exception with standard java types https://issues.jenkins-ci.org/browse/JENKINS-31967
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/b48af161645f3a8d37c9d1219d5e65b94b5628bf
            Log:
            Merge pull request #116 from artem-fedorov/fix-supporting-java-standard-types

            JENKINS-31967 Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code

            Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/e3bad4b3494d...b48af161645f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/b48af161645f3a8d37c9d1219d5e65b94b5628bf Log: Merge pull request #116 from artem-fedorov/fix-supporting-java-standard-types JENKINS-31967 Specifying decimal numbers for JUnit health factor in Pipeline snippets results in invalid code Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/e3bad4b3494d...b48af161645f

              People

              • Assignee:
                artem_fedorov Artem Fedorov
                Reporter:
                abayer Andrew Bayer
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: