Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32476

Code Snippet Generator for 'step' should use class FQDN in case of collisions

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Some plugins use the same shortname for their build step class such as CheckStylePublisher with the CheckStyle Plugin (hudson.plugins.checkstyle.CheckStylePublisher) and the JSHint Plugin (hudson.plugins.jshint.CheckStylePublisher).

      The groovy code generated by the snipped generator is then invalid (see sample below).

      It would be nice if the snippet generator could generate a syntax with the fully qualified class name or if an error message could be displayed in the workflow editor.

      step([$class: 'CheckStylePublisher', pattern: '**/checkstyle-result.xml'])
      
      java.lang.UnsupportedOperationException: CheckStylePublisher as a interface jenkins.tasks.SimpleBuildStep could mean either hudson.plugins.jshint.CheckStylePublisher or hudson.plugins.checkstyle.CheckStylePublisher
      	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.coerce(DescribableHelper.java:226)
      	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.buildArguments(DescribableHelper.java:185)
      	at org.jenkinsci.plugins.workflow.structs.DescribableHelper.instantiate(DescribableHelper.java:91)
      	at org.jenkinsci.plugins.workflow.steps.StepDescriptor.newInstance(StepDescriptor.java:103)
      	at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:133)
      	at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:112)
      	...
      	at java.lang.Thread.run(Thread.java:745)
      

        Attachments

          Issue Links

            Activity

            cleclerc Cyrille Le Clerc created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Epic Link JENKINS-35393 [ 171186 ]
            jglick Jesse Glick made changes -
            Component/s structs-plugin [ 21442 ]
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Labels workflow
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 168112 ] JNJira + In-Review [ 182973 ]
            abayer Andrew Bayer made changes -
            Labels workflow pipeline workflow
            abayer Andrew Bayer made changes -
            Labels pipeline workflow pipeline
            Hide
            jglick Jesse Glick added a comment -

            Andrew Bayer forgot to search for duplicates before fixing I guess.

            Show
            jglick Jesse Glick added a comment - Andrew Bayer forgot to search for duplicates before fixing I guess.
            jglick Jesse Glick made changes -
            Link This issue duplicates JENKINS-43337 [ JENKINS-43337 ]
            jglick Jesse Glick made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Duplicate [ 3 ]

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                cleclerc Cyrille Le Clerc
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: