Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32623

Incorrect user URL for users with backslashes in name

    Details

    • Similar Issues:

      Description

      We authenticate with an Active Directory Forest and users log in with names such as "DOMAIN\user". When logged in the link to their user area in the top right is something like:
      http://<jenkins>/user/DOMAIN/user which gives a 404 error when clicked.

      Replacing the slash with an escape code
      http://<jenkins>/user/DOMAIN%2Fuser or
      http://<jenkins>/user/DOMAIN%5Cuser

      or using an underscore

      http://<jenkins>/user/DOMAIN_user

      works. The link to the users account should probably use one of these. I am not sure whether this is a problem in Jenkins core or the active directory plugin.

        Attachments

          Issue Links

            Activity

            rg Russell Gallop created issue -
            Hide
            rg Russell Gallop added a comment -

            Note the page source appears to have a backslash:

            <a class="model-link inside inverse" href="/user/DOMAIN\user"><b>User Name</b></a>
            

            Chrome (48.0.2564.82 64-bit) and IE (11.0.9600.18163) seem to "fix" this to be a slash. Firefox (43.0.1) doesn't fix it so works okay.

            Show
            rg Russell Gallop added a comment - Note the page source appears to have a backslash: <a class= "model-link inside inverse" href= "/user/DOMAIN\user" ><b>User Name</b></a> Chrome (48.0.2564.82 64-bit) and IE (11.0.9600.18163) seem to "fix" this to be a slash. Firefox (43.0.1) doesn't fix it so works okay.
            Hide
            rg Russell Gallop added a comment -

            I notice that the asynchPeople page correctly escapes the url to:
            user/domain%5Cuser

            Show
            rg Russell Gallop added a comment - I notice that the asynchPeople page correctly escapes the url to: user/domain%5Cuser
            Hide
            rg Russell Gallop added a comment -

            The "Started by user" message on the build page is not correctly escaped.

            Show
            rg Russell Gallop added a comment - The "Started by user" message on the build page is not correctly escaped.
            teilo James Nord made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-33304 [ JENKINS-33304 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 168280 ] JNJira + In-Review [ 183049 ]
            danielbeck Daniel Beck made changes -
            Assignee Daniel Beck [ danielbeck ]
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            danielbeck Daniel Beck made changes -
            Remote Link This issue links to "PR 3046 (Web Link)" [ 17778 ]
            Hide
            rg Russell Gallop added a comment -

            I may be wrong but it looks like https://github.com/jenkinsci/jenkins/pull/3046 fixes the "Started by user" message but not the originally reported issue which is the link on the main Jenkins page header bar (which I think is in core/src/main/resources/lib/layout/layout.jelly).

            Show
            rg Russell Gallop added a comment - I may be wrong but it looks like https://github.com/jenkinsci/jenkins/pull/3046  fixes the "Started by user" message but not the originally reported issue which is the link on the main Jenkins page header bar (which I think is in core/src/main/resources/lib/layout/layout.jelly).
            Hide
            danielbeck Daniel Beck added a comment -

            Russell Gallop Thanks, missed that after getting distracted by the comment.

            Show
            danielbeck Daniel Beck added a comment - Russell Gallop Thanks, missed that after getting distracted by the comment.
            Hide
            danielbeck Daniel Beck added a comment -

            Strictly speaking, that could just be /me, but that would be too easy

            Show
            danielbeck Daniel Beck added a comment - Strictly speaking, that could just be /me , but that would be too easy
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/model/Cause.java
            core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly
            core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_bg.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ca.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_cs.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_el.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_fi.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_he.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_hu.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_lt.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_lv.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_nb_NO.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_PT.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sk.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_tr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_uk.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_TW.properties
            http://jenkins-ci.org/commit/jenkins/08adfb9d12d628fd35571cdc9b9f1f8f9c8311c9
            Log:
            JENKINS-32623 Use real URL for user

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/Cause.java core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_bg.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ca.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_cs.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_el.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fi.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_he.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_hu.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_lt.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_lv.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nb_NO.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_PT.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sk.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_tr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_uk.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_TW.properties http://jenkins-ci.org/commit/jenkins/08adfb9d12d628fd35571cdc9b9f1f8f9c8311c9 Log: JENKINS-32623 Use real URL for user
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/lib/layout/layout.jelly
            http://jenkins-ci.org/commit/jenkins/4a524239efb0dee9754b710b17ae3293a5d59670
            Log:
            JENKINS-32623 Fix link to user profile in title

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/lib/layout/layout.jelly http://jenkins-ci.org/commit/jenkins/4a524239efb0dee9754b710b17ae3293a5d59670 Log: JENKINS-32623 Fix link to user profile in title
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/model/Cause.java
            core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly
            core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_bg.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ca.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_cs.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_el.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_fi.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_he.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_hu.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_lt.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_lv.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_nb_NO.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_PT.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sk.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_tr.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_uk.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties
            core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_TW.properties
            core/src/main/resources/lib/layout/layout.jelly
            http://jenkins-ci.org/commit/jenkins/4109c5b32780357e52d2154c8d3f82436408c1b8
            Log:
            Merge pull request #3046 from daniel-beck/JENKINS-32623

            JENKINS-32623 Use real URL for user

            Compare: https://github.com/jenkinsci/jenkins/compare/f3398eabbc25...4109c5b32780

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/model/Cause.java core/src/main/resources/hudson/model/Cause/UserIdCause/description.jelly core/src/main/resources/hudson/model/Cause/UserIdCause/description.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_bg.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ca.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_cs.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_da.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_de.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_el.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_es.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fi.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_fr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_he.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_hu.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_it.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ja.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ko.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_lt.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_lv.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nb_NO.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_nl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_BR.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_pt_PT.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_ru.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sk.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sl.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_sv_SE.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_tr.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_uk.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_CN.properties core/src/main/resources/hudson/model/Cause/UserIdCause/description_zh_TW.properties core/src/main/resources/lib/layout/layout.jelly http://jenkins-ci.org/commit/jenkins/4109c5b32780357e52d2154c8d3f82436408c1b8 Log: Merge pull request #3046 from daniel-beck/ JENKINS-32623 JENKINS-32623 Use real URL for user Compare: https://github.com/jenkinsci/jenkins/compare/f3398eabbc25...4109c5b32780
            Hide
            danielbeck Daniel Beck added a comment -

            Fixed towards 2.83.

            Show
            danielbeck Daniel Beck added a comment - Fixed towards 2.83.
            danielbeck Daniel Beck made changes -
            Status In Review [ 10005 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            danielbeck Daniel Beck made changes -
            Labels lts-candidate
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-32844 [ JENKINS-32844 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate
            teilo James Nord made changes -
            Link This issue is duplicated by JENKINS-46848 [ JENKINS-46848 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CJP-7987 (Web Link)" [ 18964 ]

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                rg Russell Gallop
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: