Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32785

Deprecate listview -> columns -> lastBuildNode() to generate a new config

    Details

    • Similar Issues:

      Description

      listView -> columns -> lastBuildNode() warns about build-node-column-plugin which is deprecated.

      From a discussion on the mailing list: https://groups.google.com/d/topic/job-dsl-plugin/xYnd1p2a7VI/discussion

      I wrote:
      I am using listView -> columns -> lastBuildNode() and receive the following warning when I run my example:

      Warning: (script, line 65) version 0.1 or later of plugin 'build-node-column' needs to be installed

      This plugin however is deprecated and on GitHub they state that the extra-columns-plugin should be used instead.

      I would welcome if the Job DSL plugin would not require deprecated libraries but am unsure how to contribute.

      Can the code be updated to "require" the build-node-column plugin instead? If so, how to find out what version is the minimum?

      Daniel answered:

      [...] The problem is that we use the @RequiresPlugin annotation in the DSL to specify which plugin provides the config and that annotation can not express "plugin A or plugin B". And to keep compatibility we can't just change the existing method to generate the new config only. The best option would be to deprecate the existing lastBuildNode method and to add a new lastBuildNode2 (or whatever) method which will then generate the new config. Please file a JIRA issue [...]

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            docs/Home.md
            docs/Migration.md
            job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/views/ColumnsContext.groovy
            job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/views/ListViewSpec.groovy
            http://jenkins-ci.org/commit/job-dsl-plugin/3a205447608734938775c2195f86c15a2d313bec
            Log:
            Merge remote-tracking branch 'ldez/JENKINS-33674'

            [FIXES JENKINS-32785]

            Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/dd385afd8cbc...3a2054476087

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/views/ColumnsContext.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/views/ListViewSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/3a205447608734938775c2195f86c15a2d313bec Log: Merge remote-tracking branch 'ldez/ JENKINS-33674 ' [FIXES JENKINS-32785] Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/dd385afd8cbc...3a2054476087
            Hide
            daspilker Daniel Spilker added a comment -

            Will be released in 1.45.

            Show
            daspilker Daniel Spilker added a comment - Will be released in 1.45.

              People

              • Assignee:
                daspilker Daniel Spilker
                Reporter:
                bherb Benjamin Herbert
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: